From nobody Fri Jul 28 19:09:24 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RCHJ21j6kz4pbtd for ; Fri, 28 Jul 2023 19:09:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RCHJ16BNZz3NYh for ; Fri, 28 Jul 2023 19:09:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-51d95aed33aso3102388a12.3 for ; Fri, 28 Jul 2023 12:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1690571376; x=1691176176; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=o8SIinCy0IyumGAhHpGQSrMKCZ+8e1Y0AibvgUrW7Nw=; b=uOQTvm8YhOaXDZ+pwsT+ABGLQav46HRa+q7zmwG8fK0uymPgjuLBVgJ+TNLuQXi0/j h+QZghpK6kJEkRRymyZqfSabeCWkhf3oK8gaXwZu5xJ0IyYqeqTWTFm7ePAy/ExHuMxf EeGtg4U0Du+App+wIyuHRt1z/uWXC0XX1zyYLEpYkAc60jXYA/FQHm0kwIyv39PcX29R W18NBvkkGvNQ/uK6pRzWpLXnCt9KnZtEAb/RLTBrX47bmjqe00DiYIhAsBImg2RUH14r 4IKNcND5u9nUTtn6RX1PWzMvn7Ai1af/RZLp1VtQ2nfq19v1EC0Xa/T4IJMcQiVhJJrb MLwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690571376; x=1691176176; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o8SIinCy0IyumGAhHpGQSrMKCZ+8e1Y0AibvgUrW7Nw=; b=ZObc3wUKyZdHZxnJRvS+WOkDcs17nFfSDb6OEpDNat2WoXEP1+9bhCENsKS8BXA6S/ nJvabrWaNA3xJjfU86u9Eg5tGPv9A8rol5gEhDrHx44rGPUxNNYRphWHZ439CgPEyxGX htNvp1uGPL4VSjlcL+QAH09U2fFedR7H4F/wW9t9/F6QQP24lnCu+zYq6FTrmbYv8jCn tXlnusSvhpm/h1mkOXwUafFygnAIMz/2Y0AgzKOdKQ1bfe0nPH9IUNMvOdAbDfueMq/N 3qjl3kpww8uiWORc4ISDvFfoXbo5JbeguuDBuxpOkMpKzMwkcZD3nQS/NNS7u0CX3rZw g3Xw== X-Gm-Message-State: ABy/qLaudDzI1U4uh4RIMisK7L3dnSoD8QY7EB4cnRJjzdWjhIMqZFao fRZBgDFNsfusnbCKSmMqh6C4rNKbLkP8IilJW9jquw== X-Google-Smtp-Source: APBJJlEY9ctKhInbKw9VeyGPuHi5jhfzYDttooMC3LH7yXCRHIoeperAx6YBI/iDP3+Xjqq5U3eT8B3lSF211cKviI0= X-Received: by 2002:aa7:c54e:0:b0:522:ab06:7213 with SMTP id s14-20020aa7c54e000000b00522ab067213mr989037edr.27.1690571375511; Fri, 28 Jul 2023 12:09:35 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202307070510.3675AWZS051152@gitrepo.freebsd.org> <65b0e348-b27d-f641-1004-6f76ff3ebfbd@FreeBSD.org> <0504b648-df5e-4125-c4bc-01d4ecd5374d@FreeBSD.org> <40ECF84B-ECF1-4700-9059-F971BBD3668B@jrtc27.com> In-Reply-To: <40ECF84B-ECF1-4700-9059-F971BBD3668B@jrtc27.com> From: Warner Losh Date: Fri, 28 Jul 2023 13:09:24 -0600 Message-ID: Subject: Re: git: 971bac5ace7a - main - kbd: consolidate kb interfaces (phase one) To: Jessica Clarke Cc: Renato Botelho , Warner Losh , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000004e1cba060190d26a" X-Rspamd-Queue-Id: 4RCHJ16BNZz3NYh X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --0000000000004e1cba060190d26a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 28, 2023, 1:04 PM Jessica Clarke wrote: > On 28 Jul 2023, at 20:01, Renato Botelho wrote: > > > > On 28/07/23 00:04, Warner Losh wrote: > >> On Thu, Jul 27, 2023 at 5:48=E2=80=AFAM Renato Botelho > wrote: > >> On 07/07/23 02:10, Warner Losh wrote: > >> > The branch main has been updated by imp: > >> > > >> > URL: > >> > https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262349fa2808188a= 11a5ffeed > < > https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262349fa2808188a= 11a5ffeed > > > >> > > >> > commit 971bac5ace7a3c2262349fa2808188a11a5ffeed > >> > Author: Michael > > >> > AuthorDate: 2023-07-07 02:32:45 +0000 > >> > Commit: Warner Losh > >> > CommitDate: 2023-07-07 05:10:18 +0000 > >> > > >> > kbd: consolidate kb interfaces (phase one) > >> > > >> > Refactor to eliminate duplicated rate and delay tables, wit= h > >> minor style > >> > tweaks for changed lines. Remove an obsolete comment about > >> needing to > >> > convert from microseconds to ticks (that's done elsewhere). > >> Remove > >> > traiing whitespace in kbdcontrol.c. > >> > > >> > Except for the new warning, no change in behavior > >> > > >> > Sponsored by: DSS GmbH > >> > Reviewed by: imp [minor style tweaks as well] > >> > Pull Request: https://github.com/freebsd/pull/683 > >> > >> > Differential Revision: https://reviews.freebsd.org/D38818 > >> > >> > --- > >> > sys/dev/adb/adb_kbd.c | 12 ++------- > >> > sys/dev/atkbdc/atkbd.c | 18 +++++--------- > >> > sys/dev/gpio/gpiokeys.c | 10 ++------ > >> > sys/dev/hid/hkbd.c | 10 ++------ > >> > sys/dev/kbdmux/kbdmux.c | 23 +++++------------ > >> > sys/dev/usb/input/ukbd.c | 10 ++------ > >> > sys/dev/vkbd/vkbd.c | 18 +++++--------- > >> > sys/sys/kbio.h | 7 ++++++ > >> > usr.sbin/kbdcontrol/kbdcontrol.c | 53 > >> +++++++++++++++++++++------------------- > >> > 9 files changed, 61 insertions(+), 100 deletions(-) > >> After this change I started seeing following error building > kbdcontrol: > >> Building > /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcontrol/kbdcontrol.o > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? > >> static const int ndelays =3D nitems(kbdelays); > >> ^~~~~~~~ > >> ndelays > >> /usr/include/sys/param.h:324:28: note: expanded from macro 'nitems' > >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > >> declared here > >> static const int ndelays =3D nitems(kbdelays); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? > >> static const int ndelays =3D nitems(kbdelays); > >> ^~~~~~~~ > >> ndelays > >> /usr/include/sys/param.h:324:42: note: expanded from macro 'nitems' > >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > >> declared here > >> static const int ndelays =3D nitems(kbdelays); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: error: subscripted > >> value is not an array, pointer, or vector > >> static const int ndelays =3D nitems(kbdelays); > >> ^~~~~~~~~~~~~~~~ > >> /usr/include/sys/param.h:324:44: note: expanded from macro 'nitems' > >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > >> ~~~^~ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > >> undeclared identifier 'kbrates' > >> static const int nrepeats =3D nitems(kbrates); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > >> undeclared identifier 'kbrates' > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: error: use of > >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? > >> if (delay <=3D kbdelays[n]) > >> ^~~~~~~~ > >> ndelays > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > >> declared here > >> static const int ndelays =3D nitems(kbdelays); > >> ^ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: error: subscript= ed > >> value is not an array, pointer, or vector > >> if (delay <=3D kbdelays[n]) > >> ~~~~~~~~^~ > >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: error: use of > >> undeclared identifier 'kbrates' > >> if (repeat <=3D kbrates[n]) > >> ^ > >> 8 errors generated. > >> *** Error code 1 > >> I haven't seen this. How do I recreate this? Does this happen on a > clean build? > > > > After I upgrade system to recent CURRENT the error is gone. > > kbdcontrol requires an updated sys/kbio.h, so if you try and do a make > of just it outside of make buildenv and without having first installed > updated headers to worldtmp then you won=E2=80=99t get the updated sys/kb= io.h. > I don=E2=80=99t think that=E2=80=99s something we support in general, onl= y when it > happens to work? > Generally you need to do a make buildenv and the rebuild inside of that environment. Warner > Jess > > --0000000000004e1cba060190d26a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Jul 28, 2023, 1:04 PM Jessica Clarke <jrtc27@jrtc27.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On 28 Jul 2023, at 20:01, Renato Botelho <= garga@FreeBSD.org> wrote:
>
> On 28/07/23 00:04, Warner Losh wrote:
>> On Thu, Jul 27, 2023 at 5:48=E2=80=AFAM Renato Botelho <garga@fr= eebsd.org <mailto:garga@freebsd.org>> wrote:
>>=C2=A0 =C2=A0 On 07/07/23 02:10, Warner Losh wrote:
>>=C2=A0 =C2=A0 =C2=A0> The branch main has been updated by imp: >>=C2=A0 =C2=A0 =C2=A0>
>>=C2=A0 =C2=A0 =C2=A0> URL:
>>=C2=A0 =C2=A0 https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262= 349fa2808188a11a5ffeed <https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ac= e7a3c2262349fa2808188a11a5ffeed>
>>=C2=A0 =C2=A0 =C2=A0>
>>=C2=A0 =C2=A0 =C2=A0> commit 971bac5ace7a3c2262349fa2808188a11a5= ffeed
>>=C2=A0 =C2=A0 =C2=A0> Author:=C2=A0 =C2=A0 =C2=A0Michael <git@pae= pcke.de <mailto:git@paepcke.de>>
>>=C2=A0 =C2=A0 =C2=A0> AuthorDate: 2023-07-07 02:32:45 +0000
>>=C2=A0 =C2=A0 =C2=A0> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <= ;imp@FreeBSD.org>
>>=C2=A0 =C2=A0 =C2=A0> CommitDate: 2023-07-07 05:10:18 +0000
>>=C2=A0 =C2=A0 =C2=A0>
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 kbd: consolidate kb in= terfaces (phase one)
>>=C2=A0 =C2=A0 =C2=A0>
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Refactor to eliminate = duplicated rate and delay tables, with
>>=C2=A0 =C2=A0 minor style
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 tweaks for changed lin= es.=C2=A0 Remove an obsolete comment about
>>=C2=A0 =C2=A0 needing to
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 convert from microseco= nds to ticks (that's done elsewhere).
>>=C2=A0 =C2=A0 Remove
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 traiing whitespace in = kbdcontrol.c.
>>=C2=A0 =C2=A0 =C2=A0>
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Except for the new war= ning, no change in behavior
>>=C2=A0 =C2=A0 =C2=A0>
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0DSS GmbH
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 imp [minor style tweaks as well]
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Pull Request: https://github.com/freebsd/pull/683
>>=C2=A0 =C2=A0 <https://github.com/freebsd/p= ull/683>
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 Differential Revision:= https://reviews.freebsd.org/D38818
>>=C2=A0 =C2=A0 <https://reviews.freebsd.org/D= 38818>
>>=C2=A0 =C2=A0 =C2=A0> ---
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/adb/adb_kbd.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 12 ++-------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/atkbdc/atkbd.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 18 +++++---------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/gpio/gpiokeys.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 10 ++------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/hid/hkbd.c=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 10 ++------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/kbdmux/kbdmux.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 23 +++++------------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/usb/input/ukbd.c=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0| 10 ++------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/dev/vkbd/vkbd.c=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 18 +++++---------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0sys/sys/kbio.h=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 7 ++++++
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0usr.sbin/kbdcontrol/kbdcontrol= .c | 53
>>=C2=A0 =C2=A0 +++++++++++++++++++++-------------------
>>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A09 files changed, 61 insertions= (+), 100 deletions(-)
>>=C2=A0 =C2=A0 After this change I started seeing following error bu= ilding kbdcontrol:
>>=C2=A0 =C2=A0 Building /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcon= trol/kbdcontrol.o
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: erro= r: use of
>>=C2=A0 =C2=A0 undeclared identifier 'kbdelays'; did you mea= n 'ndelays'?
>>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^= ~~~~~~~
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 n= delays
>>=C2=A0 =C2=A0 /usr/include/sys/param.h:324:28: note: expanded from = macro 'nitems'
>>=C2=A0 =C2=A0 #define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((= x)) / sizeof((x)[0]))
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^<= br> >>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note= : 'ndelays'
>>=C2=A0 =C2=A0 declared here
>>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: erro= r: use of
>>=C2=A0 =C2=A0 undeclared identifier 'kbdelays'; did you mea= n 'ndelays'?
>>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^= ~~~~~~~
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 n= delays
>>=C2=A0 =C2=A0 /usr/include/sys/param.h:324:42: note: expanded from = macro 'nitems'
>>=C2=A0 =C2=A0 #define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((= x)) / sizeof((x)[0]))
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note= : 'ndelays'
>>=C2=A0 =C2=A0 declared here
>>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: erro= r: subscripted
>>=C2=A0 =C2=A0 value is not an array, pointer, or vector
>>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~
>>=C2=A0 =C2=A0 /usr/include/sys/param.h:324:44: note: expanded from = macro 'nitems'
>>=C2=A0 =C2=A0 #define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((= x)) / sizeof((x)[0]))
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ~~~^~
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: erro= r: use of
>>=C2=A0 =C2=A0 undeclared identifier 'kbrates'
>>=C2=A0 =C2=A0 static const int nrepeats =3D nitems(kbrates);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0^
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: erro= r: use of
>>=C2=A0 =C2=A0 undeclared identifier 'kbrates'
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: er= ror: use of
>>=C2=A0 =C2=A0 undeclared identifier 'kbdelays'; did you mea= n 'ndelays'?
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (delay <=3D kbdelays[n])
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0^~~~~~~~
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0ndelays
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note= : 'ndelays'
>>=C2=A0 =C2=A0 declared here
>>=C2=A0 =C2=A0 static const int ndelays =3D nitems(kbdelays);
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: er= ror: subscripted
>>=C2=A0 =C2=A0 value is not an array, pointer, or vector
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (delay <=3D kbdelays[n])
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0~~~~~~~~^~
>>=C2=A0 =C2=A0 /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: er= ror: use of
>>=C2=A0 =C2=A0 undeclared identifier 'kbrates'
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (repeat <=3D kbrates[n])
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ^
>>=C2=A0 =C2=A0 8 errors generated.
>>=C2=A0 =C2=A0 *** Error code 1
>> I haven't seen this. How do I recreate this? Does this happen = on a clean build?
>
> After I upgrade system to recent CURRENT the error is gone.

kbdcontrol requires an updated sys/kbio.h, so if you try and do a make
of just it outside of make buildenv and without having first installed
updated headers to worldtmp then you won=E2=80=99t get the updated sys/kbio= .h.
I don=E2=80=99t think that=E2=80=99s something we support in general, only = when it
happens to work?

Generally you need to do a make buildenv and the rebuild in= side of that environment.=C2=A0

Warner=C2=A0
Jess

--0000000000004e1cba060190d26a--