From nobody Fri Jul 28 19:04:04 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RCH9t60Hqz4pYmc for ; Fri, 28 Jul 2023 19:04:18 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RCH9s4fpJz3M4l for ; Fri, 28 Jul 2023 19:04:17 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3175f17a7baso2486938f8f.0 for ; Fri, 28 Jul 2023 12:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jrtc27.com; s=gmail.jrtc27.user; t=1690571055; x=1691175855; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zDgAGxmWDRlYZZgSm9T7LvO0XgEkkQXCrOOtuIyvGQc=; b=MDctWZ7DI1WCFN/fIsTx2vhAnwe/cbijp0on1UkxZk1++WDm5taZn7foIIKJFfV9u9 bDjyQ8WtZtWKyLBI7caYM+DNFU3R7JBpPt4FoSElkjja/2UKA09lV6qC9Ty+UOQKeCBr ShsZxzJs3N9W5RJvYRatPcLHmazxt1bHbyKD6zDdLGfg72u3/zrarplgvut5n5TksbHD gFk74yHGwAGJ6wV0AQ8yMwc6QObeVZVaxExI7LDyvmT1KfRfFCaoe5XxeEioFO3uwjiQ newntpKZYe3m4NkcfKv8X28mgY1QugHHsnuprJGtdaFb7NV2+c4J8PaCn/pMTW2uGhkC i3Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690571055; x=1691175855; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zDgAGxmWDRlYZZgSm9T7LvO0XgEkkQXCrOOtuIyvGQc=; b=Y46cXFZw9R35JIbqw6EPBwXy4Z5zWCiP2aYEoL9UUFa30OJYS08KdPiL/cLwanBVqJ E0o2e+q/RXno/tTMcDW61riH4x3jsN2VBpXQKlWXsCGf1rUsC+82cwQSgXdnS7vBgdBk ead4Slm8u4/kDbUrTbNKuWlFUHI6IIBI0J5U1hAPmEubFLLiJWr6z8lwaQUh3eac012R JtK4O2aE76OmD3q7+QAOX+abmxE/D7d79uJhzQnaEOoh47fxz8JDrYam6RqSfQCEL4t/ 2zuzoVGavYyNPj5Vvvzy78FZCfgK2UBlk6ztPYAMsoF2fMGzLMhrfCAyKqUypMXf0xjP O+lw== X-Gm-Message-State: ABy/qLZlgmgmh43WgP5zCk/T9gabVHoenmxPBAzLG24ccElEJIzPtbKV THs/Q2J+A1dLle570qsT2Dj7Dg== X-Google-Smtp-Source: APBJJlFgwMhWqf3relLBq6VsDHpzmYPvip3mjSmRZWzo6fo4mZaoPyFjFIEzE4CsYT+TmsZcBel7xQ== X-Received: by 2002:adf:fa47:0:b0:314:216d:c00e with SMTP id y7-20020adffa47000000b00314216dc00emr2178669wrr.42.1690571055202; Fri, 28 Jul 2023 12:04:15 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id r5-20020a056000014500b00314367cf43asm5436297wrx.106.2023.07.28.12.04.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jul 2023 12:04:14 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: git: 971bac5ace7a - main - kbd: consolidate kb interfaces (phase one) From: Jessica Clarke In-Reply-To: <0504b648-df5e-4125-c4bc-01d4ecd5374d@FreeBSD.org> Date: Fri, 28 Jul 2023 20:04:04 +0100 Cc: Warner Losh , Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <40ECF84B-ECF1-4700-9059-F971BBD3668B@jrtc27.com> References: <202307070510.3675AWZS051152@gitrepo.freebsd.org> <65b0e348-b27d-f641-1004-6f76ff3ebfbd@FreeBSD.org> <0504b648-df5e-4125-c4bc-01d4ecd5374d@FreeBSD.org> To: Renato Botelho X-Mailer: Apple Mail (2.3731.600.7) X-Rspamd-Queue-Id: 4RCH9s4fpJz3M4l X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On 28 Jul 2023, at 20:01, Renato Botelho wrote: >=20 > On 28/07/23 00:04, Warner Losh wrote: >> On Thu, Jul 27, 2023 at 5:48=E2=80=AFAM Renato Botelho = > wrote: >> On 07/07/23 02:10, Warner Losh wrote: >> > The branch main has been updated by imp: >> > >> > URL: >> = https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262349fa2808188a1= 1a5ffeed = >> > >> > commit 971bac5ace7a3c2262349fa2808188a11a5ffeed >> > Author: Michael > >> > AuthorDate: 2023-07-07 02:32:45 +0000 >> > Commit: Warner Losh >> > CommitDate: 2023-07-07 05:10:18 +0000 >> > >> > kbd: consolidate kb interfaces (phase one) >> > >> > Refactor to eliminate duplicated rate and delay tables, = with >> minor style >> > tweaks for changed lines. Remove an obsolete comment = about >> needing to >> > convert from microseconds to ticks (that's done = elsewhere). >> Remove >> > traiing whitespace in kbdcontrol.c. >> > >> > Except for the new warning, no change in behavior >> > >> > Sponsored by: DSS GmbH >> > Reviewed by: imp [minor style tweaks as well] >> > Pull Request: https://github.com/freebsd/pull/683 >> >> > Differential Revision: https://reviews.freebsd.org/D38818 >> >> > --- >> > sys/dev/adb/adb_kbd.c | 12 ++------- >> > sys/dev/atkbdc/atkbd.c | 18 +++++--------- >> > sys/dev/gpio/gpiokeys.c | 10 ++------ >> > sys/dev/hid/hkbd.c | 10 ++------ >> > sys/dev/kbdmux/kbdmux.c | 23 +++++------------ >> > sys/dev/usb/input/ukbd.c | 10 ++------ >> > sys/dev/vkbd/vkbd.c | 18 +++++--------- >> > sys/sys/kbio.h | 7 ++++++ >> > usr.sbin/kbdcontrol/kbdcontrol.c | 53 >> +++++++++++++++++++++------------------- >> > 9 files changed, 61 insertions(+), 100 deletions(-) >> After this change I started seeing following error building = kbdcontrol: >> Building = /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcontrol/kbdcontrol.o >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? >> static const int ndelays =3D nitems(kbdelays); >> ^~~~~~~~ >> ndelays >> /usr/include/sys/param.h:324:28: note: expanded from macro = 'nitems' >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) >> ^ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' >> declared here >> static const int ndelays =3D nitems(kbdelays); >> ^ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? >> static const int ndelays =3D nitems(kbdelays); >> ^~~~~~~~ >> ndelays >> /usr/include/sys/param.h:324:42: note: expanded from macro = 'nitems' >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) >> ^ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' >> declared here >> static const int ndelays =3D nitems(kbdelays); >> ^ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: error: = subscripted >> value is not an array, pointer, or vector >> static const int ndelays =3D nitems(kbdelays); >> ^~~~~~~~~~~~~~~~ >> /usr/include/sys/param.h:324:44: note: expanded from macro = 'nitems' >> #define nitems(x) (sizeof((x)) / sizeof((x)[0])) >> ~~~^~ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of >> undeclared identifier 'kbrates' >> static const int nrepeats =3D nitems(kbrates); >> ^ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of >> undeclared identifier 'kbrates' >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: error: use of >> undeclared identifier 'kbdelays'; did you mean 'ndelays'? >> if (delay <=3D kbdelays[n]) >> ^~~~~~~~ >> ndelays >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' >> declared here >> static const int ndelays =3D nitems(kbdelays); >> ^ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: error: = subscripted >> value is not an array, pointer, or vector >> if (delay <=3D kbdelays[n]) >> ~~~~~~~~^~ >> /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: error: use of >> undeclared identifier 'kbrates' >> if (repeat <=3D kbrates[n]) >> ^ >> 8 errors generated. >> *** Error code 1 >> I haven't seen this. How do I recreate this? Does this happen on a = clean build? >=20 > After I upgrade system to recent CURRENT the error is gone. kbdcontrol requires an updated sys/kbio.h, so if you try and do a make of just it outside of make buildenv and without having first installed updated headers to worldtmp then you won=E2=80=99t get the updated = sys/kbio.h. I don=E2=80=99t think that=E2=80=99s something we support in general, = only when it happens to work? Jess