From nobody Fri Jul 28 11:44:19 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RC5QG3bCzz4pf9T; Fri, 28 Jul 2023 11:44:22 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RC5QF75n5z3rt8; Fri, 28 Jul 2023 11:44:21 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690544662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jiPCWyYiCDS3aYdYpt6NXtxewLodB4Eb8PjHCAzFgdo=; b=wfPCnWJ1TUOfE0BvQee7Z8+77cut6xx+sp0Rf4jygwqsF3jk7YWsNbXmrGtdW1jPIXhvIy V9PSr9cQLnbEbbWLlniP1XsBLT83ZvcYVi/jYC/nY44lMPzNerfAPeBNwNmlCmXi/L6RUI +ZCXvcMjR7KCcOaFAqcO9ikgMsifDafLKay5LkNTRPYviujirE553ugmXD1SfI3EJbM+v0 e24nZ+V1lVa9iO4vy27IVXEttD5x87x306LODKIcDRkoSUt1WO22KIXu/hJDCQA5Dr51JD ql3gdHv5wYH3fVJiBZjPoAgpW+djzoeChhS3ABxi9b+jWG4rL8XXNHgxZgyGqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690544662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jiPCWyYiCDS3aYdYpt6NXtxewLodB4Eb8PjHCAzFgdo=; b=d94F/sMoQfWm85lRFtYk1wp6JX4S0u5P+6BVNwFPJ9pd2u0RYrOzvEeNxB1Vr/og4mSZb/ Jv1oeqNZ9fSD5UAAvBE+s2nD5odT0IGlqCDEy+0p4uoI2LV5VKT+TXYrInqlYz5F/aJCVi h+IjkvsmOhM43q6A60pqgy/yKAjHyVGJkFk9nb+00wKDldZBoXdcARUrwMZMGK2/1XlM2R fjfOINTKamE/qVFP5aOaZHk7fk2uhrD+e6hyQPGFGi7iO78zJZC1lHkrD995KvT//5KZq8 3RguKaRJaZr8y+Ev5Lgvw98sylJ5TOXQLFl9ZcCVp0BconcgsOSOjfMadDxDDg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690544662; a=rsa-sha256; cv=none; b=BB55r3+tWV0+kY5WhBlKGt/9Ueo6/695Xriuj5dkMhcKQHmm9dDzNl71iS/V/zQR7Urgk0 Jj4AEdDQbnrFh+zRfvyHxFO2Zk3+d9AHVtHUa7GVq8rsnCNrjSGpSKJRoGdPEaaqNdxUxI /Sz7d+IkjGfvxA+7I9pMHYjImmlGzJd+vRVg2v0ywS0UrFqaH34l7k5k692fLlm1eNv4Wp jpxeIU0x4DDnE2H6XweyjXLccLlZXwVr2J+P0hlCqsbdCzxxpQ1htw+YPjaLrjTj0BCixW DSAzEEEactyWRu69qihWJe3yqpGaxt9NE9oyRWKLMRQbVcpc5Q7iF8UYbM7Acw== Received: from [172.21.4.170] (dynamic-177-53-82-16.telecominternet.net.br [177.53.82.16]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RC5QF0fdgz13HR; Fri, 28 Jul 2023 11:44:20 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: <8c6abf32-40cf-db61-11d8-5f88dcb0d7a0@FreeBSD.org> Date: Fri, 28 Jul 2023 08:44:19 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 971bac5ace7a - main - kbd: consolidate kb interfaces (phase one) Content-Language: en-US To: Warner Losh Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202307070510.3675AWZS051152@gitrepo.freebsd.org> <65b0e348-b27d-f641-1004-6f76ff3ebfbd@FreeBSD.org> From: Renato Botelho In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/07/23 00:04, Warner Losh wrote: > > > On Thu, Jul 27, 2023 at 5:48 AM Renato Botelho > wrote: > > On 07/07/23 02:10, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=971bac5ace7a3c2262349fa2808188a11a5ffeed > > > > commit 971bac5ace7a3c2262349fa2808188a11a5ffeed > > Author:     Michael > > > AuthorDate: 2023-07-07 02:32:45 +0000 > > Commit:     Warner Losh > > CommitDate: 2023-07-07 05:10:18 +0000 > > > >      kbd: consolidate kb interfaces (phase one) > > > >      Refactor to eliminate duplicated rate and delay tables, with > minor style > >      tweaks for changed lines.  Remove an obsolete comment about > needing to > >      convert from microseconds to ticks (that's done elsewhere). > Remove > >      traiing whitespace in kbdcontrol.c. > > > >      Except for the new warning, no change in behavior > > > >      Sponsored by:           DSS GmbH > >      Reviewed by:            imp [minor style tweaks as well] > >      Pull Request: https://github.com/freebsd/pull/683 > > >      Differential Revision: https://reviews.freebsd.org/D38818 > > > --- > >   sys/dev/adb/adb_kbd.c            | 12 ++------- > >   sys/dev/atkbdc/atkbd.c           | 18 +++++--------- > >   sys/dev/gpio/gpiokeys.c          | 10 ++------ > >   sys/dev/hid/hkbd.c               | 10 ++------ > >   sys/dev/kbdmux/kbdmux.c          | 23 +++++------------ > >   sys/dev/usb/input/ukbd.c         | 10 ++------ > >   sys/dev/vkbd/vkbd.c              | 18 +++++--------- > >   sys/sys/kbio.h                   |  7 ++++++ > >   usr.sbin/kbdcontrol/kbdcontrol.c | 53 > +++++++++++++++++++++------------------- > >   9 files changed, 61 insertions(+), 100 deletions(-) > > After this change I started seeing following error building kbdcontrol: > > Building /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcontrol/kbdcontrol.o > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > undeclared identifier 'kbdelays'; did you mean 'ndelays'? > static const int ndelays = nitems(kbdelays); >                                    ^~~~~~~~ >                                    ndelays > /usr/include/sys/param.h:324:28: note: expanded from macro 'nitems' > #define nitems(x)       (sizeof((x)) / sizeof((x)[0])) >                                   ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > declared here > static const int ndelays = nitems(kbdelays); >                   ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > undeclared identifier 'kbdelays'; did you mean 'ndelays'? > static const int ndelays = nitems(kbdelays); >                                    ^~~~~~~~ >                                    ndelays > /usr/include/sys/param.h:324:42: note: expanded from macro 'nitems' > #define nitems(x)       (sizeof((x)) / sizeof((x)[0])) >                                                 ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > declared here > static const int ndelays = nitems(kbdelays); >                   ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: error: subscripted > value is not an array, pointer, or vector > static const int ndelays = nitems(kbdelays); >                             ^~~~~~~~~~~~~~~~ > /usr/include/sys/param.h:324:44: note: expanded from macro 'nitems' > #define nitems(x)       (sizeof((x)) / sizeof((x)[0])) >                                                ~~~^~ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > undeclared identifier 'kbrates' > static const int nrepeats = nitems(kbrates); >                                     ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > undeclared identifier 'kbrates' > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: error: use of > undeclared identifier 'kbdelays'; did you mean 'ndelays'? >                          if (delay <= kbdelays[n]) >                                       ^~~~~~~~ >                                       ndelays > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > declared here > static const int ndelays = nitems(kbdelays); >                   ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: error: subscripted > value is not an array, pointer, or vector >                          if (delay <= kbdelays[n]) >                                       ~~~~~~~~^~ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: error: use of > undeclared identifier 'kbrates' >                          if (repeat <= kbrates[n]) >                                        ^ > 8 errors generated. > *** Error code 1 > > > I haven't seen this. How do I recreate this? Does this happen on a clean > build? I completely removed /usr/obj, went to /usr/src/usr.sbin/kbdcontrol and tried to build it with and without META_MODE. It failed on both. Running system is 14.0-CURRENT #0 main-2f11df633: Wed Apr 5 -- Renato Botelho