From nobody Sun Jul 23 18:27:06 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R8BbH1QDdz4p6H3; Sun, 23 Jul 2023 18:27:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R8BbG6sdKz3RF8; Sun, 23 Jul 2023 18:27:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690136827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oC+5GgMluqg4V4uomXHruYfC+Xf+SIqU+5MC54JdCNc=; b=AUYUt9lwjtjTxR5LBkb4IxlojCqC/zKqv1OrQ+3FNh+QdDRmrEDmvx1yQAK4lHunkX/uLM dUCSNVFN2SOk+RKAkbisJqRiiJjQd64wVgWwHCAbXkIMAywM+h1gxfhMY7hOjeOrXRhvOo 3r9Ul4/5qaUmxbGwxejs3wHK/ZX4u5+uUZMVtLue7luXfk639fqWuVoHHq4rshaEoIDyCP ycuAm8b7rQQi4y4wnZcaGeCg2eThehzTG1Ichhr6CHOe6RAjrrHVTZKN+cEptXgZB+7IOj N4FyvGez7qR/2LXxFp7RGkc6b+qBD1t/CTdjKWfKnc1Zp4+lIlL53txYwyxbbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690136827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oC+5GgMluqg4V4uomXHruYfC+Xf+SIqU+5MC54JdCNc=; b=WSkwj22m71UrrLsda9bLLBOOoRroTdFbc18seqE0Skua5wgR37zF8KevWJEcM4S9bA/8/R 17mElE29g9M+7BdxnUApZGiPaCWtHHPwwreiILh8JptZ2yOXTJKDN5zYl6yDaJhNduIpwn a3KJUum85saP5EqjGRnq7ynubNZbaFrCl4jJdkwg+PZpVXmz5lRa3IFmYYEarMFyb4Zidj KiontMhg9MdG3Nj5Lq2rNKy/7quZQGnE35mfo4j6v5BZpuJ7IgV+54kyK8klR9W0efIO4q ei9ZRTCcC28Er3cD8JD4P5OYRSnyjLVUiLtfJVGZNPTNma+IN97OqYiSbz4Vag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690136827; a=rsa-sha256; cv=none; b=TDtCEkL+JTtO28+eXIVcnk8lookA8UgRGq/HnzXaMgffSmj81OFfZWjfYTuI8lab9OlEoz guxh5VRUGN0R1HGkTe9VI6kv40xt7c75kyPMPsIKnMyIdivQO+tKc0Y/VeB9TCWL1RtWFr 3ZQRVYg6OF3T2pswCnY2I5BYUwshURdMbumuHkwNFkS7gJLtOplBS/ZAa5GJTcOhc4bxLw cXA+UAMQHnIiW7TTsPIAUPZaBzFoxPky/Hi+tqCf++KBGk3w8c11p9Jk/tLDxfMiD2zABE PaAtICFAG8k6iLV8eHZoYZpHtQWJ4cOLmqMnjOO32QrLjNyF8eFbuFGM0tMwmg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4R8BbG5bSrzmVR; Sun, 23 Jul 2023 18:27:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 36NIR69E058732; Sun, 23 Jul 2023 18:27:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 36NIR6H1058731; Sun, 23 Jul 2023 18:27:06 GMT (envelope-from git) Date: Sun, 23 Jul 2023 18:27:06 GMT Message-Id: <202307231827.36NIR6H1058731@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: c1f875b54b19 - stable/13 - clang: re-downgrade implicit int/function declarations to warning only List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: c1f875b54b192f35b57953c514ec1800a4b5d0d9 Auto-Submitted: auto-generated The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=c1f875b54b192f35b57953c514ec1800a4b5d0d9 commit c1f875b54b192f35b57953c514ec1800a4b5d0d9 Author: Dimitry Andric AuthorDate: 2023-04-25 19:24:04 +0000 Commit: Dimitry Andric CommitDate: 2023-07-23 17:38:09 +0000 clang: re-downgrade implicit int/function declarations to warning only This reapplies upstream commit c0141f3c300f by Aaron Ballman: Downgrade implicit int and implicit function declaration to warning only The changes in Clang 15.0.0 which enabled these diagnostics as a warning which defaulted to an error caused disruption for people working on distributions such as Gentoo. There was an explicit request to downgrade these to be warning-only in Clang 15.0.1 with the expectation that Clang 16 will default the diagnostics to an error. See https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213 for more details on the discussion. See https://reviews.llvm.org/D133800 for the public review of these changes. As noted in the upstream discussion, there are many programs that fail to configure or build correctly, if these warnings are turned into errors by default. Note that most affected programs in ports are relatively old, and are unlikely to be fixed by actually adjusting their declarations, but by compiling with -std=gnu89, which downgrades the errors back to warning again. Lots of tedious work for very little gain. (cherry picked from commit c3450ad127e94d3fa67ae337310e59c002f51bfc) --- .../llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td b/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td index bfe582d8252f..31a27558bca4 100644 --- a/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -419,7 +419,7 @@ def warn_implicit_function_decl : Warning< InGroup, DefaultIgnore; def ext_implicit_function_decl_c99 : ExtWarn< "call to undeclared function %0; ISO C99 and later do not support implicit " - "function declarations">, InGroup, DefaultError; + "function declarations">, InGroup; def note_function_suggestion : Note<"did you mean %0?">; def err_ellipsis_first_param : Error< @@ -709,7 +709,7 @@ def ext_implicit_lib_function_decl : ExtWarn< def ext_implicit_lib_function_decl_c99 : ExtWarn< "call to undeclared library function '%0' with type %1; ISO C99 and later " "do not support implicit function declarations">, - InGroup, DefaultError; + InGroup; def note_include_header_or_declare : Note< "include the header <%0> or explicitly provide a declaration for '%1'">; def note_previous_builtin_declaration : Note<"%0 is a builtin with type %1">; @@ -4390,7 +4390,7 @@ def err_ident_list_in_fn_declaration : Error< "a parameter list without types is only allowed in a function definition">; def ext_param_not_declared : ExtWarn< "parameter %0 was not declared, defaults to 'int'; ISO C99 and later do not " - "support implicit int">, InGroup, DefaultError; + "support implicit int">, InGroup; def err_param_default_argument : Error< "C does not support default arguments">; def err_param_default_argument_redefinition : Error< @@ -10104,7 +10104,7 @@ def warn_receiver_forward_class : Warning< def note_method_sent_forward_class : Note<"method %0 is used for the forward class">; def ext_missing_type_specifier : ExtWarn< "type specifier missing, defaults to 'int'; ISO C99 and later do not support " - "implicit int">, InGroup, DefaultError; + "implicit int">, InGroup; def err_missing_type_specifier : Error< "a type specifier is required for all declarations">; def err_decimal_unsupported : Error<