git: d5e2d0f140ce - main - openssh: document a locally-applied workaround

From: Ed Maste <emaste_at_FreeBSD.org>
Date: Tue, 18 Jul 2023 16:27:12 UTC
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=d5e2d0f140cef6d09c4ddeb594cee027642366a7

commit d5e2d0f140cef6d09c4ddeb594cee027642366a7
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-07-18 16:23:31 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-07-18 16:27:02 +0000

    openssh: document a locally-applied workaround
    
    We have a local hacky workaround for an issue caused by a hacky
    upstream autoconf test.  Reported upstream on the OpenSSH mailing list:
    https://lists.mindrot.org/pipermail/openssh-unix-dev/2022-May/040242.html
    
    PR:             209441
    Sponsored by:   The FreeBSD Foundation
---
 crypto/openssh/FREEBSD-upgrade | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/crypto/openssh/FREEBSD-upgrade b/crypto/openssh/FREEBSD-upgrade
index caf9597b0d6b..905b65ec4e3d 100644
--- a/crypto/openssh/FREEBSD-upgrade
+++ b/crypto/openssh/FREEBSD-upgrade
@@ -187,6 +187,14 @@
    recognize and ignore the configuration options to avoid breaking
    existing configurations.
 
+12) PrintLastLog bugfix
+
+   Upstream's autoconf sets DISABLE_LASTLOG if the system does not have
+   lastlog.ll_line, but uses it to disable the PrintLastLog configuration
+   option altogether.  There is a hacky SKIP_DISABLE_LASTLOG_DEFINE=yes to
+   skip setting DISABLE_LASTLOG which we've applied for FreeBSD, but the
+   autoconf machinery really ought to be reworked.  Reported upstream at
+   https://lists.mindrot.org/pipermail/openssh-unix-dev/2022-May/040242.html
 
 
 This port was brought to you by (in no particular order) DARPA, NAI