From nobody Sat Jul 15 04:11:29 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R2vzz3QcZz4mlpm for ; Sat, 15 Jul 2023 04:11:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R2vzy2mLZz48tQ for ; Sat, 15 Jul 2023 04:11:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-316f4abb1e1so199791f8f.3 for ; Fri, 14 Jul 2023 21:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1689394301; x=1691986301; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eF0LCqXowlJ6n3kecubwE7YQWMoxHDYkpf9ccHwsWfc=; b=Sai1Yb3jrwymeU1NrdCuqP0j5+rNmz9gr6g3x0hzmqgenOVDvlDajSfWo65d4km1sp lMUQ0ozO7fmMiH0LwBUO1HXg1+b3QHDB3oAEzQWFsZR+23KhSwHTxMPfiRbuITwGOoaN yZs8HwoF95BK8YW2ZeeiCjVXHJCxJbCLjRAEhNJ9hlEqmJkjaGQq9wLsWOWbkAiFtx+Q hsPGhUqMvU+sFLzDdfKtwYklcXNNyq0X9m1OHjAii6WZ+BVghkSn3BW2MgeQh8Opo+0q ibq1mzRt3c8GskZgFcxPtv6+pXGepuMFwo/WbL6H27J9JcfKa/dy0tw6o11GFEVbL6GU hwWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689394301; x=1691986301; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eF0LCqXowlJ6n3kecubwE7YQWMoxHDYkpf9ccHwsWfc=; b=ITA3Uo4+Vfis94kXLBwmUwc3+w5sQ3YbynSpSVLkXdDu7EwBZIEGhKRZ8QnzxWDFtw kqP4DpktJ1X7FDAd4CuPVAZuCS0GPxqhcVFsA6eXTGllMDWKtWQXCt1HStnOVsAEv1Oo 4TCP1OwxEZS8lN9SEth/Y4jeHVtpx6pAbbqw3XuawJfP3pQ4hHccaj7+z/T3xxOnqCwE rKZkcKBZYqqSkHGXwkLSMm1HZ2j7RKBcj0I0Sl48Sq70jl5QBg/anQvnNkYcFIuwrjN6 IkAnlc3WWwZrSkGxz9QV4coKCnlZg8qSkgy7WzV9FRajDUFFfMifgcQOjZ3NXlvCM3lt O44A== X-Gm-Message-State: ABy/qLYgwIVy5ORhkYMt03ytac8ZdzbjZ3XCPYrML2yX858555tqMtpU 2E8VvW8NAUzVgL99VnCBMzySDrT0XBwqIf+8yCBilg== X-Google-Smtp-Source: APBJJlGjiEQi7P1bTxKmKsGxz/XDcFoDriPkDBw1k4oHviRo/Ed7k8cN6rZlxeP+WWcZMbiYWUd+sTh7xsrLY9JUlaY= X-Received: by 2002:a5d:6783:0:b0:313:f33c:24c4 with SMTP id v3-20020a5d6783000000b00313f33c24c4mr4580472wru.39.1689394300554; Fri, 14 Jul 2023 21:11:40 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202307140957.36E9vXtE047194@gitrepo.freebsd.org> <54f0a239-ebc3-9496-f1b2-ea8eb15f80ba@FreeBSD.org> In-Reply-To: <54f0a239-ebc3-9496-f1b2-ea8eb15f80ba@FreeBSD.org> From: Warner Losh Date: Fri, 14 Jul 2023 22:11:29 -0600 Message-ID: Subject: Re: git: 09267cc15284 - main - /etc/rc.subr: add support for kld sysctl variables To: Kyle Evans Cc: Doug Rabson , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000002baa5706007ec39d" X-Rspamd-Queue-Id: 4R2vzy2mLZz48tQ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000002baa5706007ec39d Content-Type: text/plain; charset="UTF-8" On Fri, Jul 14, 2023, 9:59 PM Kyle Evans wrote: > On 7/14/23 04:57, Doug Rabson wrote: > > The branch main has been updated by dfr: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=09267cc15284795fef958fb9ed786bb2382d6763 > > > > commit 09267cc15284795fef958fb9ed786bb2382d6763 > > Author: Doug Rabson > > AuthorDate: 2023-06-21 12:26:17 +0000 > > Commit: Doug Rabson > > CommitDate: 2023-07-14 09:49:47 +0000 > > > > /etc/rc.subr: add support for kld sysctl variables > > > > For kernel modules loaded by scripts in /etc/rc.d and > > /usr/local/etc/rc.d, if there is a file in /etc/sysctl.conf.d named > > name>.conf, then this will be loaded using the sysctl(8) utility. > For > > instance, sysctl variable changes for the pf kernel module would be > > placed in the file /etc/sysctl.conf.d/pf.conf. > > > > PR: 272129 > > Reviewed by: imp freebsd_igalic.co > > MFC after: 2 weeks > > Differential Revision: https://reviews.freebsd.org/D40886 > > Hello! > > We discussed this out-of-band a little bit, but to circle back to the > list: I'd like to propose changing the name of this directory before we > cement it into a release; we've seen some non-zero amount of confusion > with rc.conf.d (at least on IRC) because files within are actually > conditionally sourced based on daemons being loaded. Many folks are > conditioned to seeing $file.d as "just a way to split up $file," and > when the contents are conditionally loaded it's not necessarily intuitive. > > We could document the behavior in hier(7) in additional to > sysctl.conf(5), but IMO it'd be really nice for conditionally-sourced > directories to be a little more descriptively named so that one could > make an educated guess as to when the contents are used. For this one, > perhaps "sysctl.kld.d"? > > I don't really know what to propose for rc.conf.d, perhaps rc.svcconf.d, > but we'd need to actually implement rc.conf.d as you might guess it's > implemented if we change it since it's seen a number of releases. > I'm planning on adding this behavior to devmatch (and maybe moving it more into devd), if that affects the naming. Warner Thanks, > > Kyle Evans > --0000000000002baa5706007ec39d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Jul 14, 2023, 9:59 PM Kyle Evans <kevans@freebsd.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On 7/14/23 04:57, Doug Rabson wrote:
> The branch main has been updated by dfr:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D09267cc15284795fef958fb9ed786b= b2382d6763
>
> commit 09267cc15284795fef958fb9ed786bb2382d6763
> Author:=C2=A0 =C2=A0 =C2=A0Doug Rabson <dfr@FreeBSD.org>
> AuthorDate: 2023-06-21 12:26:17 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Doug Rabson <dfr@FreeBSD.org>
> CommitDate: 2023-07-14 09:49:47 +0000
>
>=C2=A0 =C2=A0 =C2=A0 /etc/rc.subr: add support for kld sysctl variables=
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 For kernel modules loaded by scripts in /etc/rc.d = and
>=C2=A0 =C2=A0 =C2=A0 /usr/local/etc/rc.d, if there is a file in /etc/sy= sctl.conf.d named <kld
>=C2=A0 =C2=A0 =C2=A0 name>.conf, then this will be loaded using the = sysctl(8) utility. For
>=C2=A0 =C2=A0 =C2=A0 instance, sysctl variable changes for the pf kerne= l module would be
>=C2=A0 =C2=A0 =C2=A0 placed in the file /etc/sysctl.conf.d/pf.conf.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0272129
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 imp freebsd_ig= alic.co
>=C2=A0 =C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 2 weeks
>=C2=A0 =C2=A0 =C2=A0 Differential Revision: https:/= /reviews.freebsd.org/D40886

Hello!

We discussed this out-of-band a little bit, but to circle back to the
list: I'd like to propose changing the name of this directory before we=
cement it into a release; we've seen some non-zero amount of confusion =
with rc.conf.d (at least on IRC) because files within are actually
conditionally sourced based on daemons being loaded. Many folks are
conditioned to seeing $file.d as "just a way to split up $file," = and
when the contents are conditionally loaded it's not necessarily intuiti= ve.

We could document the behavior in hier(7) in additional to
sysctl.conf(5), but IMO it'd be really nice for conditionally-sourced directories to be a little more descriptively named so that one could
make an educated guess as to when the contents are used.=C2=A0 For this one= ,
perhaps "sysctl.kld.d"?

I don't really know what to propose for rc.conf.d, perhaps rc.svcconf.d= ,
but we'd need to actually implement rc.conf.d as you might guess it'= ;s
implemented if we change it since it's seen a number of releases.

I'= m planning on adding this behavior to devmatch (and maybe moving it more in= to devd), if that affects the naming.

Warner=C2=A0

Thanks,

Kyle Evans
--0000000000002baa5706007ec39d--