From nobody Tue Jul 11 20:49:48 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R0tKT1f4Sz4dPyf; Tue, 11 Jul 2023 20:49:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R0tKS6Rdgz3tMF; Tue, 11 Jul 2023 20:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689108588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WqS7Hg3UcJ7N+u9EgVJk9ppIN3Nj2Wb6MrYbAH2OKZM=; b=RYGzF7QUhCebTIEBd5ZVuThyKOcXjkFpGhNDhfSBCgYbbtfnah6EAdoa9/uoH32mG1RWek HQ4YOgA2/KoC646RiMR7jJgsY5L5Rb32S5R4D7VTGHftRswtw5A63PmdO1vyNd+rXBlQXr qa/ULfpFYmjHGYeylJCK0D7RAd4fb0/bg9/Z8DLbPn1o6eWEV76xoYae+5uvzGNeJ+glFU ePH+nqRWcVDK8whToBmBdePJg2+/XfaMKCSVqvyu7eFwrlEtr0YkVW81j//3dySlDeWjzp +dWyjHbLtZbZmMpaRHbltuml3gKAKOTsR/+jrCq6Zyb+1fAu7P1f6UcWy/9jhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689108588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WqS7Hg3UcJ7N+u9EgVJk9ppIN3Nj2Wb6MrYbAH2OKZM=; b=pz4xVrTSWXFVTBQnuj4jeHujYIIrpiwRH9SgPNBNmPm3gvV4KKYboAW78+CDYhs6LmdBbz l0L5+YPyFXnQzLCndoYG1EBWQPi4xkLj15+WwDjH3s464V4uSyzulAONwA7B3JslukK5Nv EABUIAJ2L85ngsdDKl8WQtwFE2OQNGcRBvNPNrd+8SYCZApt+ZRtKARIqFYMtzZeXmaAU3 7iHchJtclQFkDrl0nS04cWp0+8CFyehVHe6ka54aJAPZncZg3ryWL6kDgyZdCVWjoR69+S Mq448yAWKQjNM7LZSEcu09CuN6siU/vevozmWhFv+ec3q/HfAgYnGOIhhvltkQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689108588; a=rsa-sha256; cv=none; b=scMPCYT5Lilc3lkpHZ8DUDZHx1Rk6LvbTUh1ttR1Wd6FBC3G6fFtCCTbXVnlCbI2rkLgtF od0Ey3vePn5e6jGZqw8df6JBbR3VpJXGQXg1MidfcqvmdgL+k/8T1FhgR+P4e/SjRPJ+DB 7vSLE6DSbBqvQA/qqvkQa7MZLBpskDlRXVzXDdgavF/IBOSqB1pQSVF2FgRjOBUQCdTDKm 4FXAbDpxrateZ02ebUZtnai0XLosNVBmvRbwJaqvhQQqTxOpbeS5qChCWlNGhaJtJMrLtw nJBnUr1efWe/ovsoXRpUFLmwgGH4AWz/19sdusgDaBKg3/Id+/YJ2BIAey448g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4R0tKS5WYRzglH; Tue, 11 Jul 2023 20:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 36BKnm0W071296; Tue, 11 Jul 2023 20:49:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 36BKnmQD071295; Tue, 11 Jul 2023 20:49:48 GMT (envelope-from git) Date: Tue, 11 Jul 2023 20:49:48 GMT Message-Id: <202307112049.36BKnmQD071295@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jessica Clarke Subject: git: d1e44bc94494 - main - kmod.mk: Use portable printf '%s' over non-portable echo -n List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d1e44bc94494448de196948d698b637b6e1df4bf Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=d1e44bc94494448de196948d698b637b6e1df4bf commit d1e44bc94494448de196948d698b637b6e1df4bf Author: Jessica Clarke AuthorDate: 2023-07-11 20:30:06 +0000 Commit: Jessica Clarke CommitDate: 2023-07-11 20:30:06 +0000 kmod.mk: Use portable printf '%s' over non-portable echo -n Whilst /bin/echo on macOS and Linux implement -n, as do the builtin echos in bash and zsh, the builtin echo in dash does not, causing the first line of the output to be -n foo rather than just foo, and there to be an extra newline in the output and thus blank line, both of which result in "Symbol ... is not present in *.kld" warnings appearing in the build output (once for -n foo and once for the empty string for each module where EXPORT_SYMS is a list of symbols). MFC after: 1 week --- sys/conf/kmod.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk index a3ff24f0571a..246af5ba1e81 100644 --- a/sys/conf/kmod.mk +++ b/sys/conf/kmod.mk @@ -266,7 +266,7 @@ ${FULLPROG}: ${OBJS} ${BLOB_OBJS} .if ${EXPORT_SYMS} == NO :> export_syms .elif !exists(${.CURDIR}/${EXPORT_SYMS}) - echo -n "${EXPORT_SYMS:@s@$s${.newline}@}" > export_syms + printf '%s' "${EXPORT_SYMS:@s@$s${.newline}@}" > export_syms .else grep -v '^#' < ${EXPORT_SYMS} > export_syms .endif