Re: git: 29cbe944e928 - main - CONTRIBUTING.md: minor changes
- In reply to: John Baldwin : "Re: git: 29cbe944e928 - main - CONTRIBUTING.md: minor changes"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 10 Jul 2023 18:26:01 UTC
On Mon, Jul 10, 2023 at 10:00 AM John Baldwin <jhb@freebsd.org> wrote: > On 7/9/23 8:06 PM, Warner Losh wrote: > > On Sat, Jul 8, 2023 at 12:15 AM Alexey Dokuchaev <danfe@freebsd.org> > wrote: > > > >> On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote: > >>> commit 29cbe944e9287c2e61928c456512d3990aaffdaa > >>> > >>> CONTRIBUTING.md: minor changes > >>> > >>> - Misspelled GitHub > >>> - angle bracket not escaped correctly > >>> - Double white spaces > >> > >> You've removed them, while they are typically used after full stops > >> as texts render better with them unless you're using proportional > >> font. > >> > > > > It's the modern way.... but WuerfelDev also had a commit that backed > > that part out that I didn't fold in... > > I'm still torn since I see so many conflicting things about it :( > > > > I'm leaning towards putting them back. > > FWIW, I still use monospace fonts for code and thus still use double spaces > for the reason Alexey stated. Reading code in proportional fonts (where > spacing is naturally wider at sentence breaks) is not really viable with > style(9) which mixes tabs with spaces for indentation. > OK. I've just pushed the other half of 788 where the submitter backed out the removal of the double spaces. And now I know why they should remain. Warner