From nobody Mon Jul 10 16:00:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R07yd39VFzZb57; Mon, 10 Jul 2023 16:00:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R07yd2lCDz4lDK; Mon, 10 Jul 2023 16:00:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689004857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/LDJbeagjC9/1z0rNaBlnHfoC63PND1CwaGhaJWnLY=; b=oacUfdVzl3GIviqGMiFrSOH8fOSHynv7FvdetkgJigiTPmd0/3vaRiz2c25jivNmhOaRey xXmCp+OSSLeHZJtRcUCy8srFfauUYNT4Owm0Jy1ODyVcTCH00Z9TCB6xBWBNRxeqpj4qdS Q15gyVpt10JB21gCvZO2sSWKFfwVITTFYlbtEEaexrJoUyF+R8rNM2GAvI4j4mlW9w7NdQ KcmIR5g++5si/c+1QTj9VSbnDLMOd7LENoZwTC8hmKyri8EkecWb+6lhOuXNECTiFERD9x /cyDl3WyPmgorqMF8POGqb8DTJ3Q0ItG+XvPPZhll6Lw1/GTU+T20fKsJntP2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689004857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/LDJbeagjC9/1z0rNaBlnHfoC63PND1CwaGhaJWnLY=; b=r6fOiJqLKbooi7askDQCo4FypaAHOVq0dzFhfLpKjoNC69mXrEMv9aqtNSbz4lbml9fZVF 8nU4lk5oPqcVIc2viba+PAsp+qtoFqfPHWo8SR+4bJz8v56A9vND1uSuqiV0aCYGW/bc1X ICzI98fcSYnlucsJy8majW5XnVetvHfd3s6if40vXpVgiKqk98E3RZAQHYidDj+kmEv+5Y e847HgHpC3OI0nBNZNiotVsvKf50u1naFAmWQTGt3NwKQz68iro7s9aPGrZyYrdjIGfN72 bkKrwyx49zb3G3qBXwiSAVhZhU2Zqh+8+5KIW+WzIYMgwUjTeYWsvMDnfHrxIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689004857; a=rsa-sha256; cv=none; b=Em6iX1I/hvB7eeT7+6RYfDDFZCsGG9DYCLVX33QY9UYhrEzIGiPF1p78EttPFBHoIMZ/qb zIpd0vs5FnhvdOGzxTmEeVGSh/7Tm5mff4MNqPpSQs7g2kA2eVR666E0HrzyNYO5rJ8sNU jmnlG7w3y7ScKwNVyOBuvHQ1a+GEcILfVK/zERzuc4ZaL3BP5pFkCmK4rw4o79K2WHJRis SWtrVlYHXZcsvTfv3141/wW5y3DOcGCLRpfJDdEsDTrWKpPMCHKArMtLyxriirTG/FYsVu 58Y0r7MXcF/jKAVwvC8N7I47ohkIsQFFS4X/TzkNeaX66ogdQKWx5aIoGHV6bQ== Received: from [IPV6:2601:648:8680:16b0:6966:ae6d:9848:4b0b] (unknown [IPv6:2601:648:8680:16b0:6966:ae6d:9848:4b0b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R07yc4pnBz1DQm; Mon, 10 Jul 2023 16:00:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <1e07dc3f-071c-bd8d-3f15-4aaee60582f6@FreeBSD.org> Date: Mon, 10 Jul 2023 09:00:54 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Warner Losh , Alexey Dokuchaev Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202307072123.367LNZ4J060993@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: 29cbe944e928 - main - CONTRIBUTING.md: minor changes In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 7/9/23 8:06 PM, Warner Losh wrote: > On Sat, Jul 8, 2023 at 12:15 AM Alexey Dokuchaev wrote: > >> On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote: >>> commit 29cbe944e9287c2e61928c456512d3990aaffdaa >>> >>> CONTRIBUTING.md: minor changes >>> >>> - Misspelled GitHub >>> - angle bracket not escaped correctly >>> - Double white spaces >> >> You've removed them, while they are typically used after full stops >> as texts render better with them unless you're using proportional >> font. >> > > It's the modern way.... but WuerfelDev also had a commit that backed > that part out that I didn't fold in... > I'm still torn since I see so many conflicting things about it :( > > I'm leaning towards putting them back. FWIW, I still use monospace fonts for code and thus still use double spaces for the reason Alexey stated. Reading code in proportional fonts (where spacing is naturally wider at sentence breaks) is not really viable with style(9) which mixes tabs with spaces for indentation. -- John Baldwin