From nobody Fri Jul 07 16:48:23 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QyK920r3bz4m2lL; Fri, 7 Jul 2023 16:48:38 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QyK916Ktnz4LRy; Fri, 7 Jul 2023 16:48:37 +0000 (UTC) (envelope-from mpp302@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-76724c50ee5so38365985a.0; Fri, 07 Jul 2023 09:48:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688748516; x=1691340516; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ryr5tFJfkPA93WDdrViQkSKk/1yHsgwJXK2pgf8UI9E=; b=VMO5rnvfpAXmDBiPKKDfbDjI54C9P9QY6Zpyf6UX3UTsH7bEaEgiGFZUfHEzwetG23 xySWLcqq7O2YvW8dSuh+ByvxvALsl97ZBP2OrA5dviJ5FPMutmyBo0EsVOFs1ttmJCoI W6vfMFTQVOlzTvQLcfji4iuSHc+xaO5ZBBppNABufmjACwa6XnqC4vbC6K/z973jntbf PLXqkTGeUyxqMWbdB+nRGJ/WGItV5y0CZkgUU2MlKBq44/bj2kK/5qtEKxSWvtYmqyYP Pxj9UCF4hUJFltDOBo2Lz70/3YRBgOTn2RPEQ7fZynynL0R1Sc6gFVysvPep8iy7irF9 u9WA== X-Gm-Message-State: ABy/qLZHizjHhOMqVYHd7S41a4+aSPG2GYmOV7kwVJ3bRr06pwNkDed3 SVCZeWWeEUKmVTqQOGlAaqxcCv5TcSGVVBMb X-Google-Smtp-Source: APBJJlFlNpqi7czjzejyoLbDIzcsx9s0QV4OSmaOl9+6j4qlV8/g1BUigHLDdaFurfiHg3NJJrL+xw== X-Received: by 2002:a05:6214:411c:b0:62b:5410:322d with SMTP id kc28-20020a056214411c00b0062b5410322dmr6166256qvb.6.1688748516603; Fri, 07 Jul 2023 09:48:36 -0700 (PDT) Received: from smtpclient.apple ([95.90.240.90]) by smtp.gmail.com with ESMTPSA id f5-20020a05620a068500b00767bac7d537sm104562qkh.24.2023.07.07.09.48.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jul 2023 09:48:36 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: git: c81495a621c4 - main - fwget: Fix quoting From: Mateusz Piotrowski <0mp@FreeBSD.org> In-Reply-To: <202307070719.3677JqSM058134@gitrepo.freebsd.org> Date: Fri, 7 Jul 2023 18:48:23 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <98DC3116-140D-47C8-8B33-E5C666A76D75@FreeBSD.org> References: <202307070719.3677JqSM058134@gitrepo.freebsd.org> To: Emmanuel Vadot X-Mailer: Apple Mail (2.3731.600.7) X-Rspamd-Queue-Id: 4QyK916Ktnz4LRy X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Hey Manu, > On 7. Jul 2023, at 09:19, Emmanuel Vadot wrote: >=20 > The branch main has been updated by manu: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc81495a621c461b3d3395a7c5b0e7345= 8201c443 >=20 > commit c81495a621c461b3d3395a7c5b0e73458201c443 > Author: Emmanuel Vadot > AuthorDate: 2023-07-07 07:16:05 +0000 > Commit: Emmanuel Vadot > CommitDate: 2023-07-07 07:19:41 +0000 >=20 > fwget: Fix quoting >=20 > This kind of quoting doesn't work, no idea why shellcheck wanted = this. > If there is a "safer" way to "fix" this feel free to do it just = test > that it's working after. >=20 > Reported by: Kenneth Raplee > Sponsored by: Beckhoff Automation GmbH & Co. KG > Fixes: 7ad4d94d5bf2 ("Fix some shell issues by adding quotes and = replace backticks with $()") > --- > usr.sbin/fwget/fwget.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/usr.sbin/fwget/fwget.sh b/usr.sbin/fwget/fwget.sh > index 61acaee86687..90bc23b07077 100644 > --- a/usr.sbin/fwget/fwget.sh > +++ b/usr.sbin/fwget/fwget.sh > @@ -27,7 +27,7 @@ > # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > # POSSIBILITY OF SUCH DAMAGE. >=20 > -: "${LIBEXEC_PATH:=3D'/usr/libexec/fwget'}" > +: ${LIBEXEC_PATH:=3D"/usr/libexec/fwget"} What was the reported bug here? Quoting here looks alright. >=20 > usage() > { >=20 Best, Mateusz