From nobody Tue Jul 04 04:36:53 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qw94L39Ffz4l5RX for ; Tue, 4 Jul 2023 04:37:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qw94L2Mpfz4QRl for ; Tue, 4 Jul 2023 04:37:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-51d7e8dd118so6450887a12.1 for ; Mon, 03 Jul 2023 21:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1688445425; x=1691037425; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i7qQrYasDz+wkhaew2eWKzH7KtnfuaUyugdjognILq0=; b=t8jfmq6eLsIuqKwqL+WaLCjm7O4JtaKDepUSI4Dx+hBcHuxk2KVoyTRL/Rk/Y0WXJa vX8jyyZL8sFXhEGYaIDvMXp1n0ZvBkRUMTE28NwdR9+zd9uESUim8uOM8QvDJxtfWuX0 hepz1OGfQ/n89cFufHuVOSef17ZnLBZgiTYZY9OAICplDDMtV6fncQ6Gc60dx9AqYTVZ +TaGGWEQs6e1h98T/czHVyosqk7Np5sw35M61yEGS87ZXCacX3bM4j+kXZEKk3niIdK6 6i86orCyQIWEuIL9E918T8qB1ALDObieHEFYhZmRmruB+uNbRWLoN8JBOxqAB6nHECR2 Xl6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688445425; x=1691037425; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i7qQrYasDz+wkhaew2eWKzH7KtnfuaUyugdjognILq0=; b=EFjdtcfyb4BvdPXcnNxvHvd4NDzmwEQhc8wGu6tGBUoHxypQulTtT55GhxjK+gGJJ1 12Dh4KRpwRwh4Ra8FIZS0EB0ZEwM06BJSwxHHiE6vI9GkM87lmncc7TSYuf0MwGp1nJb CTuoAooE+Wa8Nb+V6PDiZFxTa+obKajkzs9CkG3gpky+hB3r745nxpj3mmNBjK934gP/ GDW3ErPUSOZRfqEOWQsGpJhtBOAHHIZOFXRCOiZaHllHxydBk5xIGGrWws3gXJ9In0gb t2khzN5K2hEscHUaTHfEd3nXaEPaYfXkokdqhY8qWaK5Wa/Rnz1aCvjiYksRUlwzGLz2 zFGw== X-Gm-Message-State: ABy/qLZhBCEoBap9zWZJ9EeslYUWrVJeBXCWeIG46JLhvHSwXxU42oBP w02B7UEfpbcTAPrMdAOnxSUZblpDpxdlJ2CLM9kMUT6skim7tg3q X-Google-Smtp-Source: APBJJlHUodAmLzw446crzgboXFP6y7STqUBBMjSXbGV2fxFmodDUbKmcrkP/BaHHhh7E+mfA7JY9pazxWn67+i+wxhA= X-Received: by 2002:aa7:d78b:0:b0:51e:d60:b6b5 with SMTP id s11-20020aa7d78b000000b0051e0d60b6b5mr4062922edq.41.1688445424804; Mon, 03 Jul 2023 21:37:04 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202307040308.36438MTA093771@gitrepo.freebsd.org> <1037448433.54513.1688441647903@mail.yahoo.com> <1767168745.2134945.1688443634249@mail.yahoo.com> In-Reply-To: <1767168745.2134945.1688443634249@mail.yahoo.com> From: Warner Losh Date: Mon, 3 Jul 2023 22:36:53 -0600 Message-ID: Subject: Re: git: 4456846a1a0d - main - bin/date: Upgrade calculations To: Pedro Giffuni Cc: src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000c4b79205ffa1d586" X-Rspamd-Queue-Id: 4Qw94L2Mpfz4QRl X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000c4b79205ffa1d586 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni wrote: > (Sorry for top posting) > > Oh yes, the analysis is fine, and it is quicker to fix than what I had in > mind. > > I'll take a look at fixing it now, but due to external issues I may have > to leave the fix for next weekend. > Ah great. I'll not have time to fix this... thanks for taking care of this... sorry if i was a It grumpy... it's been a day... Warner Pedro. > > > On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh > wrote: > > > > > On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni wrote: > > Hmm ... > > Dragonfly has no armv7 or i386, so they didn't get it too wrong. > I guess the int64_t would be a quick fix or another option, which I was > consideirng, was to look at unsigning it but taking care of the edge cases > ... I was too lazy for that. > > Please go ahead and do the quick fix ;) > > > What makes you say it's a quick fix? If the calculations need 64 bits, > int64_t is the proper data type. How is that analysis wrong? > > Also, it's tradition that you should fix it... > > Warner > --000000000000c4b79205ffa1d586 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni <pfg@freebsd.org> wrote:
(Sorry for top posting)

Oh yes, the analysis is fine, and it is quicker to fix than what= I had in mind.

I'll t= ake a look at fixing it now, but due to external issues I may have to leave= the fix for next weekend.

Ah great. I'll not have time to= fix this... thanks for taking care of this... sorry if i was a It grumpy..= . it's been a day...

Warner

Pe= dro.


=20
=20
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Lo= sh <imp@bsdimp.com> wrote:




On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <p= fg@freebsd.org> wrote:
Hmm ...

<= /div>
Dragonfly has no armv7 or i386, so they didn't ge= t it too wrong.
I guess=C2=A0the int64_t would be a quick fix or another option, = which I was consideirng, was to look at unsigning it but taking care of the= edge cases ... I was too lazy for that.

Please go ahead and do the quick fix ;)
=

What makes you = say it's a quick fix? If the calculations need 64 bits, int64_t is the = proper data type. How is that analysis wrong?

=
Also, it's tradition that you should fix it...
Warner
--000000000000c4b79205ffa1d586--