From nobody Tue Jan 31 14:58:04 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P5p851jzjz3cjyk; Tue, 31 Jan 2023 14:58:13 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P5p8502fnz3sMn; Tue, 31 Jan 2023 14:58:12 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.16.1/8.16.1) with ESMTP id 30VEw5Ww096320; Tue, 31 Jan 2023 08:58:05 -0600 (CST) (envelope-from mike@karels.net) Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id W+rvIn0s2WM+eAEAs/W3XQ (envelope-from ); Tue, 31 Jan 2023 08:58:05 -0600 From: Mike Karels To: "Alexander V. Chernikov" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: e80699a809a0 - main - netlink: add NETLINK to GENERIC. Date: Tue, 31 Jan 2023 08:58:04 -0600 X-Mailer: MailMate (1.14r5937) Message-ID: <93BA13C5-6870-4BBE-B725-C7FDA5FBAAF5@karels.net> In-Reply-To: <202301311425.30VEPYhj039848@gitrepo.freebsd.org> References: <202301311425.30VEPYhj039848@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4P5p8502fnz3sMn X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 31 Jan 2023, at 8:25, Alexander V. Chernikov wrote: > The branch main has been updated by melifaro: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3De80699a809a079c4e6739405= 44d6ddd944e8d08e > > commit e80699a809a079c4e673940544d6ddd944e8d08e > Author: Alexander V. Chernikov > AuthorDate: 2023-01-31 14:22:11 +0000 > Commit: Alexander V. Chernikov > CommitDate: 2023-01-31 14:22:11 +0000 > > netlink: add NETLINK to GENERIC. > > This is a followup of 692e19cf5195 (add netlink to GENERIC@amd64). > > Netlink is a communication protocol defined in RFC 3549. It is asyn= c, > TLV-based protocol, providing 1-1 and 1-many communications between= kernel > and userland. Netlink is currently used in Linux kernel to modify, = read and > subscribe for nearly all networking states. Interface state, addres= ses, routes, > firewall, rules, fibs, etc, are controlled via Netlink. > > Netlink support was added in D36002. It has got a number of improve= ments and > first customers since then: > * net/bird2 got netlink support, enabling route multipath in FreeBS= D > * netlink-based devd notifications are being worked on ( D37574 ). > * linux(4) fully supports and depends on Netlink > > Enabling Netlink in GENERIC targets two goals. > The first one is to provide stability for the third-party userland = applications, > so they can rely on the fact that netlink always exists since 14.0 = and potentially 13.2. > Loadable module makes life of the app delepers harder. For example,= `net/bird2` can be > either build with netlink or rtsock support, but not both. > > The second goal is to enable gradual conversion of the base userlan= d tools > to use netlink(4) interfaces. Converting tools like netstat (D36529= ), route, > ifconfig one-by-one simplifies testing and addressing the feedback.= > Othewise, switching all base to use netlink at once may be too big = of a leap. > > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D37783 > --- > sys/arm/conf/std.armv7 | 1 + > sys/arm64/conf/std.arm64 | 1 + > sys/i386/conf/GENERIC | 1 + > sys/powerpc/conf/GENERIC64 | 1 + > sys/riscv/conf/GENERIC | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/sys/arm/conf/std.armv7 b/sys/arm/conf/std.armv7 > index 8ace5c01eeab..03cc0ae5a2b8 100644 > --- a/sys/arm/conf/std.armv7 > +++ b/sys/arm/conf/std.armv7 > @@ -11,6 +11,7 @@ options CC_CUBIC # include CUBIC congestion control= > options TCP_HHOOK # hhook(9) framework for TCP > device crypto # core crypto support > options IPSEC_SUPPORT # Allow kldload of ipsec and tcpmd5 > +options NETLINK # netlink(4) support Looks like the tabs are not right here. Kernel config files should use optionsOPTION so that the OPTION does not shift if the line is commented out. Most of the previous options do this. I see that several other recent options also use two tabs, including the amd64 NETLINK. Maybe we should do a cleanup pass. Mike > options SCTP_SUPPORT # Allow kldload of SCTP > options FFS # Berkeley Fast Filesystem > options SOFTUPDATES # Enable FFS soft updates support > diff --git a/sys/arm64/conf/std.arm64 b/sys/arm64/conf/std.arm64 > index 6480ca6530e4..1e664a3ba90c 100644 > --- a/sys/arm64/conf/std.arm64 > +++ b/sys/arm64/conf/std.arm64 > @@ -13,6 +13,7 @@ options INET # InterNETworking > options INET6 # IPv6 communications protocols > options CC_CUBIC # include CUBIC congestion control > options IPSEC_SUPPORT # Allow kldload of ipsec and tcpmd5 > +options NETLINK # netlink(4) support > options ROUTE_MPATH # Multipath routing support > options FIB_ALGO # Modular fib lookups > options TCP_OFFLOAD # TCP offload > diff --git a/sys/i386/conf/GENERIC b/sys/i386/conf/GENERIC > index 235713851016..5d30f2877c1c 100644 > --- a/sys/i386/conf/GENERIC > +++ b/sys/i386/conf/GENERIC > @@ -32,6 +32,7 @@ options VIMAGE # Subsystem virtualization, e.g. VN= ET > options INET # InterNETworking > options INET6 # IPv6 communications protocols > options IPSEC_SUPPORT # Allow kldload of ipsec and tcpmd5 > +options NETLINK # netlink(4) support > options ROUTE_MPATH # Multipath routing support > options TCP_HHOOK # hhook(9) framework for TCP > options TCP_OFFLOAD # TCP offload > diff --git a/sys/powerpc/conf/GENERIC64 b/sys/powerpc/conf/GENERIC64 > index bfd0cf342d95..37a78446f07a 100644 > --- a/sys/powerpc/conf/GENERIC64 > +++ b/sys/powerpc/conf/GENERIC64 > @@ -42,6 +42,7 @@ options VIMAGE # Subsystem virtualization, e.g. VN= ET > options INET # InterNETworking > options INET6 # IPv6 communications protocols > options IPSEC_SUPPORT # Allow kldload of ipsec and tcpmd5 > +options NETLINK # netlink(4) support > options ROUTE_MPATH # Multipath routing support > options TCP_OFFLOAD # TCP offload > options TCP_BLACKBOX # Enhanced TCP event logging > diff --git a/sys/riscv/conf/GENERIC b/sys/riscv/conf/GENERIC > index 2e35a49825d4..69c36511da80 100644 > --- a/sys/riscv/conf/GENERIC > +++ b/sys/riscv/conf/GENERIC > @@ -31,6 +31,7 @@ options INET # InterNETworking > options INET6 # IPv6 communications protocols > options TCP_HHOOK # hhook(9) framework for TCP > options IPSEC_SUPPORT # Allow kldload of ipsec and tcpmd5 > +options NETLINK # netlink(4) support > options ROUTE_MPATH # Multipath routing support > options TCP_OFFLOAD # TCP offload > options TCP_BLACKBOX # Enhanced TCP event logging