From nobody Mon Jan 30 20:57:57 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P5L9n5jwcz3cX9K; Mon, 30 Jan 2023 20:58:05 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P5L9n5BbQz3twQ; Mon, 30 Jan 2023 20:58:05 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675112285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C1r8W0cSiUqk7E7DYsNXquOlMjjuTLWANIpPaHt3S84=; b=jvFbIzd4QnzJHkgYpq9fpzqmfu/KcUw3xrpdEBz7WjW+qlxwGyM2bhqWucVjkKhOn/3TPn UmZdb3U7btx4r+yi0720IHIzkZE7DJWgJgUDtuZbSWHhfVhxObbxzM+iXtulZPYoaTAWn5 WUBXBVJt3gOLEkqX4sEAiBZA7LVtsHvPSU7+r3MaXSC6dcxKEP6yhcE1caj6wsvjckkF6S RMvEikLwWxJXA9m0Vjpt/U8p7cdqor49cwIfC3cX3q3mIQgmZ0qV75TEi9dvtqAks9xTPs /B1f2TxAh37L/Vxy5ZXa79bAIlqDnujDcrqrLpVruuZAHAeiUb7N40oWePZ//Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675112285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C1r8W0cSiUqk7E7DYsNXquOlMjjuTLWANIpPaHt3S84=; b=T4qWRxzKqGBF2C948fNCZd1r48bndcoi+u/+tRTEBRU9SwxymyPOahWhnwk2Nmnc38zO9/ faia5JBXSuTAPCuYaVfJXv8ezQ0dQUjOgEYqEcJB4B4f3tnvzmpPwwXPr+jwr3k1T224mq JinIE/bPEOgI1ulOzNF5z9X/eEe1icnvEVyacKp7FZ/N8OI+BTDc9exD+n7Offiv72QMb3 eZAe5CvGH98jvbevTO02DShUht0Hj7MthCXxVEGga9uIfgEtgKk7A19BMi1JdsExf8HFws SaI6bBF8ZIF/nSXZJ/VKVBCTIX9U6GhzWUrXym0tLta6AP4m6md5ExBaYhVcSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675112285; a=rsa-sha256; cv=none; b=lKzjOfltmJWrxYum1K6A9MUOcst97iWdmkrfG8K6yFqt8c0ILDhKYlpuZtBuoDEjn32d+Q MdOJwEqVK5Sbi76x6Shbb+RURSLKnn/96WCW7Tp131M9Xm6tG5cJm0puA/D+LPUgYudxdM nF8Gckby02a0t/jBAZso8iW0cXfVLQ4HRjLxTVBEZjn4jmPsNlrH1qTqk2ijMISiVKRIJl ayt4rtW27n+4KXRdGrlSnhxNcSIKZJMZMTqaLC0K1wlR1kGvwkQe7Q6+IusF8zUOp3E4SM Sp7L1CciupBBrrnYxPvWOX1GpGg5GAQJCtD6G4R3O63wVcNktgT28rYmPVUAJQ== Received: from [IPV6:2804:f1c:3d:2d00:f475:2b30:d00d:7732] (unknown [IPv6:2804:f1c:3d:2d00:f475:2b30:d00d:7732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P5L9m4xylzHnN; Mon, 30 Jan 2023 20:58:04 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: Date: Mon, 30 Jan 2023 17:57:57 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: git: ef7d10fde4f6 - main - Add missing check for xo_parse_args return code. Content-Language: en-US To: Phil Shafer , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202301302044.30UKi82I030877@gitrepo.freebsd.org> From: Renato Botelho In-Reply-To: <202301302044.30UKi82I030877@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 30/01/23 17:44, Phil Shafer wrote: > The branch main has been updated by phil: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ef7d10fde4f650c7e9ef207af53d5f116b689826 > > commit ef7d10fde4f650c7e9ef207af53d5f116b689826 > Author: Phil Shafer > AuthorDate: 2023-01-30 20:43:01 +0000 > Commit: Phil Shafer > CommitDate: 2023-01-30 20:43:01 +0000 > > Add missing check for xo_parse_args return code. > --- > usr.bin/iscsictl/iscsictl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/usr.bin/iscsictl/iscsictl.c b/usr.bin/iscsictl/iscsictl.c > index 258b4f7c28ac..5b2a62874163 100644 > --- a/usr.bin/iscsictl/iscsictl.c > +++ b/usr.bin/iscsictl/iscsictl.c > @@ -745,6 +745,9 @@ main(int argc, char **argv) > struct target *targ; > > argc = xo_parse_args(argc, argv); > + if (argc < 0) > + exit(1); > + Code seems to be indented with spaces instead of tabs -- Renato Botelho