Re: git: fdd4c35832de - main - usr.bin/gh-bc: update Makefiles for version 6.2.2
- In reply to: Stefan Eßer : "git: fdd4c35832de - main - usr.bin/gh-bc: update Makefiles for version 6.2.2"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 29 Jan 2023 23:03:54 UTC
On 28 Jan 2023, at 23:50, Stefan Eßer <se@FreeBSD.org> wrote:
>
> The branch main has been updated by se:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=fdd4c35832deb1d064f64c2c00e3c8c958be9a51
>
> commit fdd4c35832deb1d064f64c2c00e3c8c958be9a51
> Author: Stefan Eßer <se@FreeBSD.org>
> AuthorDate: 2023-01-28 22:48:34 +0000
> Commit: Stefan Eßer <se@FreeBSD.org>
> CommitDate: 2023-01-28 22:48:34 +0000
>
> usr.bin/gh-bc: update Makefiles for version 6.2.2
...
> -CFLAGS+= -DMAINEXEC=${PROGNAME}
> -CFLAGS+= -DNLSPATH=/usr/share/nls/%L/%N.cat
> -CFLAGS+= -DBUILD_TYPE=A
> +CFLAGS=-g -O0
This assignment instead of using "+=" appears to have broken the
riscv64sf build for me, since it passes "-march=rv64imac -mabi=lp64" via
the global CFLAGS to target the soft-float ABI.
That said, is -g -O0 maybe a debugging aid that you left in by accident?
Is there any reason not to compile bc with the regular, user-specified
CFLAGS? In that case, the line might just be deleted.
-Dimitry