From nobody Fri Jan 27 14:34:30 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3Kpl2dY8z3c62l; Fri, 27 Jan 2023 14:34:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3Kpk5SBcz3GtD; Fri, 27 Jan 2023 14:34:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 30REYUmr000032 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 16:34:33 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 30REYUmr000032 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 30REYUC8000031; Fri, 27 Jan 2023 16:34:30 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 27 Jan 2023 16:34:30 +0200 From: Konstantin Belousov To: "Bjoern A. Zeeb" Cc: Kirk McKusick , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 906c312bbf74 - main - Document the mntopts(3) functions. Message-ID: References: <202301151821.30FILnsY011391@gitrepo.freebsd.org> <9126pq56-345-1r1n-4o93-89nq26p6p07n@mnoonqbm.arg> <44q75o23-n3r-551-7r58-9sp3rq4qr393@mnoonqbm.arg> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44q75o23-n3r-551-7r58-9sp3rq4qr393@mnoonqbm.arg> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4P3Kpk5SBcz3GtD X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Fri, Jan 27, 2023 at 02:26:51PM +0000, Bjoern A. Zeeb wrote: > On Fri, 27 Jan 2023, Bjoern A. Zeeb wrote: > > > On Sun, 15 Jan 2023, Kirk McKusick wrote: > > > > Hi Kirk, > > > > > The branch main has been updated by mckusick: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=906c312bbf7493ccbcce883936d67e5c66a9c3c2 > > > > > > commit 906c312bbf7493ccbcce883936d67e5c66a9c3c2 > > > Author: Kirk McKusick > > > AuthorDate: 2023-01-15 18:20:48 +0000 > > > Commit: Kirk McKusick > > > CommitDate: 2023-01-15 18:21:31 +0000 > > > > > > Document the mntopts(3) functions. > > > > > > The mntopts(3) functions support operations associated with a mount > > > point. The main purpose of this commit is to document the mntopts(3) > > > functions that now appear in 18 utilities in the base system. See > > > mntopts(3) for the documentation details. > > > > > > The getmntopts() function appeared in 4.4BSD. The build_iovec(), > > > build_iovec_argf(), free_iovec(), checkpath(), and rmslashes() > > > functions were added with nmount(8) in FreeBSD 5.0. The getmntpoint() > > > and chkdoreload() functions are being added in this commit. > > > > > > These functions should be in a library but for historic reasons are > > > in a file in the sources for the mount(8) program. Thus, to access > > > them the following lines need to be added to the Makefile of the > > > program wanting to use them: > > > > > > SRCS+= getmntopts.c > > > MOUNT= ${SRCTOP}/sbin/mount > > > CFLAGS+= -I${MOUNT} > > > .PATH: ${MOUNT} > > > > > > Once these changes have been MFC'ed to 13 they may be made into > > > a library. > > > > > > Reviewed by: kib, gbe > > > MFC after: 2 weeks > > > Sponsored by: The FreeBSD Foundation > > > Differential Revision: https://reviews.freebsd.org/D37907 > > > > > > Could this change be the cause for (I'll try to back it out and the > > follow-up to see but it'll be a few hours...) > > This reverts commit 0bd4c448ec1dfdc2300a6cacca42e1fc7c4d8f14. > This reverts commit 906c312bbf7493ccbcce883936d67e5c66a9c3c2. > > And NFS ROOT works again. > > Please don't MFC until this is fixed. This is really strange, since the changes are purely user-space. You cannot get to that before root is mounted. > > PS: I am also always surprised how little netboot setup breakage shows > up these days (or how long it takes to be reported). We probably need > better test cases for this... > > > > https://lists.freebsd.org/archives/freebsd-fs/2023-January/001789.html > > > > > > > --- > > > sbin/fsck/Makefile | 4 + > > > sbin/fsck/fsck.c | 5 +- > > > sbin/fsck/fsutil.c | 44 ------ > > > sbin/fsck/fsutil.h | 1 - > > > sbin/fsck_ffs/main.c | 96 +----------- > > > sbin/growfs/growfs.c | 110 ++------------ > > > sbin/mount/Makefile | 11 +- > > > sbin/mount/getmntopts.3 | 181 ----------------------- > > > sbin/mount/getmntopts.c | 95 +++++++++++- > > > sbin/mount/mntopts.3 | 381 > > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > > sbin/mount/mntopts.h | 2 + > > > sbin/mount/mount.c | 18 +-- > > > sbin/tunefs/tunefs.c | 33 +---- > > > 13 files changed, 513 insertions(+), 468 deletions(-) > > > > > > -- > Bjoern A. Zeeb r15:7