From nobody Fri Jan 27 14:26:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3Kdr09w5z3c5CL; Fri, 27 Jan 2023 14:26:56 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3Kdq6gXzz3GFC; Fri, 27 Jan 2023 14:26:55 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674829615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ts8z7/Sw7BkBeyX7/F77j2BywBFP4vyOW3LaB2M6d/8=; b=k56wx0dB2VOt9+8tRdU3E6F+LP6CiOx6NtlDEAKKEhRwBsuqvHnpB0/8oVxJTz1rS3VBRp bh1BNyLcF7+Z9H+XGXQHGb+cHZUAA2ec5N066/3Wij9tALS8q7lGYiRt5FNVz/BK3+WEWj hP4pFkL9Uy3kf5WZMEvactmMHb0t8e3AOtD8YKbZWH7bRlNMPzjeLbTAZuqMNO3gEczmwq H2MRrJ0f6gaK3hHiSlzBykPDNeZbBD+O8ShNIj9gwSJgji/Ptjbrai3GBaDtDADwo6Waxa wnjBaI2wHXdC7FXqK3zHNTbAlXpt4n3DqoogpVHtLGzFDp8C90UOcKydqi2L/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674829615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ts8z7/Sw7BkBeyX7/F77j2BywBFP4vyOW3LaB2M6d/8=; b=wORWaGNUBLtYe9HCYdoFSMYeFB+k9BT3q8vd+iFn0zj2v4yzRzyCluI1lN+Av1Kb8wrHOy osY+iDhlgl7T8sqn4wbqbVWzAAHDCaNqcTZp/GbDTR+fBxLbxs7Ub2UE/sNFmKLsmLUbHA oFQcEexlKvDLwoKRlVA4bmSB0v7cRAyg/mu9Fg9R23PMWh4567OvFdZB6xWbY+UMFP5tLd JUQ6pQkyQLRPPFpXZ28z2R0e6JB6/O03KpdOdATX1TL9dmYjcoUMC+9Hm6WsVSqXX0hs8F DyoEv26azR9jnSEvzEwSVRSGQwwTuxFBenUO/7Yqjaxcqjh+flG/v5Qv7/oK2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674829615; a=rsa-sha256; cv=none; b=YZGUg5HbKY8c8ymIBhY2htow2IH0tVBADQ/uAMncJMMiLlTPjtr+MD6s7uTUgK3ouYD+iR pHDDQpoQCBNQ6DMpRLKbfy6zFhLKrVxvZpn2iIdbkFRb9BeyfhpFZIvaRZjBzcpU+6WV2L SuYMtCmQiGdv0KIbt3BUL6k1EnvjQ0V3a9IJzzgxnirvdDeqXUa6KpqENuJXHRmCZXO1Ln JClkYEvxnnJCPWb7nHekMbLpbfM9w2guuW5UGddqaeAvFDgEliyWfqmefKUl6E/zcG06uL SRzV6eo+8eSv+n1kEp1dPkOkSiHrt7PaWjDESaXeTXUgikBsnlelReHaLYj6rg== Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P3Kdq4Gjcz15b8; Fri, 27 Jan 2023 14:26:55 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 5E0768D4A142; Fri, 27 Jan 2023 14:26:54 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id D27FF5C3A833; Fri, 27 Jan 2023 14:26:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id PO0ibnooI9Aw; Fri, 27 Jan 2023 14:26:52 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 014065C3A830; Fri, 27 Jan 2023 14:26:51 +0000 (UTC) Date: Fri, 27 Jan 2023 14:26:51 +0000 (UTC) From: "Bjoern A. Zeeb" To: Kirk McKusick cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 906c312bbf74 - main - Document the mntopts(3) functions. In-Reply-To: <9126pq56-345-1r1n-4o93-89nq26p6p07n@mnoonqbm.arg> Message-ID: <44q75o23-n3r-551-7r58-9sp3rq4qr393@mnoonqbm.arg> References: <202301151821.30FILnsY011391@gitrepo.freebsd.org> <9126pq56-345-1r1n-4o93-89nq26p6p07n@mnoonqbm.arg> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-ThisMailContainsUnwantedMimeParts: N On Fri, 27 Jan 2023, Bjoern A. Zeeb wrote: > On Sun, 15 Jan 2023, Kirk McKusick wrote: > > Hi Kirk, > >> The branch main has been updated by mckusick: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=906c312bbf7493ccbcce883936d67e5c66a9c3c2 >> >> commit 906c312bbf7493ccbcce883936d67e5c66a9c3c2 >> Author: Kirk McKusick >> AuthorDate: 2023-01-15 18:20:48 +0000 >> Commit: Kirk McKusick >> CommitDate: 2023-01-15 18:21:31 +0000 >> >> Document the mntopts(3) functions. >> >> The mntopts(3) functions support operations associated with a mount >> point. The main purpose of this commit is to document the mntopts(3) >> functions that now appear in 18 utilities in the base system. See >> mntopts(3) for the documentation details. >> >> The getmntopts() function appeared in 4.4BSD. The build_iovec(), >> build_iovec_argf(), free_iovec(), checkpath(), and rmslashes() >> functions were added with nmount(8) in FreeBSD 5.0. The getmntpoint() >> and chkdoreload() functions are being added in this commit. >> >> These functions should be in a library but for historic reasons are >> in a file in the sources for the mount(8) program. Thus, to access >> them the following lines need to be added to the Makefile of the >> program wanting to use them: >> >> SRCS+= getmntopts.c >> MOUNT= ${SRCTOP}/sbin/mount >> CFLAGS+= -I${MOUNT} >> .PATH: ${MOUNT} >> >> Once these changes have been MFC'ed to 13 they may be made into >> a library. >> >> Reviewed by: kib, gbe >> MFC after: 2 weeks >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D37907 > > > Could this change be the cause for (I'll try to back it out and the > follow-up to see but it'll be a few hours...) This reverts commit 0bd4c448ec1dfdc2300a6cacca42e1fc7c4d8f14. This reverts commit 906c312bbf7493ccbcce883936d67e5c66a9c3c2. And NFS ROOT works again. Please don't MFC until this is fixed. PS: I am also always surprised how little netboot setup breakage shows up these days (or how long it takes to be reported). We probably need better test cases for this... > https://lists.freebsd.org/archives/freebsd-fs/2023-January/001789.html > > >> --- >> sbin/fsck/Makefile | 4 + >> sbin/fsck/fsck.c | 5 +- >> sbin/fsck/fsutil.c | 44 ------ >> sbin/fsck/fsutil.h | 1 - >> sbin/fsck_ffs/main.c | 96 +----------- >> sbin/growfs/growfs.c | 110 ++------------ >> sbin/mount/Makefile | 11 +- >> sbin/mount/getmntopts.3 | 181 ----------------------- >> sbin/mount/getmntopts.c | 95 +++++++++++- >> sbin/mount/mntopts.3 | 381 >> ++++++++++++++++++++++++++++++++++++++++++++++++ >> sbin/mount/mntopts.h | 2 + >> sbin/mount/mount.c | 18 +-- >> sbin/tunefs/tunefs.c | 33 +---- >> 13 files changed, 513 insertions(+), 468 deletions(-) > > -- Bjoern A. Zeeb r15:7