From nobody Wed Jan 25 16:37:04 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P28cz1yl9z3bs3K for ; Wed, 25 Jan 2023 16:37:07 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P28cz0Kg2z4Q78 for ; Wed, 25 Jan 2023 16:37:07 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f49.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so1663799wmb.0 for ; Wed, 25 Jan 2023 08:37:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zW6HP6ufqqSp7J39VL7ZU0dL3IZRkNCVjCLZWWcT6Lo=; b=WPd3Hr5BBIS4ul4G+ZaTnZS3uynb2NqYlLhEDyXzQRnwkGpw5oXU6vybUTHtO0N2lN kOGX2pazNALBdAab68A/pOT+jk5lpI78kWWh1uWisF2D9IgOY0w7XgNWElN69oFe/rPY UZNbip+JVu7xmu2yO0ba9+ULh51PgpxBAOae+0ABEQQsB/qH2jyqi8sdCmAvfD4YWHCa YfuHzqOSZ8p2w/C8b3/l8qc3g5SgM12XAnzH5LYgqepYzb+7A0zhZQ2rzE+sCXhysv0J 9Uc/ndE9j+Q5oyohqwiIXI3QefHaXJcYVaIZA2D1X8z9BU2z4yLug8iR1T6rfrC5hDHz E/Tw== X-Gm-Message-State: AFqh2ko6d0gNaVZCpRnLs8NZteUhzzretF2LY2Wf3KcBIL6vjLMpn8TQ 6zuB4vVp/ZPjz+05jkudA0uRlA== X-Google-Smtp-Source: AMrXdXsn4FPkZMNSvWdOuDmpXT+/Kl7HF3t/j4rbjxL83aGEjuIbmdnD1Zfl1mDAkCV9qqyEDQk7QQ== X-Received: by 2002:a05:600c:3d14:b0:3da:f793:fff6 with SMTP id bh20-20020a05600c3d1400b003daf793fff6mr32100187wmb.16.1674664625231; Wed, 25 Jan 2023 08:37:05 -0800 (PST) Received: from smtpclient.apple (global-5-143.n-2.net.cam.ac.uk. [131.111.5.143]) by smtp.gmail.com with ESMTPSA id f6-20020a05600c43c600b003db06224953sm2541533wmn.41.2023.01.25.08.37.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2023 08:37:04 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 783c318fd118 - main - zoneinfo: On amd64, include 32-bit data. From: Jessica Clarke In-Reply-To: <865ycua8jm.fsf@ltc.des.no> Date: Wed, 25 Jan 2023 16:37:04 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <8BCFDF3C-BB95-460A-AA9E-DE57BC86281C@freebsd.org> References: <202301251555.30PFtxeh015569@gitrepo.freebsd.org> <865ycua8jm.fsf@ltc.des.no> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4P28cz0Kg2z4Q78 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 25 Jan 2023, at 16:22, Dag-Erling Sm=C3=B8rgrav = wrote: >=20 > Jessica Clarke writes: >> Dag-Erling Sm=C3=B8rgrav writes: >>> zoneinfo: On amd64, include 32-bit data. >> I=E2=80=99m not sure how this makes sense. Isn=E2=80=99t the file = format entirely MI? >=20 > It's not machine independent so much as multi-target. The file > structure is basically: >=20 > 32-bit header > 32-bit data > 64-bit header > 64-bit data >=20 > Recent versions leave out the 32-bit data unless you pass -b fat on = the > command line. To a legacy binary, that looks like a valid file (the > 32-bit header is still present) with no transitions. But the 64-bit version is machine independent, it=E2=80=99s just not = compatible with old consumers. And those old consumers can be run on i386 (jail or full system), not just amd64 with lib32, and will need the 32-bit data just as much, yet won=E2=80=99t have it. Which is what my point was in = the rest of my previous email that you chopped off when replying. I think this really needs to be .if ${MACHINE_ARCH} =3D=3D "amd64" || ${MACHINE_ARCH} =3D=3D "i386" (or the same with MACHINE_CPUARCH to be more forward-thinking) Though -b fat governs things other than whether you get 32-bit data, namely working around bugs in older versions, which may well apply to non-x86 architectures. So probably we should just do the same thing on every architecture (unless you want to go and figure out when each architecture entered FreeBSD and when each bug worked around got fixed, though probably at least some of them were in the recent import) so as to not get weird edge-case failures on non-x86, as it can be a pain to deal with failures that only show up on non-x86 but are from the configuration not the architecture. Jess