git: f8ff4e8bafff - stable/13 - stand: Add comment about CFLAGS pollution

Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Warner Losh <imp_at_FreeBSD.org>
Date: Tue, 24 Jan 2023 22:10:45 UTC

The branch stable/13 has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=f8ff4e8bafff89d1386447ab97c967a2bed3a8a5

commit f8ff4e8bafff89d1386447ab97c967a2bed3a8a5
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-07-08 16:34:44 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-01-24 21:49:22 +0000

    stand: Add comment about CFLAGS pollution
    
    Add a note that veriexec / bearssl builds will pollute the CFLAGS in a
    way that's somewhat hard to fix, so I'm just noting it for now.
    
    Sponsored by:           Netflix
    
    (cherry picked from commit 37dabb06e23a2435eab0a0b37d87258d92d0fd50)
---
 stand/libsa/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/stand/libsa/Makefile b/stand/libsa/Makefile
index 682fdd9badce..25bb233ebfcd 100644
--- a/stand/libsa/Makefile
+++ b/stand/libsa/Makefile
@@ -198,6 +198,7 @@ SRCS+=  explicit_bzero.c crc32_libkern.c
 .endif
 
 .if ${MK_LOADER_VERIEXEC} == "yes" && ${MK_BEARSSL} == "yes"
+# XXX Note that these pollutes CFLAGS in a way that's not easy to fix
 .include "${SRCTOP}/lib/libbearssl/Makefile.libsa.inc"
 .include "${SRCTOP}/lib/libsecureboot/Makefile.libsa.inc"
 .endif