From nobody Sun Jan 22 16:07:34 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P0J6J4NfPz310vP; Sun, 22 Jan 2023 16:07:36 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P0J6J3sRWz4Fb3; Sun, 22 Jan 2023 16:07:36 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674403656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WMtedIiGiD4LOpEID9rIv1FLikI8a0EifwBs2OxH5n8=; b=H0FwUriuG2HOvNnNRszy2vAmmq9DGKxqoU+QrB/nYuNpT1zY7gDQQwCe/M++5zsiLm9pzg wurO5SJUzsSvb6V0CyJYDmrh2Qxm46oQQuUK3cw8el+YT3X/KCwtXRzQC/wxQO9g368NvM xixVNLuEb+cMo/NhleDMmT9JG1lNnY23+4FwnYp/h4i0r+rbR6BMIb7UE/9lAAP3TcAAV3 jk4DsztpelClJk4uJCqFvnuzoMWjTmiRMNveW2zTY9D7oOjz8Fd/ztmQ61Hhzg3UMJe5Te uXIezca2ayKo2c4bAdOmFWQKS06wjU5pxI4175zml/NZc2quTFuO6/wyw6nFcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674403656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WMtedIiGiD4LOpEID9rIv1FLikI8a0EifwBs2OxH5n8=; b=W7m6UWIr3TrUvM4D9f3czv60xaXC62iv3VqfokJTavMOflhUeKL0m8HUBfzRX3fCzGRhNl 9b4Fc4vTF9jReSE/P4M4bP/aEKsXDmCEmGDvdHcA8CLN4P3AcHw4sTjcCaC7/jtmpsmzDO oX4SwIysWiiZuayb7BUDYhui53Mhx0ptcmolNw8CMGNMS0JNljxwB1uhBEOlMtKdlaTeK/ 4dlUIUdA+9ulDTX04GqbUo0K0OSGm7hxA8pmaKZROPp4hgO2XkBQ1wIzEJpwwEjMJP/xYT wOu7RBVIpR/a3npekt+Y4x6/UlJ7JbpYcQaA9f8XILdtqsc9m1NTaOGlsBh99w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674403656; a=rsa-sha256; cv=none; b=A8Uz+4xAptt+jeI1c8GcDr6fXGXbH5Mp4ElcErZkQ10i213Wg8ks2K4tjhTxdu8RlWDvR1 Lrr/SUDPGpgBJI+BB0kFhXrsF3HCqb+3KTDtd39hZXdVGKhvPfhH7ws2jh/7yXefCQR5CI biiSkye/tTqBylMjYgk4lFgraHCjhPFj7XTsM0/XI2bVr3xiem/uOll5amqapO8Wf/zMZ0 0QXJoe616B6xOPHsIE7suiIkeU3zzbS4sDlM8XShxlqR5yGWF2KuIg+426E82/LlXSwHp/ KyviEYADeMwXzavhJk8JQcv9fdc1KKgUKfn5gc1DgxO6zHYtbsin2PC3ztIUhQ== Received: from ralga-linux (dsl-74-83-251-217.fuse.net [74.83.251.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhibbits) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P0J6J1Hm2zsxx; Sun, 22 Jan 2023 16:07:36 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Date: Sun, 22 Jan 2023 11:07:34 -0500 From: Justin Hibbits To: "Alexander V. Chernikov" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: 81a72d997e22 - stable/13 - tcp: virtualise net.inet.tcp.msl sysctl. Message-ID: <20230122110719.56ab1f60@ralga-linux> In-Reply-To: <202301132124.30DLOrE7040954@gitrepo.freebsd.org> References: <202301132124.30DLOrE7040954@gitrepo.freebsd.org> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; powerpc64le-unknown-linux-gnu) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On Fri, 13 Jan 2023 21:24:53 GMT "Alexander V. Chernikov" wrote: > The branch stable/13 has been updated by melifaro: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=81a72d997e22f37ac15a009090a5a15a6c279900 > > commit 81a72d997e22f37ac15a009090a5a15a6c279900 > Author: Alexander V. Chernikov > AuthorDate: 2021-12-04 22:02:44 +0000 > Commit: Alexander V. Chernikov > CommitDate: 2023-01-13 21:18:26 +0000 > > tcp: virtualise net.inet.tcp.msl sysctl. > > VNET teardown waits 2*MSL (60 seconds by default) before expiring > tcp PCBs. These PCBs holds references to nexthops, which, in > turn, reference ifnets. This chain results in VNET interfaces being > destroyed and moved to default VNET only after 60 seconds. > Allow tcp_msl to be set in jail by virtualising net.inet.tcp.msl > sysctl, permitting more predictable VNET tests outcomes. > > MFC after: 1 week > Reviewed by: glebius > Differential Revision: https://reviews.freebsd.org/D33270 > > (cherry picked from commit > c2c8e360d8c0b8712158d334686d88f052aef819) --- > sys/netinet/tcp_subr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c > index 62042df50d18..dfbdf99f21eb 100644 > --- a/sys/netinet/tcp_subr.c > +++ b/sys/netinet/tcp_subr.c > @@ -1453,6 +1453,8 @@ tcp_init(void) > > V_tcp_msl = TCPTV_MSL; > > + V_tcp_msl = TCPTV_MSL; > + > /* Skip initialization of globals for non-default instances. > */ if (!IS_DEFAULT_VNET(curvnet)) > return; This looks like it was already MFC'd to stable/13 back in March last year as 057793e6377. - Justin