From nobody Sat Jan 14 18:37:21 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NvRpp0V7jz2sjgb; Sat, 14 Jan 2023 18:37:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NvRpn6zxdz45yp; Sat, 14 Jan 2023 18:37:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673721442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mZ1Up4rFCLvRZONxE6BS3yhBMqpySbNHcSkyAQYrx1Y=; b=G68B3qYWShmEVVnVGIwpGuO6eQsF0Ikjg+PIlIzWhGioERhxClOVg9zfgpnk+C2On7X1Rb uNY9y2o/MC5X6mN0w/9Ye1iZgDv00/pS1I5B24WuC2R6EHmbP3L87tWITo7BnAJr1Y+6is ygMvxQ3KZhzufUfWRub6dy8A4ilyJ/FfpTv9D4gyRfX/yza32Ln/KH/5WRS0Rsx67SVFih 1GEsy301tFmsezkb/36idnjAAfWEEspSyq9s8/Lkc652iOMaa9GYtCYy8WcQ/zM5AKnudO khSg/cEw/W+pS6FwlyCQlM9mLotbmj5OFebOzTebDnhc9QFpYczzoeHDKubOpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673721442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mZ1Up4rFCLvRZONxE6BS3yhBMqpySbNHcSkyAQYrx1Y=; b=rj+BGGC61Lax4ySfcQgAgbBwBl6kiWOYdC1zdg0k6kl6o9qhU9VpLIvLl00hJ7buYL30zB +NqphygBNr78AO/+SsHw8b3GR/xuUW9zOJRIid0g/RwP3DuwGUM4YaqkyhmVDDvEh9X2AQ c1LoX3opZhVGdp9qApY2V7wdNdoNVP0z+We7dO8u3EM6c4gIY+x+kXw43TPaXO1M5W9eUG j1A+ypJOj9XWNLOkJhYq5zx/sRiNl4eTRp7swoZWZGCyUWrJl+8PvHGLgI9cZgIRFQj9kK J0sJJT/7jVF/JSY6mhZMyvr9AvkjMov+hUKEClXcQOAI2lcsAklU5JAO0+0Z8A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673721442; a=rsa-sha256; cv=none; b=TO6oV5RbnTaLpn0+GvuBnr0KBmh9P/jynZboMdcfB68ybaB08by72uMVAc0di69sdlOdqG D/4Q8Vgi5fxrqUHcw4JLLjHIiC5QxDk7C85nS+Gl9k3krJIMhiqwVtVDdH3W1lb3qX/yAl IBGKfUFCC7ryAtv472KR39mdtCBiBYX08eiGKr8ok0tPVLf9PJr3iF/dN1jSjMTLfXvj/Y Fy3fCntif7Y5qt12UYw5kYDuU3vwRGWiXyAvlVhYATWpwqxMqalqrrxfhN5cKE+6ndjsxJ jLbBzFX7usjySRz3DFI1mYUCZyiYGgUNcViFORvyEprkhcsXT1UTRzJrdOfZLA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NvRpn61rmzy2k; Sat, 14 Jan 2023 18:37:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30EIbLu5062834; Sat, 14 Jan 2023 18:37:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30EIbL0C062833; Sat, 14 Jan 2023 18:37:21 GMT (envelope-from git) Date: Sat, 14 Jan 2023 18:37:21 GMT Message-Id: <202301141837.30EIbL0C062833@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 1d9f3a37eb20 - main - Stop cleaning MNT_LOCAL on unmount List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1d9f3a37eb20305bfdd67788cfac5c51938226a4 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=1d9f3a37eb20305bfdd67788cfac5c51938226a4 commit 1d9f3a37eb20305bfdd67788cfac5c51938226a4 Author: Konstantin Belousov AuthorDate: 2023-01-06 16:38:44 +0000 Commit: Konstantin Belousov CommitDate: 2023-01-14 18:28:11 +0000 Stop cleaning MNT_LOCAL on unmount There is no point in clearing just this flag. Flags are reset on the struct mount re-allocation for reuse anyway. Reviewed by: mckusick Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D37966 --- sys/fs/cd9660/cd9660_vfsops.c | 3 --- sys/fs/ext2fs/ext2_vfsops.c | 3 --- sys/fs/msdosfs/msdosfs_vfsops.c | 3 --- sys/fs/smbfs/smbfs_vfsops.c | 3 --- sys/fs/tmpfs/tmpfs_vfsops.c | 4 ---- sys/fs/udf/udf_vfsops.c | 4 ---- sys/ufs/ffs/ffs_vfsops.c | 3 --- 7 files changed, 23 deletions(-) diff --git a/sys/fs/cd9660/cd9660_vfsops.c b/sys/fs/cd9660/cd9660_vfsops.c index c8ac6bb1be2e..6d5551c69312 100644 --- a/sys/fs/cd9660/cd9660_vfsops.c +++ b/sys/fs/cd9660/cd9660_vfsops.c @@ -523,9 +523,6 @@ cd9660_unmount(struct mount *mp, int mntflags) dev_rel(isomp->im_dev); free(isomp, M_ISOFSMNT); mp->mnt_data = NULL; - MNT_ILOCK(mp); - mp->mnt_flag &= ~MNT_LOCAL; - MNT_IUNLOCK(mp); return (error); } diff --git a/sys/fs/ext2fs/ext2_vfsops.c b/sys/fs/ext2fs/ext2_vfsops.c index 2aff8c701af0..9f76dc63300d 100644 --- a/sys/fs/ext2fs/ext2_vfsops.c +++ b/sys/fs/ext2fs/ext2_vfsops.c @@ -1047,9 +1047,6 @@ ext2_unmount(struct mount *mp, int mntflags) free(fs, M_EXT2MNT); free(ump, M_EXT2MNT); mp->mnt_data = NULL; - MNT_ILOCK(mp); - mp->mnt_flag &= ~MNT_LOCAL; - MNT_IUNLOCK(mp); return (error); } diff --git a/sys/fs/msdosfs/msdosfs_vfsops.c b/sys/fs/msdosfs/msdosfs_vfsops.c index b6f8c29d9162..37e5c4d4500a 100644 --- a/sys/fs/msdosfs/msdosfs_vfsops.c +++ b/sys/fs/msdosfs/msdosfs_vfsops.c @@ -870,9 +870,6 @@ msdosfs_unmount(struct mount *mp, int mntflags) lockdestroy(&pmp->pm_checkpath_lock); free(pmp, M_MSDOSFSMNT); mp->mnt_data = NULL; - MNT_ILOCK(mp); - mp->mnt_flag &= ~MNT_LOCAL; - MNT_IUNLOCK(mp); return (error); } diff --git a/sys/fs/smbfs/smbfs_vfsops.c b/sys/fs/smbfs/smbfs_vfsops.c index a1ae565c6341..9d6fa9274e36 100644 --- a/sys/fs/smbfs/smbfs_vfsops.c +++ b/sys/fs/smbfs/smbfs_vfsops.c @@ -299,9 +299,6 @@ smbfs_unmount(struct mount *mp, int mntflags) mp->mnt_data = NULL; SMB_UNLOCK(); free(smp, M_SMBFSDATA); - MNT_ILOCK(mp); - mp->mnt_flag &= ~MNT_LOCAL; - MNT_IUNLOCK(mp); out: smbfs_free_scred(scred); return error; diff --git a/sys/fs/tmpfs/tmpfs_vfsops.c b/sys/fs/tmpfs/tmpfs_vfsops.c index de207242b574..a8382872aa2f 100644 --- a/sys/fs/tmpfs/tmpfs_vfsops.c +++ b/sys/fs/tmpfs/tmpfs_vfsops.c @@ -536,10 +536,6 @@ tmpfs_unmount(struct mount *mp, int mntflags) tmpfs_free_tmp(tmp); vfs_write_resume(mp, VR_START_WRITE); - MNT_ILOCK(mp); - mp->mnt_flag &= ~MNT_LOCAL; - MNT_IUNLOCK(mp); - return (0); } diff --git a/sys/fs/udf/udf_vfsops.c b/sys/fs/udf/udf_vfsops.c index de943229e3a8..057bb3f6587b 100644 --- a/sys/fs/udf/udf_vfsops.c +++ b/sys/fs/udf/udf_vfsops.c @@ -542,10 +542,6 @@ udf_unmount(struct mount *mp, int mntflags) free(udfmp, M_UDFMOUNT); mp->mnt_data = NULL; - MNT_ILOCK(mp); - mp->mnt_flag &= ~MNT_LOCAL; - MNT_IUNLOCK(mp); - return (0); } diff --git a/sys/ufs/ffs/ffs_vfsops.c b/sys/ufs/ffs/ffs_vfsops.c index ad095874c06d..560708883cca 100644 --- a/sys/ufs/ffs/ffs_vfsops.c +++ b/sys/ufs/ffs/ffs_vfsops.c @@ -1448,9 +1448,6 @@ ffs_unmount(struct mount *mp, int mntflags) free(fs, M_UFSMNT); free(ump, M_UFSMNT); mp->mnt_data = NULL; - MNT_ILOCK(mp); - mp->mnt_flag &= ~MNT_LOCAL; - MNT_IUNLOCK(mp); if (td->td_su == mp) { td->td_su = NULL; vfs_rel(mp);