From nobody Fri Jan 13 02:22:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NtQDg4kxWz2pBLF; Fri, 13 Jan 2023 02:22:43 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NtQDg4Dnwz3qkj; Fri, 13 Jan 2023 02:22:43 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673576563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=itxm9M+ac5RCtV54x52f2tfmnDm2GJ3yB3jznI0Atlo=; b=xkJZoXznen4mBdxUPvNoxbEg5Q1Rz3FpcBffP5b6lHwkNJMykfMncoN1P+Jcim6GrZE1JU 7SYDrsJgC1/h9k5cPmej80BUyEu/kPQISbH6MlSFgAS4ugGv+0HK9Kovt8pcx/oyx23WGz vUt1QGI7+3rD4fTzML4s0YLZVAl6WH9KFWe8PxsErza90ygzW004gqZIaE1BT3n3YZWgH9 Ad7q8oz5Fs9lNilEVotAbYhuCXN79ac6cDMIqgqakWgHa5jBppPXMYUaUWq3BSEwwK8RGX lXJFOBZjL7PDhMtsxd3BAEsnYw86CubR8aONuZYes1Muha/p+Jjf+US2UxDqdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673576563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=itxm9M+ac5RCtV54x52f2tfmnDm2GJ3yB3jznI0Atlo=; b=xkctbrOjnNOI7aeEgT5YDZ+qos7BresJRibULeAvve3ZhDyfEbplcyuscMQw5zUUGuG9u9 hHeYPx9BIIQS25gbFIN5AjoR/vc/oi+cRO20O24Y6XnxVmgQlH09tkFG7KE1hzVIalB5gu hHuTrllQlaVuFw9DSxsab/2kYXSTsTquGFmtFsn3BBMr9Y0JTEYDEykmue30QOVrpOfh1W nWZerbOLNoapJUx+uCG46OqVIAX8qjjzxctEbuvs40n50a8KBAEjF/CVNA8jkf0Ng3qOBi NvUM/OJ/nfP5Yn2d47w4u77ELg6flbMWQtUOWXcw6gL7Ibz0LcloVaiYd8KQXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673576563; a=rsa-sha256; cv=none; b=rPRucbDgZNOl/fz6FQT9U1hDdpjr1ULHuif2pUjJy7SYZ4CI2s43JRRcsKFEPRGdjndFrU H1KAah4J4zwhjFmUp8qEx3n2ToNfy4UipU7MVmIvuRjajBGgbhq884W40G/gXA1WA5BkIi O3HzvYU2zKP9fA9LDZUfVPs1eweo/188AFYCPkDtWwDl92pmoYFBL4CdOus9cRRLwUDgm9 n/1+gdgYmFn0RivXfbuEa8yJmb+feeTdsF9VJ1BVpKiQFuf+oGaxBkhvJ3WfHu/Vzht0p8 H5S71+Ue7e0YN3HPaHzMWVeJdqmYyuztXd1TJWP0u74bcuqh7RnWQ24guzZlrw== Received: from ralga-linux (dsl-74-83-251-217.fuse.net [74.83.251.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhibbits) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NtQDg1cL0z175t; Fri, 13 Jan 2023 02:22:43 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Date: Thu, 12 Jan 2023 21:22:42 -0500 From: Justin Hibbits To: Gleb Smirnoff Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fe33e0ab83d1 - main - ifnet/API: Move the IfAPI from if_var.h to if.h Message-ID: <20230112212242.4e878479@ralga-linux> In-Reply-To: References: <202301121620.30CGKtpM047283@gitrepo.freebsd.org> <20230112190114.238a3662@ralga-linux> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; powerpc64le-unknown-linux-gnu) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On Thu, 12 Jan 2023 16:55:43 -0800 Gleb Smirnoff wrote: > Justin, > > On Thu, Jan 12, 2023 at 07:01:14PM -0500, Justin Hibbits wrote: > J> > 1) Leave it in if_var.h and start a new header where we will move > J> > stuff that should stay private from drivers. Drivers keep using > J> > if_var.h. 2) Create a new header with DrvAPI. Drivers to stop > J> > useing if_var.h and switch to new header file. > J> > > J> > I personally prefer 1), as it follows what we have started to do > J> > long time ago, see c29e1ad9304, c3322cb91ca, 76039bc84fa, > J> > eedc7fd9e87. > J> > > J> > [1] > J> > https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/net_if.h.html > J> > > J> > J> I'll revert this, but I think we should discuss further how to > J> approach this, since on our call last week I got the impression > J> that the DrvAPI does belong in if.h, with if_var.h being > J> exclusively used by netstack. > > My fail to properly articulate that. :( Sorry > > Do you agree with this plan: > > 1) DrvAPI stays in if_var.h. Today all drivers already include it. > 2) struct ifnet (and possibly later more stuff) goes to if_private.h. > Alternative names: if_priv.h, if_kern.h, anything else? This file > is not supposed to be used by drivers. > 3) if_var.h _temporarily_ includes if_private.h. > Removing this include and trying to compile we can very quickly > check how close are we to final removal. > 4) Eventually if_var.h stops including if_private.h. > This seems fair. There are already a bunch of foo_private.h files in sys/, so that nomenclature works for me. I'll get working on it in the morning. - Justin