From nobody Fri Jan 13 00:57:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NtNLb41M8z2p11N; Fri, 13 Jan 2023 00:57:43 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from glebi.us (glebi.us [162.251.186.162]) by mx1.freebsd.org (Postfix) with ESMTP id 4NtNLZ69mbz3jfR; Fri, 13 Jan 2023 00:57:42 +0000 (UTC) (envelope-from glebius@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org; dmarc=none Received: by glebi.us (Postfix, from userid 1000) id 2BFB3328A; Thu, 12 Jan 2023 16:57:42 -0800 (PST) Date: Thu, 12 Jan 2023 16:57:42 -0800 From: Gleb Smirnoff To: Justin Hibbits Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fe33e0ab83d1 - main - ifnet/API: Move the IfAPI from if_var.h to if.h Message-ID: References: <202301121620.30CGKtpM047283@gitrepo.freebsd.org> <20230112190114.238a3662@ralga-linux> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [0.52 / 15.00]; VIOLATED_DIRECT_SPF(3.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.994]; NEURAL_HAM_MEDIUM(-0.99)[-0.988]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; ARC_NA(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[glebius]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4NtNLZ69mbz3jfR X-Spamd-Bar: / X-ThisMailContainsUnwantedMimeParts: N On Thu, Jan 12, 2023 at 04:55:43PM -0800, Gleb Smirnoff wrote: T> 1) DrvAPI stays in if_var.h. Today all drivers already include it. T> 2) struct ifnet (and possibly later more stuff) goes to if_private.h. T> Alternative names: if_priv.h, if_kern.h, anything else? This file T> is not supposed to be used by drivers. T> 3) if_var.h _temporarily_ includes if_private.h. T> Removing this include and trying to compile we can very quickly T> check how close are we to final removal. T> 4) Eventually if_var.h stops including if_private.h. Note: the drivers that have already been converted, won't need a single change with this plan. -- Gleb Smirnoff