From nobody Thu Jan 12 03:08:39 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NsqJS255Fz2qlvc; Thu, 12 Jan 2023 03:08:56 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NsqJR4Xm8z3DhK; Thu, 12 Jan 2023 03:08:55 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=T2nUw9fU; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2607:f8b0:4864:20::42e as permitted sender) smtp.mailfrom=rick.macklem@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x42e.google.com with SMTP id a184so12858771pfa.9; Wed, 11 Jan 2023 19:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3H/BuWdxH2VCJqao78GPTIDF6R7+Y/H1Q/Va5I+2YM8=; b=T2nUw9fUzUKMpSu3jxWAX9nUdyXc43Xygh9dOsWKFTmxGiFPQPWxT5KxMOcXOAYu9b K2uoRCqXEqPa+IgnAKkANaEssFBXtO5OBwm0Gn+gzMPOyv2VaYOQEvwORbj8ea8YeHhZ maOwWE7RovSwLhAImWaeJ64vRCEb6B50Z120xItQRakrtUVrlrEUfg73Vmv2WBcsVPnr lcVZYaM/7ScSowvtrEYnPzkYA69/e6/Ny9P+stWbHj1rH/l7tCiVOz1/KR3ACHLUIGma RkCEYTqH/tdVm5R13HvEaBqMgQWIO0pyE2UadFqVlMdRmfBQtjEavXswR8kpGAJuzfHu 1DgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3H/BuWdxH2VCJqao78GPTIDF6R7+Y/H1Q/Va5I+2YM8=; b=pTuQVMoLfebElt3QqRtR8T7rZLI9twffRwBktmBSCvAyXlHfchr2ozhKUq3mFNtVwK wi50i7iSeLjYurttAMpRaRjzDabWTt+/8GQu+9FZcYJIKPkqwciOtwbU6e4SBo7EB7Xo LCOrBoEaI8N4d1zZfJw6PVbRnMgxj2yTCtnl0kWlvoWuy7wq1GlNmHHZ6b0R0xfH4pom NLWSJuWyhve2BVW7mz4eRvVSpuGlMlUVMVr4EOzzhZIUBvU0bZZ74IW+G8+zBJGzRhA6 zAur4ePnZZGbGwBlvUcsxU8e7o64zJPWmc8z+lrDMiOihCvq2xIGwFwIVKZDt6Pqnzis dAjw== X-Gm-Message-State: AFqh2koC7yZTHtfXFfwH5SgiGPdY2wCRre0vEITmpKybz9RlKs+BELQL 3G/6Z3rA9YBE44yG1n4VhD5h0tzsKbdivkH420H1DLc= X-Google-Smtp-Source: AMrXdXszDkBBfvFdBLLu3WWXSR5ImG7HVRCXDcd1DcBVEpNuxfYtZPxFJySzL5f3wFOj6CZenaBNvfrvlfMVEcK47E4= X-Received: by 2002:a62:e912:0:b0:579:6402:5b39 with SMTP id j18-20020a62e912000000b0057964025b39mr5023093pfh.11.1673492934532; Wed, 11 Jan 2023 19:08:54 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202212231636.2BNGaluc012056@gitrepo.freebsd.org> <876513140.46.1671814393751@mailrelay> <20230109143951.txy43nin5yv3qkym@ubertino.local> In-Reply-To: <20230109143951.txy43nin5yv3qkym@ubertino.local> From: Rick Macklem Date: Wed, 11 Jan 2023 19:08:39 -0800 Message-ID: Subject: Re: git: 62a149bf6219 - main - Add new rc: machine_id to generate /etc/machine-id To: Matteo Riondato Cc: "Tobias C. Berner" , Ronald Klop , dev-commits-src-all@freebsd.org, src-committers@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-3.95 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.945]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::42e:from]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4NsqJR4Xm8z3DhK X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N On Mon, Jan 9, 2023 at 6:40 AM Matteo Riondato wrote: > > On 2022-12-24 at 03:39 EST, Tobias C. Berner wrote: > > >Moin moin > > > >I think it tries to solve the same problem of giving the machine a unique id. > > > >From the linux man page [1] > > > > The machine ID does not change based on local or network > > configuration or when hardware is replaced. Due to this and its > > greater length, it is a more useful replacement for the > > gethostid(3) call that POSIX specifies. > > > > Does this make or should it make hostid obsolete? I hope not, since the NFSv4 client uses /etc/hostid. > If yes, then changes are needed to deorbit hostid. If not, why not? If this is somehow a better algorithm than the one used by uuidgen(1) then I would prefer seeing that utility improved instead of a new one being added. If software needs to acquire the host uuid, the code can simply get the sysctl kern.hostuuid. Unless there is a really good reason to have this one in the system as well as uuidgen(1), I'd suggest you revert this commit. rick > > Thanks, > Matteo > > CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp@uoguelph.ca >