From nobody Thu Jan 05 03:50:46 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NnXZ23j48z2p7Hl; Thu, 5 Jan 2023 03:50:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NnXZ20rrgz49gV; Thu, 5 Jan 2023 03:50:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id DDE0plT7wl2xSDHHEpkmkY; Thu, 05 Jan 2023 03:50:48 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id DHHDpOyFdyAOeDHHDp33ua; Thu, 05 Jan 2023 03:50:48 +0000 X-Authority-Analysis: v=2.4 cv=e5oV9Il/ c=1 sm=1 tr=0 ts=63b64918 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=RvmDmJFTN0MA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=Dvp2EQRAwfE2HdkvH_MA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id D3E821AF5; Wed, 4 Jan 2023 19:50:46 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id A01DE62E; Wed, 4 Jan 2023 19:50:46 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: John Baldwin cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: b069d3e01931 - main - rtld: Revert "When loading dso without PT_GNU_STACK phdr, only call" In-reply-to: <202301042255.304MtY3G002415@gitrepo.freebsd.org> References: <202301042255.304MtY3G002415@gitrepo.freebsd.org> Comments: In-reply-to John Baldwin message dated "Wed, 04 Jan 2023 22:55:34 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 04 Jan 2023 19:50:46 -0800 Message-Id: <20230105035046.A01DE62E@slippy.cwsent.com> X-CMAE-Envelope: MS4xfD8VoS8fiGUXB6EAJr6xB5UY52ayO6ucJgHLnKX919yBgJa0tLh9+BAI2MO4vQzL6OX+nqeWX2uaaZMmDPC4eR1BAtUsuaHpEB+IFYf+4NfrcPTcxD5e OSUQYSSwvZvTkuQsgfDi+WaS9ogUTLVww2wyz9fWTA1rNeQhMx3SCMllyRK5/IBOEbACmxholNGoE7DRxrDD49LFFeqOBtg4ZQ9z8AZDShRsOGgfxEVkTyLW xw1jlZfVWVNt4kixt/740wGCovIMB5Jherd0b/KX+3PB6AzuYdPHwFvhnQMmZqxSeXx+t9j3O+oJWH4R74U5iK8RLsQcx8AOGLnuNNav1sA= X-Rspamd-Queue-Id: 4NnXZ20rrgz49gV X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N In message <202301042255.304MtY3G002415@gitrepo.freebsd.org>, John Baldwin writ es: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=b069d3e0193121ff6de348f68c7ce93e > e61e5e2f > > commit b069d3e0193121ff6de348f68c7ce93ee61e5e2f > Author: John Baldwin > AuthorDate: 2023-01-04 22:55:00 +0000 > Commit: John Baldwin > CommitDate: 2023-01-04 22:55:00 +0000 > > rtld: Revert "When loading dso without PT_GNU_STACK phdr, only call" > > After the removal of ia64 and sparc64, all current architectures > support executable stacks at an architectural level. > > This reverts commit 1290d38ac50b3afa7e5781d9d97346a1042c736c. I tried git log as follows in two independent repos, my "prod" repo and the working repo I commit from: slippy$ git log 1290d38ac50b3afa7e5781d9d97346a1042c736c fatal: bad object 1290d38ac50b3afa7e5781d9d97346a1042c736c slippy$ Could there be some corruption somewhere? Do other people have the same result as I do when they run git log against that hash? Or are my repos corrupted? When I run git log and search for the string "When loading dso without PT_GNU_STACK phdr, only call", I find the following, suggesting that the svn2git process may have resulted in different hashes in different repos used by different people. commit cb38d4941c45e3c72c4b5b3fad87d297d950cf53 Author: Konstantin Belousov AuthorDate: Tue Jan 25 21:12:31 2011 +0000 Commit: Konstantin Belousov CommitDate: Tue Jan 25 21:12:31 2011 +0000 When loading dso without PT_GNU_STACK phdr, only call __pthread_map_stacks_exec() on architectures that allow executable stacks. Reported and tested by: marcel (ia64) Notes: svn path=/head/; revision=217851 BTW, our GH read-only mirror has the same hash as above suggesting that jhb's repo may not be in sync with others with regard to svn2git generated commits? Or, does this point to a deeper problem with inconsistent repos or some other svn2git inconsistency somewhere? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0