From nobody Mon Feb 20 23:34:06 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PLJfF57H6z3sd55; Mon, 20 Feb 2023 23:34:13 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PLJfF4cQTz40DJ; Mon, 20 Feb 2023 23:34:13 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676936053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dcTBmUDM8cFpauTNCxHMHUZMziip0Rb360r0MLzdHvE=; b=AtS5XKG37H1oe/6pcUNyZzUGuK/5OArM8xGTfMEPKkLjTxdvUwoFUHuNHqwc3fNNrs3Z6g M92JtlYCZj+Fb9cmDi4uwEe9PLSltH0db6g90wTI8pnckkwEPG7HOmLcJe/C0CN/uIWVW5 rlEhu0YgvkkrWjX41lZdRTzvCW4IM1hCAkq4bdiUIgpvgaG6jX26C+RzgYTD7+2Ts1fHQt czMsq78k7uNGL2GupeQBCKrzs+LyGbmrMWIuxn4vyDa7xN+bYks+bJe0fUcq+gs81WXw0y NCC+IkRKJmsVRu1QEwlPTNNXQkD2HE2QS9Onl+fvQh2iPSeHu3Q8UEfKojjyYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676936053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dcTBmUDM8cFpauTNCxHMHUZMziip0Rb360r0MLzdHvE=; b=L05NlnCyIgsEa2FxKJt6NUQxLhOOFQ65FwQ+IdbSSopeXgJLFp3StGCx/M5Jy17w0OEVQl L/VZfC4GAu0d65UTKKypvoMsQTAXyys9rG1S1fgFAdVarDaMUx8bAVBylLREGFRjs29QRJ EgQtAb+CnXbnJv7PxNw58i8J9gAtzT4y1toPr9xT3Y7xMYNoJ4xGijWOvySVhqVK4VEDks LUMr0JrQsueWMozTPvOS9MMD2GMywwCsTOoRlLQHqqV/10rSAizqesjvhJ6SjozyLXrraX IddAhxwaeq4h0aHFoHUMc7kMV5x2FpQzXM2mU9NM4jsbgxVcpgL34DZjhx3MPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676936053; a=rsa-sha256; cv=none; b=OCNY7YItOp0svBVVymcN2TQ8NUn9EmzLVDaFq1L457OBdBx54rDYl+d+7TWksZllOzFm6e h5yhnGTiG6gkvwgYw3uWrxpriL1ZlFjo0NGasnC1Lv6ZMIVmgLr8T5Oo6atlWP6RfS9b0Y VXALC9viBV1VjxF9szFSXk5XmJj8ja8yEAvk9zxnv7pdKMjtcluzES1CZlCf990ZHCMvLw A3UUXdLbWMjQHur1eL6t8euUBzlxMLjNiOBA9yOn1rYLdOMkggAczhxK0fnxFWo6GPRdXu UPJ/liXEC81ElrLx3y00sCGkjdFW5jB1l9YL1ztKyXnODXO5EnIVlWfXFXbqmw== Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PLJfF3XkJzHnD; Mon, 20 Feb 2023 23:34:13 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f176.google.com with SMTP id w23so3157070qtn.6; Mon, 20 Feb 2023 15:34:13 -0800 (PST) X-Gm-Message-State: AO0yUKX7jRupxmhm4atmvCC6j7HrisYPypv9X9Z4TDy/S0kA0+9kUofX Z36DWcCYQeNOTxPyioYchWlP1p3PDNTejMX+SYQ= X-Google-Smtp-Source: AK7set9vnDBSWoemkVd6TdqpTGmCCqmq8Or6MbVXp7m0TTkxe0VnFhAQKM6TCOXNVv+APCCZVovOKFdStgAFjtzEr3I= X-Received: by 2002:ac8:431e:0:b0:3b7:fda5:25d0 with SMTP id z30-20020ac8431e000000b003b7fda525d0mr351398qtm.1.1676936053088; Mon, 20 Feb 2023 15:34:13 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202302201855.31KItK45079891@gitrepo.freebsd.org> <870983EF-591C-4685-A133-1E0E37CF0B98@freebsd.org> In-Reply-To: From: Kyle Evans Date: Mon, 20 Feb 2023 17:34:06 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cd73914b01a1 - main - kern: physmem: don't truncate addresses in DEBUG output To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-ThisMailContainsUnwantedMimeParts: N On Mon, Feb 20, 2023 at 4:00 PM Kyle Evans wrote: > > On Mon, Feb 20, 2023 at 3:59 PM Kyle Evans wrote: > > > > On Mon, Feb 20, 2023 at 1:41 PM Jessica Clarke wrote: > > > > > > On 20 Feb 2023, at 18:55, Kyle Evans wrote: > > > > > > > > The branch main has been updated by kevans: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=cd73914b01a1f2300e587f802383cc563f2e7103 > > > > > > > > commit cd73914b01a1f2300e587f802383cc563f2e7103 > > > > Author: Kyle Evans > > > > AuthorDate: 2023-02-20 18:54:00 +0000 > > > > Commit: Kyle Evans > > > > CommitDate: 2023-02-20 18:55:04 +0000 > > > > > > > > kern: physmem: don't truncate addresses in DEBUG output > > > > > > > > Make it consistent with the above region printing, otherwise it appears > > > > to be somewhat confusing. > > > > --- > > > > sys/kern/subr_physmem.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/sys/kern/subr_physmem.c b/sys/kern/subr_physmem.c > > > > index bb6af5a580aa..d371e1e166c5 100644 > > > > --- a/sys/kern/subr_physmem.c > > > > +++ b/sys/kern/subr_physmem.c > > > > @@ -149,10 +149,10 @@ physmem_dump_tables(int (*prfunc)(const char *, ...)) > > > > #ifdef DEBUG > > > > prfunc("Avail lists:\n"); > > > > for (i = 0; phys_avail[i] != 0; ++i) { > > > > - prfunc(" phys_avail[%d] 0x%08x\n", i, phys_avail[i]); > > > > + prfunc(" phys_avail[%d] 0x%08jx\n", i, phys_avail[i]); > > > > > > You need to actually cast them though for 32-bit. > > > > > > > Huh, interesting; wasn't there a compiler warning for this? armv7 and > > riscv both seemed to have built fine (+ DEBUG), am I misremembering > > that and it's just a potential source of garbage at runtime? > > > > Oh, well, riscv isn't 32-bit anyways. Still stands for armv7, though. I delayed to avoid continuing to spam the list, but this is fixed in 7b5cb32fca26 (and a __printflike added to detect it, which I had realized was the source of no-warning pretty quickly after wondering out loud). Thanks for the report!