From nobody Mon Feb 20 22:00:15 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PLGYy2ttYz3sGDg; Mon, 20 Feb 2023 22:00:22 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PLGYy2JR9z3qNg; Mon, 20 Feb 2023 22:00:22 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676930422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UQLqwpQIJUARh4XtOuQEquhFym9ZDqVszmJQUbCeDIY=; b=tY4QCx1IfPp7pSLz7IUV3kM17WWUFVJOasYFwkRTQOZEnhXmVCCxWLDUO2H1c1//Eq5zRi aNJDf6rkDPK+G+USQVGH71X+VJ56Ll1nctASVdSME5XFioo28MPcCWEdgG19THi2ng37DO ttA0M2qW4cU1F4UvgRjnMMs+hmsKJAhfc9gzA4v26/RtIx2V1hl3n8sYltV+eyKlH+sElr ibjxNqwM5SN3aHEJdLWpCEq5ORzqGcLcY96NZBVHfL/v62PMlTx5+KEGL1KHzATKQX/Z1j mbigqAhBKvXMvy56XlzBHXxJUVrpKpNLOvYj99U4AG3A1gbNoFM0Lj+Sbt6vCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676930422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UQLqwpQIJUARh4XtOuQEquhFym9ZDqVszmJQUbCeDIY=; b=uDTJO81t5bINUvi7vlM/1wD7TygmGY+WFHWY3vEZiOmB0k6VOfvcK9zSn51z80fbSRKKdE oPUoLyY8ZfkrHUaq4ACZQnw/jxGjN0i1rNBmNpXzCdxisZmIg4d3oUTmxsAuFioTxZftBT Sq/hb9CEqMN5JsRd+9P7W3CPwbMeA0aAkhvyJlY3z6Q+Go3EtR2/NipjCTWjtQPTbUvLCV 5q2+cAlDv2Oaf/vyppXQUPQlWVzsCmTBjSnVVhOjFVQ15AyUtFLa1xVohddB/PFw1tEPtN UB8FUGYrA4wAM0vFXREkPC+OW9O4E2yIo1/IsrmIEW7o2Zh2dO5u6lXKyF7RIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676930422; a=rsa-sha256; cv=none; b=lyR03eU5+qSteFwBVQez4lRSVNAsYIRTscpm3PiO6k5v3sDMtlBcoo9Can0Oua/ylwKN1x KERdc/lF3xfo5L/eKSBA+6wF4DC/KDlwvvv/BrJxdV73Soc4LVyHHFElkkZib+M5d6/Y+k WWJ/KCBgw7pB9AbHnk6NWZ4iUVcBMJdaByrXZnn7P6IQyz0gAeGQRC7a9zVNZSMGhovQU2 h8lbPzaDmc6+yk/veQpSGP54N5JOH7NyjHEe5ian7TZqr27OkIiEu87CCxiOIWnBMNi/v9 mC/qmzHMuBWJXnkU5pnrpa5gm1BT95+h2AbSmmY6haCudKEnIDV9mg2MQoMcEg== Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PLGYy1Kx0zG8G; Mon, 20 Feb 2023 22:00:22 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f44.google.com with SMTP id nf5so2713655qvb.5; Mon, 20 Feb 2023 14:00:22 -0800 (PST) X-Gm-Message-State: AO0yUKXJIZT6je//3RgAft/Z3Pye0WqQtj1bAar0K++ceGfU91SZwGFZ ryV+XTY+qdtNgbuqiugmugBA3Aa/5rN6g955gLs= X-Google-Smtp-Source: AK7set9MREMYxwXjxfm36TQ/6mk6C4tT54v5psU8OEHWjYsPS1rPwyGuS+AF4xeWekDfl1RhCSHOWAdyBPP4EQVvNgE= X-Received: by 2002:a0c:cd0c:0:b0:537:2334:7fb3 with SMTP id b12-20020a0ccd0c000000b0053723347fb3mr604758qvm.59.1676930421600; Mon, 20 Feb 2023 14:00:21 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202302201855.31KItK45079891@gitrepo.freebsd.org> <870983EF-591C-4685-A133-1E0E37CF0B98@freebsd.org> In-Reply-To: From: Kyle Evans Date: Mon, 20 Feb 2023 16:00:15 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cd73914b01a1 - main - kern: physmem: don't truncate addresses in DEBUG output To: Kyle Evans Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-ThisMailContainsUnwantedMimeParts: N On Mon, Feb 20, 2023 at 3:59 PM Kyle Evans wrote: > > On Mon, Feb 20, 2023 at 1:41 PM Jessica Clarke wrote: > > > > On 20 Feb 2023, at 18:55, Kyle Evans wrote: > > > > > > The branch main has been updated by kevans: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=cd73914b01a1f2300e587f802383cc563f2e7103 > > > > > > commit cd73914b01a1f2300e587f802383cc563f2e7103 > > > Author: Kyle Evans > > > AuthorDate: 2023-02-20 18:54:00 +0000 > > > Commit: Kyle Evans > > > CommitDate: 2023-02-20 18:55:04 +0000 > > > > > > kern: physmem: don't truncate addresses in DEBUG output > > > > > > Make it consistent with the above region printing, otherwise it appears > > > to be somewhat confusing. > > > --- > > > sys/kern/subr_physmem.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/sys/kern/subr_physmem.c b/sys/kern/subr_physmem.c > > > index bb6af5a580aa..d371e1e166c5 100644 > > > --- a/sys/kern/subr_physmem.c > > > +++ b/sys/kern/subr_physmem.c > > > @@ -149,10 +149,10 @@ physmem_dump_tables(int (*prfunc)(const char *, ...)) > > > #ifdef DEBUG > > > prfunc("Avail lists:\n"); > > > for (i = 0; phys_avail[i] != 0; ++i) { > > > - prfunc(" phys_avail[%d] 0x%08x\n", i, phys_avail[i]); > > > + prfunc(" phys_avail[%d] 0x%08jx\n", i, phys_avail[i]); > > > > You need to actually cast them though for 32-bit. > > > > Huh, interesting; wasn't there a compiler warning for this? armv7 and > riscv both seemed to have built fine (+ DEBUG), am I misremembering > that and it's just a potential source of garbage at runtime? > Oh, well, riscv isn't 32-bit anyways. Still stands for armv7, though.