git: f123c6c425d4 - main - libc: popen: slightly simplify cloexec logic

From: Kyle Evans <kevans_at_FreeBSD.org>
Date: Mon, 13 Feb 2023 06:34:03 UTC
The branch main has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=f123c6c425d4161b06f237996662496abbd78b94

commit f123c6c425d4161b06f237996662496abbd78b94
Author:     Kyle Evans <kevans@FreeBSD.org>
AuthorDate: 2023-02-13 06:33:52 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2023-02-13 06:33:57 +0000

    libc: popen: slightly simplify cloexec logic
    
    No need to check the mode again here; we know that `iop` wraps the
    correct fd.
    
    Reviewed by:    bapt
    Differential Revision:  https://reviews.freebsd.org/D37987
---
 lib/libc/gen/popen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/libc/gen/popen.c b/lib/libc/gen/popen.c
index 4f94405c2ff4..c5373077f3ae 100644
--- a/lib/libc/gen/popen.c
+++ b/lib/libc/gen/popen.c
@@ -181,7 +181,7 @@ popen(const char *command, const char *type)
 	 * the list which will cause an explicit close.
 	 */
 	if (!cloexec)
-		(void)_fcntl(*type == 'r' ? pdes[0] : pdes[1], F_SETFD, 0);
+		(void)_fcntl(fileno(iop), F_SETFD, 0);
 
 	return (iop);
 }