From nobody Sun Feb 12 22:06:24 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFM4s3gHyz3pF8N for ; Sun, 12 Feb 2023 22:06:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFM4s19G6z4Tbd for ; Sun, 12 Feb 2023 22:06:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x535.google.com with SMTP id d40so9356928eda.8 for ; Sun, 12 Feb 2023 14:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WkOdkICzmaQsG0IpwEpJ3rhCMYGWCSIGjZCpqjKDS4k=; b=RRPYrFGPCxBjgLCvyynBiUvcu++QBp4MMYm3d3dhAVowPU3ph/BUGDkmYQIJHz+zdc K2mD/5qpf67Mt1npyGrljcZY4bCRQ1j5nlLS7OqWRPcTgY8lVVyBGwUNZhIs6XZ9eoBB Wh3Q7auz60nXlX5uI+cbPrCyoR+gha+uOe/t1F3SgYeFsLeKbDaqani19uvOCsQx/Atg xXPsv+pgjkptz8aX/c/UPwbe3I0UVx/dLM4Js3Q312dMkD1Rh/lRlCvj/GyDq4eajzLP PeYiONnEb2ifwF2FSFzM3Bf5ZWT17W8lLIYtgRz6wU38wDIiIlNJzVs7+tNRhHORuiIE r+Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WkOdkICzmaQsG0IpwEpJ3rhCMYGWCSIGjZCpqjKDS4k=; b=PEP9kLUTrI0De2dnv+DH7WugiFmCX4jVmCXOD/XUw9/FoGIcXEERQLy1wzOKJzk2Af QMwuIQzoWD/Hf9jZwvbWJMdDSNJ3hkJNOwjfowTxMlFPGUoWpXdE8Zy4eG2Xn03/AoLm dFtYAsn40LNeS9Z6gIrVc/wy3+GvscufFvIpVhpyO+Cy2JrVaNZOEMzgTcM6ca4lhIdT eQM3Wtv4ivECJFFcU587XGtzhdTICdr4mH4Gj9VDV4hmBp0nq/VFlRTRVoPRt6l0FyNY G89pv/1mVN3hDUcRhRpMFjuOjf4Ew1yl7PPEQhv1A9z6kyfuCaZWMRnpxw+avvErxPSr ngTQ== X-Gm-Message-State: AO0yUKXdfdb8lXU/6OtO9a2BQzyPWf6juXheZC8rzG+GSENkG3J7G+7X LHvHKJKMVhRScblzdlSBZUTrqShedrtrVquofrO+8Q== X-Google-Smtp-Source: AK7set8GV7GbKyUbE+AlcnLTvnb3xBBUXggF1eZUkj0TOEkxOY65WYlg4UBYY2hDRnqeYHPf49Km6Wuag536baEqMlQ= X-Received: by 2002:a50:cdca:0:b0:4aa:a255:291f with SMTP id h10-20020a50cdca000000b004aaa255291fmr5137346edj.0.1676239595711; Sun, 12 Feb 2023 14:06:35 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202302122113.31CLD2av012258@gitrepo.freebsd.org> <72B4A01A-521D-4739-B1DD-6A19E98771EE@freebsd.org> <05AA573A-9692-40C3-8BF6-D52864BAB337@freebsd.org> In-Reply-To: From: Warner Losh Date: Sun, 12 Feb 2023 15:06:24 -0700 Message-ID: Subject: Re: git: eca005d8531f - main - zlib: silence K&R warns To: Mateusz Guzik Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000a947c605f487f118" X-Rspamd-Queue-Id: 4PFM4s19G6z4Tbd X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000a947c605f487f118 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 2:54 PM Mateusz Guzik wrote: > On 2/12/23, Warner Losh wrote: > > On Sun, Feb 12, 2023 at 2:40 PM Mateusz Guzik wrote= : > > > >> On 2/12/23, Jessica Clarke wrote: > >> > On 12 Feb 2023, at 21:23, Mateusz Guzik wrote: > >> >> > >> >> On 2/12/23, Jessica Clarke wrote: > >> >>> On 12 Feb 2023, at 21:13, Mateusz Guzik wrote: > >> >>>> > >> >>>> The branch main has been updated by mjg: > >> >>>> > >> >>>> URL: > >> >>>> > >> > https://cgit.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73= cdf181a0b > >> >>>> > >> >>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b > >> >>>> Author: Mateusz Guzik > >> >>>> AuthorDate: 2023-02-12 21:12:34 +0000 > >> >>>> Commit: Mateusz Guzik > >> >>>> CommitDate: 2023-02-12 21:12:34 +0000 > >> >>>> > >> >>>> zlib: silence K&R warns > >> >>>> > >> >>>> Sponsored by: Rubicon Communications, LLC ("Netgate") > >> >>>> --- > >> >>>> sys/conf/files | 18 +++++++++++------- > >> >>>> sys/modules/zlib/Makefile | 2 ++ > >> >>>> 2 files changed, 13 insertions(+), 7 deletions(-) > >> >>>> > >> >>>> diff --git a/sys/conf/files b/sys/conf/files > >> >>>> index 9171b434a7bf..53f90f7afc22 100644 > >> >>>> --- a/sys/conf/files > >> >>>> +++ b/sys/conf/files > >> >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c standard > >> >>>> libkern/strvalid.c standard > >> >>>> libkern/timingsafe_bcmp.c standard > >> >>>> contrib/zlib/adler32.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>> > >> >>> This doesn=E2=80=99t exist pre-Clang 15. > >> >>> > >> >> > >> >> this is main-only and it already has llvm15. the build requirement = is > >> >> top of the branch, so I don't see a problem. > >> >> > >> >> if you ran into trouble cross-compiling, you should probably update > >> >> that env instead of expecting working around the warn in the tree f= or > >> >> older compilers > >> > > >> > That is not our policy. Please fix this. > >> > > >> > >> Are you sure about that? I distinctly recall the supported path to get > >> top of the latest stable branch first, from there you should be able > >> to build the toolchain and the kernel. > >> > >> afaics the above change did not affect it > >> > >> If you insist, I can look for the exact paragraph in the docs. > >> > > > > The fix is trivial. > > > > https://reviews.freebsd.org/D38550 > > > > Please focus your efforts on commenting on the above and testing it out= . > > > > there is no warn with it > > but where is it stated that a compiler older than the newest in the > tree is supported for kernel builds? > As a project we've always benefitted from flexibility when it's trivial to be flexible. Warner > > > > > >> > Jess > >> > > >> >>> Jess > >> >>> > >> >>>> contrib/zlib/compress.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >>>> -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/crc32.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >>>> contrib/zlib/deflate.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >>>> -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/inffast.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/inflate.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/inftrees.c optional crypto | geom_uzip | = \ > >> >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >> >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/trees.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >>>> contrib/zlib/uncompr.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >> >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >> >>>> -Wno-deprecated-non-prototype" > >> >>>> contrib/zlib/zutil.c optional crypto | geom_uzip | = \ > >> >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >> >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >> >>>> diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefil= e > >> >>>> index 6391255e512b..178d3a3f7ab7 100644 > >> >>>> --- a/sys/modules/zlib/Makefile > >> >>>> +++ b/sys/modules/zlib/Makefile > >> >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTRICT_PROTOTYPES} = # > >> >>>> crc32.c:586 > >> >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # trees.c:232 > >> >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32 > >> >>>> > >> >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype > >> >>>> + > >> >>>> .include > >> >>> > >> >>> > >> >> > >> >> > >> >> -- > >> >> Mateusz Guzik > >> > > >> > > >> > >> > >> -- > >> Mateusz Guzik > >> > > > > > -- > Mateusz Guzik > --000000000000a947c605f487f118 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Feb 12, 2023 at 2:54 PM Mateu= sz Guzik <mjguzik@gmail.com>= wrote:
On 2/12/= 23, Warner Losh <imp= @bsdimp.com> wrote:
> On Sun, Feb 12, 2023 at 2:40 PM Mateusz Guzik <mjguzik@gmail.com> wrote:
>
>> On 2/12/23, Jessica Clarke <jrtc27@freebsd.org> wrote:
>> > On 12 Feb 2023, at 21:23, Mateusz Guzik <mjguzik@gmail.com> wrote:
>> >>
>> >> On 2/12/23, Jessica Clarke <jrtc27@freebsd.org> wrote:
>> >>> On 12 Feb 2023, at 21:13, Mateusz Guzik <mjg@FreeB= SD.org> wrote:
>> >>>>
>> >>>> The branch main has been updated by mjg:
>> >>>>
>> >>>> URL:
>> >>>>
>> https://c= git.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73cdf181a0b
>> >>>>
>> >>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b >> >>>> Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@= FreeBSD.org>
>> >>>> AuthorDate: 2023-02-12 21:12:34 +0000
>> >>>> Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@= FreeBSD.org>
>> >>>> CommitDate: 2023-02-12 21:12:34 +0000
>> >>>>
>> >>>>=C2=A0 =C2=A0zlib: silence K&R warns
>> >>>>
>> >>>>=C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Rubicon Com= munications, LLC ("Netgate")
>> >>>> ---
>> >>>> sys/conf/files=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 18 +++++++++++-------
>> >>>> sys/modules/zlib/Makefile |=C2=A0 2 ++
>> >>>> 2 files changed, 13 insertions(+), 7 deletions(-)=
>> >>>>
>> >>>> diff --git a/sys/conf/files b/sys/conf/files
>> >>>> index 9171b434a7bf..53f90f7afc22 100644
>> >>>> --- a/sys/conf/files
>> >>>> +++ b/sys/conf/files
>> >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 standard
>> >>>> libkern/strvalid.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0standard
>> >>>> libkern/timingsafe_bcmp.c=C2=A0 standard
>> >>>> contrib/zlib/adler32.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"
>> >>>
>> >>> This doesn=E2=80=99t exist pre-Clang 15.
>> >>>
>> >>
>> >> this is main-only and it already has llvm15. the build re= quirement is
>> >> top of the branch, so I don't see a problem.
>> >>
>> >> if you ran into trouble cross-compiling, you should proba= bly update
>> >> that env instead of expecting working around the warn in = the tree for
>> >> older compilers
>> >
>> > That is not our policy. Please fix this.
>> >
>>
>> Are you sure about that? I distinctly recall the supported path to= get
>> top of the latest stable branch first, from there you should be ab= le
>> to build the toolchain and the kernel.
>>
>> afaics the above change did not affect it
>>
>> If you insist, I can look for the exact paragraph in the docs.
>>
>
> The fix is trivial.
>
> https://reviews.freebsd.org/D38550
>
> Please focus your efforts on commenting on the above and testing it ou= t.
>

there is no warn with it

but where is it stated that a compiler older than the newest in the
tree is supported for kernel builds?

As= a project we've always benefitted from flexibility when it's trivi= al to
be flexible.

Warner
<= div>=C2=A0
>
>
>> > Jess
>> >
>> >>> Jess
>> >>>
>> >>>> contrib/zlib/compress.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 optional crypto | geom_uzip | \
>> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \=
>> >>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual"
>> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual
>> >>>> -Wno-deprecated-non-prototype"
>> >>>> contrib/zlib/crc32.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \=
>> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_= WSTRICT_PROTOTYPES}"
>> >>>> contrib/zlib/deflate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \=
>> >>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual"
>> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual
>> >>>> -Wno-deprecated-non-prototype"
>> >>>> contrib/zlib/inffast.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"
>> >>>> contrib/zlib/inflate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"
>> >>>> contrib/zlib/inftrees.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 optional crypto | geom_uzip | \
>> >>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>> >>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-depre= cated-non-prototype"
>> >>>> contrib/zlib/trees.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \=
>> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_= WSTRICT_PROTOTYPES}"
>> >>>> contrib/zlib/uncompr.c=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \=
>> >>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual"
>> >>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-= qual
>> >>>> -Wno-deprecated-non-prototype"
>> >>>> contrib/zlib/zutil.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>> >>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \=
>> >>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_= WSTRICT_PROTOTYPES}"
>> >>>> diff --git a/sys/modules/zlib/Makefile b/sys/modu= les/zlib/Makefile
>> >>>> index 6391255e512b..178d3a3f7ab7 100644
>> >>>> --- a/sys/modules/zlib/Makefile
>> >>>> +++ b/sys/modules/zlib/Makefile
>> >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTR= ICT_PROTOTYPES} #
>> >>>> crc32.c:586
>> >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # = trees.c:232
>> >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # = zutil.c:27,32
>> >>>>
>> >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype
>> >>>> +
>> >>>> .include <bsd.kmod.mk>
>> >>>
>> >>>
>> >>
>> >>
>> >> --
>> >> Mateusz Guzik <mjguzik gmail.com>
>> >
>> >
>>
>>
>> --
>> Mateusz Guzik <mjguzik gmail.com>
>>
>


--
Mateusz Guzik <mjguzik gmail.com>
--000000000000a947c605f487f118--