From nobody Sun Feb 12 21:47:52 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFLgW22nSz3pBjm for ; Sun, 12 Feb 2023 21:48:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFLgV30D1z4PgS for ; Sun, 12 Feb 2023 21:48:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id s11so2844264edd.10 for ; Sun, 12 Feb 2023 13:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b6EMt36rQx3PkAReBAI9tmz5BdnxulUmzgFrG9vUxf4=; b=JRizj2vkmB+bndcurHmU33RfUvhQv/HW2va9M3synaYcfIGHv8qP0I6e5hU22yviTE Bd6OqZkqleSzm8n7HwwzZBZ0amjwk/Kxxa7ryprA2VFW9Q1HLj29dKhiCZEelcq1WfYK And1JgpTznxLlPu3WemIbelY2cZ4rbNE9GtY8VOWZXUpc960CcuVYVFcABccBytd8fpK XCAWvVGMkTLojVkaz3DkZ9TYSb8dVfS8YBhkoAlxpoY8H/kh4GpR+RDlB44fz4fKBOae AvKkgoflyATH/AYtg8qXxAI3/qBPXvqB8hIzYcE3LSxsfiBRKxV+FKtfWZeQnjXfunOt nl1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b6EMt36rQx3PkAReBAI9tmz5BdnxulUmzgFrG9vUxf4=; b=1vgepM+hIXNGIPfEPoaDV7j35fSGh2IuBG27xwCJJNne5Adzoq8K6+bQMLjnib00aw f0uKHpIzvuy+c/mwjE9L//ng5L372JmAs7ZtkKlSqbvo9/1GZd22jLgcL81I17sGU5dc sS6IyVKmG6MiDYOfki3fO6m0Q7kHUFtzykdFrLoHYPvun3StATrbDHWevT8nCc9dMAIv 6+pPrBi/eA+MvT5JmpbOYa55PZrklFPwHOuMdFNYQZMPlHfuKISugHzOpyl9xpKX7qi2 W4LsEjDoryC58YeedI+QVL/Wa07TLAAKER8lmsmsLjwImRACPYEMN+QXegMbRu4kM8tl /YBQ== X-Gm-Message-State: AO0yUKUm0XPaI3gDD1I+AoKpACSHdX+cm7mogaGDxxM0aBDyA3q2uMG+ 2knjb6dPwG0CZ5zelXkiLtd9A9C/Mxo5wbnJ0wyhfg== X-Google-Smtp-Source: AK7set+3PM2va1UnBiqJ339om+FhrPkfIC358s55j7RwIJUoNTprMtMrPfRqh9QqyJ94FT/dsuQ2Mz9Xlf0mHk1ECCQ= X-Received: by 2002:a50:d51d:0:b0:4ac:b74b:a6a3 with SMTP id u29-20020a50d51d000000b004acb74ba6a3mr2022120edi.0.1676238483915; Sun, 12 Feb 2023 13:48:03 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202302122113.31CLD2av012258@gitrepo.freebsd.org> <72B4A01A-521D-4739-B1DD-6A19E98771EE@freebsd.org> <05AA573A-9692-40C3-8BF6-D52864BAB337@freebsd.org> In-Reply-To: From: Warner Losh Date: Sun, 12 Feb 2023 14:47:52 -0700 Message-ID: Subject: Re: git: eca005d8531f - main - zlib: silence K&R warns To: Mateusz Guzik Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000649e8305f487af00" X-Rspamd-Queue-Id: 4PFLgV30D1z4PgS X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000649e8305f487af00 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 2:40 PM Mateusz Guzik wrote: > On 2/12/23, Jessica Clarke wrote: > > On 12 Feb 2023, at 21:23, Mateusz Guzik wrote: > >> > >> On 2/12/23, Jessica Clarke wrote: > >>> On 12 Feb 2023, at 21:13, Mateusz Guzik wrote: > >>>> > >>>> The branch main has been updated by mjg: > >>>> > >>>> URL: > >>>> > https://cgit.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73= cdf181a0b > >>>> > >>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b > >>>> Author: Mateusz Guzik > >>>> AuthorDate: 2023-02-12 21:12:34 +0000 > >>>> Commit: Mateusz Guzik > >>>> CommitDate: 2023-02-12 21:12:34 +0000 > >>>> > >>>> zlib: silence K&R warns > >>>> > >>>> Sponsored by: Rubicon Communications, LLC ("Netgate") > >>>> --- > >>>> sys/conf/files | 18 +++++++++++------- > >>>> sys/modules/zlib/Makefile | 2 ++ > >>>> 2 files changed, 13 insertions(+), 7 deletions(-) > >>>> > >>>> diff --git a/sys/conf/files b/sys/conf/files > >>>> index 9171b434a7bf..53f90f7afc22 100644 > >>>> --- a/sys/conf/files > >>>> +++ b/sys/conf/files > >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c standard > >>>> libkern/strvalid.c standard > >>>> libkern/timingsafe_bcmp.c standard > >>>> contrib/zlib/adler32.c optional crypto | geom_uzip | \ > >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >>> > >>> This doesn=E2=80=99t exist pre-Clang 15. > >>> > >> > >> this is main-only and it already has llvm15. the build requirement is > >> top of the branch, so I don't see a problem. > >> > >> if you ran into trouble cross-compiling, you should probably update > >> that env instead of expecting working around the warn in the tree for > >> older compilers > > > > That is not our policy. Please fix this. > > > > Are you sure about that? I distinctly recall the supported path to get > top of the latest stable branch first, from there you should be able > to build the toolchain and the kernel. > > afaics the above change did not affect it > > If you insist, I can look for the exact paragraph in the docs. > The fix is trivial. https://reviews.freebsd.org/D38550 Please focus your efforts on commenting on the above and testing it out. Warner > > Jess > > > >>> Jess > >>> > >>>> contrib/zlib/compress.c optional crypto | geom_uzip | \ > >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >>>> -Wno-deprecated-non-prototype" > >>>> contrib/zlib/crc32.c optional crypto | geom_uzip | \ > >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >>>> contrib/zlib/deflate.c optional crypto | geom_uzip | \ > >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >>>> -Wno-deprecated-non-prototype" > >>>> contrib/zlib/inffast.c optional crypto | geom_uzip | \ > >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >>>> contrib/zlib/inflate.c optional crypto | geom_uzip | \ > >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >>>> contrib/zlib/inftrees.c optional crypto | geom_uzip | \ > >>>> - mxge | ddb_ctf | gzio | zfs | zlib > >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" > >>>> contrib/zlib/trees.c optional crypto | geom_uzip | \ > >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >>>> contrib/zlib/uncompr.c optional crypto | geom_uzip | \ > >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" > >>>> + compile-with "${NORMAL_C} -Wno-cast-qual > >>>> -Wno-deprecated-non-prototype" > >>>> contrib/zlib/zutil.c optional crypto | geom_uzip | \ > >>>> mxge | ddb_ctf | gzio | zfs | zlib \ > >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" > >>>> diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefile > >>>> index 6391255e512b..178d3a3f7ab7 100644 > >>>> --- a/sys/modules/zlib/Makefile > >>>> +++ b/sys/modules/zlib/Makefile > >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTRICT_PROTOTYPES} # > >>>> crc32.c:586 > >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # trees.c:232 > >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32 > >>>> > >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype > >>>> + > >>>> .include > >>> > >>> > >> > >> > >> -- > >> Mateusz Guzik > > > > > > > -- > Mateusz Guzik > --000000000000649e8305f487af00 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Feb 12, 2023 at 2:40 PM Mateu= sz Guzik <mjguzik@gmail.com>= wrote:
On 2/12/= 23, Jessica Clarke <jrtc27@freebsd.org> wrote:
> On 12 Feb 2023, at 21:23, Mateusz Guzik <mjguzik@gmail.com> wrote:
>>
>> On 2/12/23, Jessica Clarke <jrtc27@freebsd.org> wrote:
>>> On 12 Feb 2023, at 21:13, Mateusz Guzik <mjg@FreeBSD.org>= ; wrote:
>>>>
>>>> The branch main has been updated by mjg:
>>>>
>>>> URL:
>>>> h= ttps://cgit.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101e73cdf= 181a0b
>>>>
>>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b
>>>> Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.o= rg>
>>>> AuthorDate: 2023-02-12 21:12:34 +0000
>>>> Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.o= rg>
>>>> CommitDate: 2023-02-12 21:12:34 +0000
>>>>
>>>>=C2=A0 =C2=A0zlib: silence K&R warns
>>>>
>>>>=C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Rubicon Communicatio= ns, LLC ("Netgate")
>>>> ---
>>>> sys/conf/files=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = 18 +++++++++++-------
>>>> sys/modules/zlib/Makefile |=C2=A0 2 ++
>>>> 2 files changed, 13 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/sys/conf/files b/sys/conf/files
>>>> index 9171b434a7bf..53f90f7afc22 100644
>>>> --- a/sys/conf/files
>>>> +++ b/sys/conf/files
>>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 standard
>>>> libkern/strvalid.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0standa= rd
>>>> libkern/timingsafe_bcmp.c=C2=A0 standard
>>>> contrib/zlib/adler32.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-deprecated-non= -prototype"
>>>
>>> This doesn=E2=80=99t exist pre-Clang 15.
>>>
>>
>> this is main-only and it already has llvm15. the build requirement= is
>> top of the branch, so I don't see a problem.
>>
>> if you ran into trouble cross-compiling, you should probably updat= e
>> that env instead of expecting working around the warn in the tree = for
>> older compilers
>
> That is not our policy. Please fix this.
>

Are you sure about that? I distinctly recall the supported path to get
top of the latest stable branch first, from there you should be able
to build the toolchain and the kernel.

afaics the above change did not affect it

If you insist, I can look for the exact paragraph in the docs.

The fix is trivial.


Please focus your efforts on commenting o= n the above and testing it out.

Warner
= =C2=A0
> Jess
>
>>> Jess
>>>
>>>> contrib/zlib/compress.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 optional crypto | geom_uzip | \
>>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-qual"= ;
>>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-qual
>>>> -Wno-deprecated-non-prototype"
>>>> contrib/zlib/crc32.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_WSTRICT_P= ROTOTYPES}"
>>>> contrib/zlib/deflate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-qual"= ;
>>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-qual
>>>> -Wno-deprecated-non-prototype"
>>>> contrib/zlib/inffast.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-deprecated-non= -prototype"
>>>> contrib/zlib/inflate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-deprecated-non= -prototype"
>>>> contrib/zlib/inftrees.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 optional crypto | geom_uzip | \
>>>> -=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib
>>>> +=C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-deprecated-non= -prototype"
>>>> contrib/zlib/trees.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_WSTRICT_P= ROTOTYPES}"
>>>> contrib/zlib/uncompr.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>> -=C2=A0 compile-with "${NORMAL_C} -Wno-cast-qual"= ;
>>>> +=C2=A0 compile-with "${NORMAL_C} -Wno-cast-qual
>>>> -Wno-deprecated-non-prototype"
>>>> contrib/zlib/zutil.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0optional crypto | geom_uzip | \
>>>>=C2=A0 =C2=A0 mxge | ddb_ctf | gzio | zfs | zlib \
>>>>=C2=A0 =C2=A0 compile-with "${NORMAL_C} ${NO_WSTRICT_P= ROTOTYPES}"
>>>> diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/= Makefile
>>>> index 6391255e512b..178d3a3f7ab7 100644
>>>> --- a/sys/modules/zlib/Makefile
>>>> +++ b/sys/modules/zlib/Makefile
>>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTRICT_PROTO= TYPES} #
>>>> crc32.c:586
>>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # trees.c:2= 32
>>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # zutil.c:2= 7,32
>>>>
>>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype
>>>> +
>>>> .include <bsd.kmod.mk>
>>>
>>>
>>
>>
>> --
>> Mateusz Guzik <mjguzik gmail.com>
>
>


--
Mateusz Guzik <mjguzik gmail.com>
--000000000000649e8305f487af00--