From nobody Sun Feb 12 21:40:28 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFLVl0238z3p9m7; Sun, 12 Feb 2023 21:40:31 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFLVk5Pfrz4N1m; Sun, 12 Feb 2023 21:40:30 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-15fe106c7c7so13234210fac.8; Sun, 12 Feb 2023 13:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X488yGmqrqiuGWqcUfeQePb8kTIxriUGToQkUCeJoLE=; b=VKPbntdFu1xYz9H1GzmD3dRdtS3p7OsPhB+lbH+/Ab2sC3Aaa+O2GkdTNLphT/4ylX v7dhOVdP49G/+ks2GM9X5fW2viSJ5cvJdpI91RlYN8sisaiNUutax+QJmdsgRUBSQIpO P3zoXeoUI+2HYR09caXeegS/yn9GNAv6XRf8q+z9Zrb183CcCBdPS5VINL9Bje4L+0S+ Gy38mAM7hNoTarYIEJnoSSJ5lisXzgI94FGxWLb4xuGSAA8U7mzLEgUDl22vWyE4OZ/+ G/j6ohXYKL8Tv1imEs+mUa1winiMinXYYsTWmB/XofQM6/BEmdiL3+a1EXBcoan+4iLD DDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X488yGmqrqiuGWqcUfeQePb8kTIxriUGToQkUCeJoLE=; b=hFMOaVJT2r55lNWPwW0fcYR/AX4Z1mBJTXsHy/uUeBvFooLfLL0qgSKCqsCy5Cfu6R KU9JBU3OVM9rb4CWb9qj+qFv9yFVzS0YmKmd+JCj8MCMcSkGK3bgYIFSMbb3zzp+jjQX DUEGkPfx04WpmaK6FHuPmva1VOe0X+2vDp4jYwa6KnVLen6rMpk+7a/1HgydT/LpVCUx 5Y06Z+nQGw9AV2WlmUAAiRR8/dH1rNdG0Wt75dx5PqU7M6j9u1YQFJvyzCl11Fjfwlk3 e3s3Wu9aSx3UzQVsDoZekbJTuN6zMzwGPpwdn9xC6e+usKCkQ99gag3TSvhpsEUUOsBZ xi+g== X-Gm-Message-State: AO0yUKXPR4pyj02iGzDDU2AWCAPhT8M4UCAkRZVjFr84wHWoP+WpVbQz TkVPGuGQ2lf8WWWpfqfyk9zlYyAhfhuBr1FkvpW+5OBL X-Google-Smtp-Source: AK7set+DgcdzUt5dWoCRarhiRp+RVuE2AjPIiUbWW2s+hcWjWeqeHkeEVtrLDhREldAgTyP3eD1VZHug11FeRf3sGJc= X-Received: by 2002:a05:6870:1250:b0:16d:c7db:f60f with SMTP id 16-20020a056870125000b0016dc7dbf60fmr906411oao.159.1676238029407; Sun, 12 Feb 2023 13:40:29 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Received: by 2002:ac9:6c92:0:b0:4b3:d953:974c with HTTP; Sun, 12 Feb 2023 13:40:28 -0800 (PST) In-Reply-To: <05AA573A-9692-40C3-8BF6-D52864BAB337@freebsd.org> References: <202302122113.31CLD2av012258@gitrepo.freebsd.org> <72B4A01A-521D-4739-B1DD-6A19E98771EE@freebsd.org> <05AA573A-9692-40C3-8BF6-D52864BAB337@freebsd.org> From: Mateusz Guzik Date: Sun, 12 Feb 2023 22:40:28 +0100 Message-ID: Subject: Re: git: eca005d8531f - main - zlib: silence K&R warns To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4PFLVk5Pfrz4N1m X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 2/12/23, Jessica Clarke wrote: > On 12 Feb 2023, at 21:23, Mateusz Guzik wrote: >> >> On 2/12/23, Jessica Clarke wrote: >>> On 12 Feb 2023, at 21:13, Mateusz Guzik wrote: >>>> >>>> The branch main has been updated by mjg: >>>> >>>> URL: >>>> https://cgit.FreeBSD.org/src/commit/?id=3Deca005d8531fd153f46f941f3101= e73cdf181a0b >>>> >>>> commit eca005d8531fd153f46f941f3101e73cdf181a0b >>>> Author: Mateusz Guzik >>>> AuthorDate: 2023-02-12 21:12:34 +0000 >>>> Commit: Mateusz Guzik >>>> CommitDate: 2023-02-12 21:12:34 +0000 >>>> >>>> zlib: silence K&R warns >>>> >>>> Sponsored by: Rubicon Communications, LLC ("Netgate") >>>> --- >>>> sys/conf/files | 18 +++++++++++------- >>>> sys/modules/zlib/Makefile | 2 ++ >>>> 2 files changed, 13 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/sys/conf/files b/sys/conf/files >>>> index 9171b434a7bf..53f90f7afc22 100644 >>>> --- a/sys/conf/files >>>> +++ b/sys/conf/files >>>> @@ -4099,28 +4099,32 @@ libkern/strtouq.c standard >>>> libkern/strvalid.c standard >>>> libkern/timingsafe_bcmp.c standard >>>> contrib/zlib/adler32.c optional crypto | geom_uzip | \ >>>> - mxge | ddb_ctf | gzio | zfs | zlib >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" >>> >>> This doesn=E2=80=99t exist pre-Clang 15. >>> >> >> this is main-only and it already has llvm15. the build requirement is >> top of the branch, so I don't see a problem. >> >> if you ran into trouble cross-compiling, you should probably update >> that env instead of expecting working around the warn in the tree for >> older compilers > > That is not our policy. Please fix this. > Are you sure about that? I distinctly recall the supported path to get top of the latest stable branch first, from there you should be able to build the toolchain and the kernel. afaics the above change did not affect it If you insist, I can look for the exact paragraph in the docs. > Jess > >>> Jess >>> >>>> contrib/zlib/compress.c optional crypto | geom_uzip | \ >>>> mxge | ddb_ctf | gzio | zfs | zlib \ >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" >>>> + compile-with "${NORMAL_C} -Wno-cast-qual >>>> -Wno-deprecated-non-prototype" >>>> contrib/zlib/crc32.c optional crypto | geom_uzip | \ >>>> mxge | ddb_ctf | gzio | zfs | zlib \ >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" >>>> contrib/zlib/deflate.c optional crypto | geom_uzip | \ >>>> mxge | ddb_ctf | gzio | zfs | zlib \ >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" >>>> + compile-with "${NORMAL_C} -Wno-cast-qual >>>> -Wno-deprecated-non-prototype" >>>> contrib/zlib/inffast.c optional crypto | geom_uzip | \ >>>> - mxge | ddb_ctf | gzio | zfs | zlib >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" >>>> contrib/zlib/inflate.c optional crypto | geom_uzip | \ >>>> - mxge | ddb_ctf | gzio | zfs | zlib >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" >>>> contrib/zlib/inftrees.c optional crypto | geom_uzip | \ >>>> - mxge | ddb_ctf | gzio | zfs | zlib >>>> + mxge | ddb_ctf | gzio | zfs | zlib \ >>>> + compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" >>>> contrib/zlib/trees.c optional crypto | geom_uzip | \ >>>> mxge | ddb_ctf | gzio | zfs | zlib \ >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" >>>> contrib/zlib/uncompr.c optional crypto | geom_uzip | \ >>>> mxge | ddb_ctf | gzio | zfs | zlib \ >>>> - compile-with "${NORMAL_C} -Wno-cast-qual" >>>> + compile-with "${NORMAL_C} -Wno-cast-qual >>>> -Wno-deprecated-non-prototype" >>>> contrib/zlib/zutil.c optional crypto | geom_uzip | \ >>>> mxge | ddb_ctf | gzio | zfs | zlib \ >>>> compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" >>>> diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefile >>>> index 6391255e512b..178d3a3f7ab7 100644 >>>> --- a/sys/modules/zlib/Makefile >>>> +++ b/sys/modules/zlib/Makefile >>>> @@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=3D${NO_WSTRICT_PROTOTYPES} # >>>> crc32.c:586 >>>> CWARNFLAGS.trees.c+=3D${NO_WSTRICT_PROTOTYPES} # trees.c:232 >>>> CWARNFLAGS.zutil.c+=3D${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32 >>>> >>>> +CWARNFLAGS+=3D-Wno-deprecated-non-prototype >>>> + >>>> .include >>> >>> >> >> >> -- >> Mateusz Guzik > > --=20 Mateusz Guzik