From nobody Wed Feb 08 13:12:41 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PBgQr1K6hz3nPhT; Wed, 8 Feb 2023 13:12:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PBgQq3VYhz4Ggl; Wed, 8 Feb 2023 13:12:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 318DCfoS023367 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 8 Feb 2023 15:12:45 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 318DCfoS023367 Received: (from kostik@localhost) by tom.home (8.17.1/8.16.1/Submit) id 318DCfM8023366; Wed, 8 Feb 2023 15:12:41 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 8 Feb 2023 15:12:41 +0200 From: Konstantin Belousov To: Kyle Evans Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2ffdc21324bd - main - config: make changes to allow some parts to build as C++ Message-ID: References: <202302080610.3186ANQd091168@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202302080610.3186ANQd091168@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4PBgQq3VYhz4Ggl X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, Feb 08, 2023 at 06:10:23AM +0000, Kyle Evans wrote: > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2ffdc21324bd1772fa2f40efed3987afecabf5cb > > commit 2ffdc21324bd1772fa2f40efed3987afecabf5cb > Author: Kyle Evans > AuthorDate: 2023-02-08 06:02:56 +0000 > Commit: Kyle Evans > CommitDate: 2023-02-08 06:09:10 +0000 > > config: make changes to allow some parts to build as C++ > > Highlights: > - Avoid keywords (this, not) as variable names > - Move yyparse into config.h with other declarations > - All declarations in config.h are assumed guilty until proven innocent > - Some const-correctness > - Casting malloc/calloc returns > > Note that we're not building any C++ here yet, this will be introduced > in other commits to replace some of the lib dependencies. Reducing the > number of FreeBSD-specific dependencies we have reduces some friction > for building our bootstrap tools independently in other environments. > > Reviewed by: imp > Sponsored by: Klara, Inc. > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D38274 > --- > usr.sbin/config/config.h | 6 ++++++ > usr.sbin/config/main.c | 19 ++++++++++--------- > usr.sbin/config/mkmakefile.c | 44 ++++++++++++++++++++++---------------------- > usr.sbin/config/mkoptions.c | 28 ++++++++++++++-------------- > 4 files changed, 52 insertions(+), 45 deletions(-) > > diff --git a/usr.sbin/config/config.h b/usr.sbin/config/config.h > index 79d0a788bae7..7d97d66979e2 100644 > --- a/usr.sbin/config/config.h > +++ b/usr.sbin/config/config.h > @@ -35,12 +35,15 @@ > /* > * Config. > */ > +#include /* __BEGIN_DECLS/__END_DECLS */ But sys/types.h already includes sys/cdefs.h (as most of our headers). > #include > #include