From nobody Fri Feb 03 19:34:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7m7M1MmPz3kflR; Fri, 3 Feb 2023 19:34:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7m7M0tYHz3C2j; Fri, 3 Feb 2023 19:34:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675452863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=srCBaYHp2MYf70YJq/cpD3GQj8ajCr7HDoZ4Olhst80=; b=aibecAVm+E6u3O+0VJdGHAs5YtUVa3oc9cabB8PAL6mMIakyeCK+dHKsbK2Kwite2h9/Ff at5tq6+1qpti+vuoe5xwQIS+8UjLS9tlzsXrHaPx1Mdyzuk8S2Khcn2rNGvZpKQmeccrDd BTRTd0772/tg5dLYv1S+NjdDwF93fHRd/XgSPzZDmb57BnhIE+dF/vbBehVFoSI0Ggse40 3zRBV+poyouk823YFO6/RsYS0zWRH4hyFKsuCvEMuYWpYuCRRcEl4+y3KZtmubbcB01VaX gP6BVJL0Fsz3VOEr6rxQKMGoQeZIVK0cjSswrPf5cx7dXwOScuCCtkKHjEYp8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675452863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=srCBaYHp2MYf70YJq/cpD3GQj8ajCr7HDoZ4Olhst80=; b=tFLjsxs0qjOVWA3Br/KWrGwu8ShwqnOXhwa7YZKNBh01Z/Vm3pvyECfuscVyLuCjzbIeek PAzlqpeVldm5ts8EVQlm75PrM/nES3XRQNTFbQwXZJ5PD0fgFRodu6xZxcGeBrFBV+ikMG OGEaReGo2HG6zxP5makv8FW8mO1tPttTI6YRDmFdC8oci6xpM8quaNkPcXsP1yezvYHDzI oQSlSwy79ioLQnNoi4kvn3rb/dFQp7nHwHQbuTN1CssETlG8jsaF5tvRAf49nDXrpJWHFZ ifEWPrEVS0CMJl9tpbL5ZSK6iA3V3sRbIC4UwfQaglhO029QgFVQX5Q/hLX/yg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675452863; a=rsa-sha256; cv=none; b=RT1HR+bCnf2c0aAna+CWny9inj4QbD9RGIGky988jTfo6RtTXHCGSTWAxXniO7ihzSBzkE 7mkxjRBpXZqe7fv9xfW7Z06/K1gzGxXpOet3I50yuTzyIkZaU+xwdQSL9wnuunl3Et+Ftj FnVACYtWUidVkDSIB6osRUwZhfDc6cWVHJme9mN9q8lfKyWxW03XV4YooCarpJrWujcn9O lQHt35MoHs3vWBLAU/yrXFEuyE9cMR4c6NhkEU2PncfeqCpLxfk4SwnhDoNZcvAkXe5Qzf yMtJvt6rmhMMilmSX0jjKmqg30iJJSU0wwk8CndfbO6HT2lfxPc/HTpcrCn21A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P7m7L6d80zmWG; Fri, 3 Feb 2023 19:34:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 313JYM6h041469; Fri, 3 Feb 2023 19:34:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 313JYMl4041468; Fri, 3 Feb 2023 19:34:22 GMT (envelope-from git) Date: Fri, 3 Feb 2023 19:34:22 GMT Message-Id: <202302031934.313JYMl4041468@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: a9afe0864f8e - main - tcp: bring comment for tcp_connect() up to date List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a9afe0864f8ec8242c97dc21e3dec15570ea44c8 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=a9afe0864f8ec8242c97dc21e3dec15570ea44c8 commit a9afe0864f8ec8242c97dc21e3dec15570ea44c8 Author: Gleb Smirnoff AuthorDate: 2023-02-03 19:33:36 +0000 Commit: Gleb Smirnoff CommitDate: 2023-02-03 19:33:36 +0000 tcp: bring comment for tcp_connect() up to date We no longer use in_pcbbind() since 25102351509. The comment about truncating old TIME-WAIT describes a code that had been removed back in 2004 in c94c54e4df9a. --- sys/netinet/tcp_usrreq.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/sys/netinet/tcp_usrreq.c b/sys/netinet/tcp_usrreq.c index 6f979c053a5c..b89cdd30a825 100644 --- a/sys/netinet/tcp_usrreq.c +++ b/sys/netinet/tcp_usrreq.c @@ -1387,13 +1387,9 @@ struct protosw tcp6_protosw = { #ifdef INET /* * Common subroutine to open a TCP connection to remote host specified - * by struct sockaddr_in in mbuf *nam. Call in_pcbbind to assign a local - * port number if needed. Call in_pcbconnect_setup to do the routing and - * to choose a local host address (interface). If there is an existing - * incarnation of the same connection in TIME-WAIT state and if the remote - * host was sending CC options and if the connection duration was < MSL, then - * truncate the previous TIME-WAIT state and proceed. - * Initialize connection parameters and enter SYN-SENT state. + * by struct sockaddr_in. Call in_pcbconnect_setup() to choose local + * host address and assign a local port number if needed. Initialize + * connection parameters and enter SYN-SENT state. */ static int tcp_connect(struct tcpcb *tp, struct sockaddr_in *sin, struct thread *td)