From nobody Fri Feb 03 16:16:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7glY03k8z3kTpy; Fri, 3 Feb 2023 16:16:57 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7glX6htkz3pC0; Fri, 3 Feb 2023 16:16:56 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675441016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g/z7hxUXWLO3Y8ZZf4Qbgf7r6S956enCiWlwtKsk0Z0=; b=mXGcYwXXroCmN09Jvtt2P42e94Ddqkk7WGhreEMxpet5ZZjphUIgMq4NSciwwpBa+qtDDh qWjsV4s9LdRQKKD3NOAcS4pNunX/i7vt/UOCcicDdvBb+de8AfPynfZeC6zW4JEsXpRxy4 odaQnyxy8lSRT7bnyi+fl4bSWTmVysJt6cEk6um9xe8L15sfxHU97DQI9qFHuxFIGXhi0A 2PbA6wvHDRvWL3a84ab3i4LzGTtXuiuhk89a+VWchoCI0bjHnGJSKYIGCmrhZQEzLloa6l W1AUgiT5rgecCvyhHezyOG9HLpk3pV0puGoo7s4ugCKWt/Q8qVhOslUvJU9jLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675441016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g/z7hxUXWLO3Y8ZZf4Qbgf7r6S956enCiWlwtKsk0Z0=; b=Pm04dBaqIvADb1V3JQ6Afxcxrv3B5kyO+7/IowMKNrZ8m9B5mxlpbkD9yO7b4ksWUAj+Q/ AuA3y1vDLU0Svzu0h0axxn9uFYFuirOdDIaaCI5k0CMMX288AqzSPUTe2A+G8BcoAeqsNm 11N2++/UP1cNU6Lfv/B9PqEwqmFpe5aHaffC00RSuFdjjxqq+dJ5vE188Tu0yq/GHsjQUA tUmOhIrTtj9ocS8kJnWmUrDPGTrsthynaGwVAc1bl3XLwQhLYdG5lUIZUpdLpRApjHcpJ+ rU1ugKnWfBJMAV1VaH5hTp1TcaXQl5RNsFJBh5R/lXSLDgTNK2qaM8dC3tL1LQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675441016; a=rsa-sha256; cv=none; b=Eswy4iL6tKsb97t2SetUe/qEn+BE6BdS8NPnM9/Y1H6lIGLW6oqYIJRnWE03MwnSHn1AfD v+Nz03ccUjIRd8G+asn6KyVHlCMT7U9muNs2GFaotq3fc9kaid4RPeaGxBu+mXVbH2pBy7 +FfFX2etOjc+DiKu/QvBFYx8dfWafefzPZyY9JyV/kFaDiiXiCeWXOmmyrwT15YxOhdH5z JM7FmXdI4seQWq7NMs08gfvLE6sbSv8tv5cWeTyq0IqU3BGjFlsq8io5gxDc2i0h/WTUAT vJJz/L5lvLTv9/FgkxWcpQlFLwDK/4KpFR9GY/WVvhBKWp4xdMYjvx1hDKhrWA== Received: from ltc.des.no (unknown [178.232.223.163]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P7glX4vJyz11Cq; Fri, 3 Feb 2023 16:16:56 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.no (Postfix, from userid 1001) id DDB74F82C4; Fri, 3 Feb 2023 17:16:54 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Kyle Evans Cc: "Rodney W. Grimes" , rgrimes@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cb96a0ef0040 - main - cp: Minor code cleanup. In-Reply-To: (Kyle Evans's message of "Fri, 3 Feb 2023 10:11:36 -0600") References: <202302031558.313Fw2sJ051540@gndrsh.dnsmgr.net> <86lele3f6c.fsf@ltc.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (berkeley-unix) Date: Fri, 03 Feb 2023 17:16:54 +0100 Message-ID: <86edr63ert.fsf@ltc.des.no> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N Kyle Evans writes: > fts_read() doesn't always set errno to 0; notably, there's a number of > FCHDIR() paths that don't set errno (and the change that added it > mentions that scenario exactly) and will return NULL because of an > error. The man page says it does, and as far as I can tell from the code it does. Can you please provide a test case? DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org