From nobody Thu Feb 02 23:04:20 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7DrW1w9fz3kh6H; Thu, 2 Feb 2023 23:04:43 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7DrW1K7sz3NP7; Thu, 2 Feb 2023 23:04:43 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675379083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eKjM883WbJRhP3w+fMBqpceexGVOnPrEotIy+jfCiJY=; b=mIvMUDlZkZksRo2Xj+W9590Y9mlglJ7D3fWYckTpSqbpjpq1IMmQVlVlSJ+yP88MFR+pDc 2F959hWDMbbyy7lDv5f2IhtrV4ePcuSctdNLP4kszj25dU50XgyaX5EqMXtzAQG2CjwEEg sqUxDh1xWdUHLWLq1pnxC4NgYezhm8q0Bp0ecMdOilA4c9ZNX2q5FrKyYMiewt62+DHy5p YHs5BHdLaQ0KAFJHO7lyvcJVLvzLfCKz9Bd8RoXSz4ktDmR7ZXK0j8ymQ424hLuxiJPSek F/EpjpqLBeWm0PLyKkByU0f0BJhtNh4YhxwrvkjqT0L5J9Z9vQh9NeH0+ITKew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675379083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eKjM883WbJRhP3w+fMBqpceexGVOnPrEotIy+jfCiJY=; b=i9wsSgVKzlsA/invT4rlrvjj+6LYN41amHwZZxokoq1eKED69cqkXy5sfY8pKrItwdkviZ KUH0XCXCCLHhe5+/jB6BJnPcikSkMdwaCf3R2C+COtl/i6PWxggU0V9TSIDI1igmpo39FS H8vk3yspKcElpUu/5rH6dxcSuJiVQID2izlJt6uj+hfC3MwVgit/dlL1I++m81micUm+An m2N49e3XYXhAbZVgx4sxVN7MTTKSGC4S9lYSfDJzzE8UbYuD7aad10ClnNSs0PteZ5nTFJ p0ZwTK6NKcD0fjSDSWbCqCq9hNEsaxFWqSZPMNm6Mu7SFAkXuruNfuzpNUBcFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675379083; a=rsa-sha256; cv=none; b=nMHWvTpYO7FvaV7vOIH8p/d8xaHTQhf+jCcirEzAgXu022fAjpkTZP9KXkHNRgwtphjCqF MJkmgX869uMkEsDk3xZ78W591Hojp5PfeIlJjuzgHVAMBAsMByK2yMfys9T8JA/OfZol9k A0a9C4dlYgHDbckW3AT8kmWDYvI4zb+LFyxp47499CsFiJww/fdfx0jqAeEmkHuUFWnsHj 3Y4xY/XMJxt0KELDkVSTIxwTDJWw2kYGW2zdTGN6c5qJ8mZA83S9o72Te5s9OAZ029Fko2 WToQQs/t6wnjDMb0Rs8cfJhBOMTrkvjUDvHoHf1c30yJ4X3dPZ1McQ6CI499jw== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P7DrV6lWwzfwH; Thu, 2 Feb 2023 23:04:42 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C7DC341B02; Fri, 3 Feb 2023 00:04:40 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_CF5C187F-D435-4014-A331-6EAC4209D028"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: git: fb53e7adaf5b - main - tarfs: Fix 32-bit build. From: Dimitry Andric In-Reply-To: <202302022039.312KdedK078659@gitrepo.freebsd.org> Date: Fri, 3 Feb 2023 00:04:20 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: <7AB1A313-19CD-4A37-BB7D-22BD384BE327@FreeBSD.org> References: <202302022039.312KdedK078659@gitrepo.freebsd.org> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= X-Mailer: Apple Mail (2.3731.400.51.1.1) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_CF5C187F-D435-4014-A331-6EAC4209D028 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 2 Feb 2023, at 21:39, Dag-Erling Sm=C3=B8rgrav = wrote: >=20 > The branch main has been updated by des: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfb53e7adaf5b45ca08f650babc40077d= eff5e9af >=20 > commit fb53e7adaf5b45ca08f650babc40077deff5e9af > Author: Dag-Erling Sm=C3=B8rgrav > AuthorDate: 2023-02-02 20:36:01 +0000 > Commit: Dag-Erling Sm=C3=B8rgrav > CommitDate: 2023-02-02 20:39:10 +0000 >=20 > tarfs: Fix 32-bit build. >=20 > Sponsored by: Juniper Networks, Inc. > Sponsored by: Klara, Inc. ... > --- a/sys/fs/tarfs/tarfs_subr.c > +++ b/sys/fs/tarfs/tarfs_subr.c > @@ -137,7 +137,7 @@ tarfs_print_node(struct tarfs_node *tnp) > printf("\tvnode %p\n", tnp->vnode); > printf("\ttmp %p\n", tnp->tmp); > printf("\ttype %d\n", tnp->type); > - printf("\tino %lu\n", tnp->ino); > + printf("\tino %lu\n", (unsigned long)tnp->ino); > printf("\tsize %zu\n", tnp->size); > printf("\tname %s\n", > (tnp->name =3D=3D NULL) ? "<>" : tnp->name); > @@ -146,7 +146,7 @@ tarfs_print_node(struct tarfs_node *tnp) > printf("\tgid %d\n", tnp->gid); > printf("\tmode o%o\n", tnp->mode); > printf("\tflags %u\n", tnp->flags); > - printf("\tnlink %lu\n", tnp->nlink); > + printf("\tnlink %lu\n", (unsigned long)tnp->nlink); > printf("\tatime %d\n", (int)tnp->atime.tv_sec); > printf("\tmtime %d\n", (int)tnp->mtime.tv_sec); > printf("\tctime %d\n", (int)tnp->ctime.tv_sec); This be just nitpicking, but the ino and nlink fields are typically defined as int64_t and uint64_t, so these should be printed as such. Since PRId64 and PRIu64 are apparently frowned upon, the usual solution is to cast everything to intmax_t or uintmax_t, and use %j for the modifier. -Dimitry --Apple-Mail=_CF5C187F-D435-4014-A331-6EAC4209D028 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY9xBdQAKCRCwXqMKLiCW o9p4AKDa0t6UXWjyDEUD30BNktOaHzJs/gCgwn7r2JeQ78DjRpDEWgqlhkeBzyw= =EzaJ -----END PGP SIGNATURE----- --Apple-Mail=_CF5C187F-D435-4014-A331-6EAC4209D028--