From nobody Thu Feb 02 07:49:57 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6rYD4BHFz3cBgP; Thu, 2 Feb 2023 07:50:08 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6rYC5c2Mz3JlV; Thu, 2 Feb 2023 07:50:07 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1675324198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iSznAFW/+ODvDw4t4HYeoLxLAGUeWcVzYO3Vw6d31uY=; b=qBqBnm1vMr0u9xWPdaxyqLpo+A4z3zMe2DmlMg6cecriFhL2ARkr9+CIk9KMt/VAEC6d4o pJGuVhDwq842LqjrSvlf8yChLpZXyMTNry0DDD7l8vxI/oAmwW6hjioBI5VJpPAgpkxnpb +32Y8J5MHv4ysghyPeIvy3i/+wBhwW8= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 06ed253e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Feb 2023 07:49:58 +0000 (UTC) Date: Thu, 2 Feb 2023 08:49:57 +0100 From: Emmanuel Vadot To: Jessica Clarke Cc: Stefan =?ISO-8859-1?Q?E=DFer?= , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 1e0853ee8403 - main - sys/kbio.h: support Unicode key codes in vt keymap files Message-Id: <20230202084957.631788fd720591beb675acd3@bidouilliste.com> In-Reply-To: <84830C1A-149F-4B05-99DC-1E0B50C8B59A@freebsd.org> References: <202302011630.311GUmt1068106@gitrepo.freebsd.org> <84830C1A-149F-4B05-99DC-1E0B50C8B59A@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4P6rYC5c2Mz3JlV X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, 2 Feb 2023 07:43:31 +0000 Jessica Clarke wrote: > On 1 Feb 2023, at 16:40, Jessica Clarke wrote: > >=20 > > On 1 Feb 2023, at 16:30, Stefan E=DFer wrote: > >>=20 > >> The branch main has been updated by se: > >>=20 > >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D1e0853ee84031e4131a0b8c= c8737696f199d3d4c > >>=20 > >> commit 1e0853ee84031e4131a0b8cc8737696f199d3d4c > >> Author: Stefan E=DFer > >> AuthorDate: 2023-02-01 16:24:18 +0000 > >> Commit: Stefan E=DFer > >> CommitDate: 2023-02-01 16:24:18 +0000 > >>=20 > >> sys/kbio.h: support Unicode key codes in vt keymap files > >>=20 > >> Some keyboard definitions return Unicode characters that cannot be > >> represented in the 8 bits provided by an u_char. > >>=20 > >> Extend then width of the keycode entries to 16 bits to allow for all > >> keycodes currently defined in share/vt/keymaps/*,kbd. > >>=20 > >> Reported by: yuri@aetern.org > >> MFC after: 3 days > >> --- > >> sys/sys/kbio.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >>=20 > >> diff --git a/sys/sys/kbio.h b/sys/sys/kbio.h > >> index 7f17bda76c51..b0779f5ed114 100644 > >> --- a/sys/sys/kbio.h > >> +++ b/sys/sys/kbio.h > >> @@ -200,7 +200,7 @@ typedef struct okeymap okeymap_t; > >>=20 > >> struct acc_t { > >> u_char accchar; > >> - u_char map[NUM_ACCENTCHARS][2]; > >> + u_short map[NUM_ACCENTCHARS][2]; > >=20 > > This breaks ABI for [GP]IO_DEADKEYMAP. >=20 > Ping. This is important, especially with the MFC after. >=20 > This should be reverted and re-landed with compat IMO. >=20 > Jess Also more importantly it should be discussed. Are we sure that this modification will be enough for all keymaps ? > >> }; > >>=20 > >> struct accentmap { >=20 --=20 Emmanuel Vadot