From nobody Thu Feb 02 07:39:27 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6rJv6C4Rz3c8xr; Thu, 2 Feb 2023 07:39:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6rJv5blDz3Bvf; Thu, 2 Feb 2023 07:39:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675323567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UEjy1IfXnpaY11dBwYR+aTxY4Mjcdk+U5W5jow3E1XA=; b=fZUzscmYDMFKXPXUDowbUnyNatVjSXLOO70T6JVACspPLaK8yWz0xhfyZNDtWJzwQH6v1Z HVIDzT+X/6cBAZYnBhjEKU3Q7TP3NFpDPJ5UUAOf6Cw5KUHA8Q3SwdwDxGAljYsuYuzWNz 3irwgG657pbapeFWiWPRc7PfnYcIJcUqGakAU6qMcnWoOoUCgubZ2fJes4PiyOTsmBH9dk ENGJCY2gioJyES2zDFVW39t1GdD9ro5eIpBfl10eAstk9JR1yxAqRr4fCOnoRN0LRDTg0o Oln1ruTrT2nBX50ov4DoMbxdzUX4mZnjJGOPcvLAyO+ss9eQPLGXaFQoplVfWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675323567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UEjy1IfXnpaY11dBwYR+aTxY4Mjcdk+U5W5jow3E1XA=; b=VOnVF6tQ99vO5L9fpWEnwSdBG9KH+X39Ft629uPAssmfBWrGG6g4fKeRC71wnIsiF+k8/Y XMXFIlhKWUv6GPQJuTH3Z4kMCTISWbrcU/zQbWEnnOUqfcKq+uo7vBdJGPsgI77InK9QQi wCROJaKdSznETfXSIZo5f9yHD2PiEaCOuVj+E1dnSjgysq5cVxGSiuDeXp4fvoZSvDPlnW D50GRJbwtKI1x0kOHWWBlJFH+B6nvc7N1AbH3OkUihYgHDC9XoCX5LyKygUMi0Lmxw1A0b g9Fg6KYX5PSnup9Xx6J4ayVZgEJNslvphn4jlMb9u2diSPbeOXrp2qly07x3xw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675323567; a=rsa-sha256; cv=none; b=ZHCfdttV3DQ0CZfEDz0nnbK3kJaMpXz6Jwi2n9caFoZbDD0r5Y3hSzkK+DK5qlUlcK7D3I cBksEWqwvxjHOHUDA+floH31gThBp8ZaV+UbayZ0s6CScapuyih5c8TdKxmm3PjXv3MEq4 9HIQc/TvXnPl8YewvFZoq96QuTfE33x2ZYWqgvF6bvf0Okb278wuJF9a69m5mINnApy7Gi eASwUFqpszrm3QRpnWov2OygAaoPQ//TPTIPfVH7k57lzlhmuJ/gu8GU90VZyA599UXXd/ 3vP+kC8hsp9wGv8LIZlrE1y4ao1S/vVqj5vqRWQeFJMLlc1IskvexsQ9EfxoYw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P6rJv4gTRzm4t; Thu, 2 Feb 2023 07:39:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 3127dRVN061931; Thu, 2 Feb 2023 07:39:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 3127dRl0061930; Thu, 2 Feb 2023 07:39:27 GMT (envelope-from git) Date: Thu, 2 Feb 2023 07:39:27 GMT Message-Id: <202302020739.3127dRl0061930@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: a7a9dbe2fee9 - stable/13 - cxgbe(4): Fix control flow issues reported by Coverity. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a7a9dbe2fee958090e8f76af42ce664e5a489446 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=a7a9dbe2fee958090e8f76af42ce664e5a489446 commit a7a9dbe2fee958090e8f76af42ce664e5a489446 Author: Navdeep Parhar AuthorDate: 2022-04-14 07:17:36 +0000 Commit: Navdeep Parhar CommitDate: 2023-02-02 07:12:41 +0000 cxgbe(4): Fix control flow issues reported by Coverity. CID 1487932: Control flow issues (NESTING_INDENT_MISMATCH). The macro on this line expands into multiple statements, only the first of which is nested within the preceding parent while the rest are not. 9828 ulp_region(RX_TLS_KEY); Reported by: Coverity (CID 1487932) Fixes: f88b31885c4 cxgbe(4): meminfo should get the TLS region's limits from the hardware. Sponsored by: Chelsio Communications (cherry picked from commit 239170f29210a21a68284dc967e57ed8047fb2ba) --- sys/dev/cxgbe/t4_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index fd98cdc76299..0ec1dc54bdd4 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9977,8 +9977,9 @@ sysctl_meminfo(SYSCTL_HANDLER_ARGS) ulp_region(RX_RQUDP); ulp_region(RX_PBL); ulp_region(TX_PBL); - if (sc->cryptocaps & FW_CAPS_CONFIG_TLSKEYS) + if (sc->cryptocaps & FW_CAPS_CONFIG_TLSKEYS) { ulp_region(RX_TLS_KEY); + } #undef ulp_region md->base = 0;