From nobody Thu Feb 02 06:57:14 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6qNC0B2tz3c4Md; Thu, 2 Feb 2023 06:57:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6qNB6plJz4Lhw; Thu, 2 Feb 2023 06:57:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675321035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W8N0XnIQCe4twzR1oDkJ5uPQ7O1MYM5ZLknak69ySgI=; b=MTzJPDtQdCPHxhB6QQ3QqlIHNlBGpHMCu6Cygnd3wR1JCUFiu4qpxtMYTznF92xhwe4VmG bdbzlqNPk1zJwwSO1yMQ9xdaCzPWL6HCcnvqR8F6YFYlMfs2gNxjtOzCfgXt99szyi7pec 8rUPCPh4HQnb68iQ36HERQavIck+TaJF2ghQUwV+8lDegswSalMLATqvm4F+unmiCaFaxv UZsshnvoQkrdhW3clu9BHNmX/ZVhYxxm5XJ/t5bfSPLQqK9eMe7cDbRIvKx77LMtVDBlki o8E05rY5EzJeuhmPQd5fdAK0T9lkhHlq90o8VH+qzv9hKxoITD7mxdEB/tf8Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675321035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W8N0XnIQCe4twzR1oDkJ5uPQ7O1MYM5ZLknak69ySgI=; b=XC5VH9l7YpDnAY17I8EoBRNrCQz7Iri/ajKf7D3AIIA0kh7lMCimezjXvvQzVYf+p0rSBK ek8pBcF+H0cqpvj2vY/tjOww1jiRWPOye4k8Oa++g8F1HxK0jW37W/Wob42QXv93bon028 mbPLSVtu46ELxzl5eLTCpM63DHcd7qgYiJgac7EYBbD6ejXNsoPcaHBW4K1BUHLGF/h2qW UleaS/RhQDRCVyNlijGB+5J40mpnFrIAwGIV2GHr2TPfKZWA2M7FCriwi/VYvE2P786W2V Ou2aZ/A5cJQndgFwjyDigvhX/cU6wlsJFv2C9kEYaKy8WpjL/m4z2D3ucK2DKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675321035; a=rsa-sha256; cv=none; b=NQCurS+PMN7rPXO63xotCPwSTXfXYGYzEOowjUexUpzjOB8HwBQ6bFGO8vac8mHy1dqabC QtrEeKRZyVezdOixi+w7pkpWkBnsRLtdnXVDoHQ04tFPu0coC8+dFJCovFxe8rHzSeLAYm NQfDK3kWcB69Wsp2QvQ7JNi5qCu2Wg+rSnGyYc2hPZS3J3WB7fItv8GxHw7J0dso0mcjEY jLzqAa1P1U0PkKRoU1fnc/Utc5P0a5j8EOksozDDpiAWErG4Knhe33TYFTatbhn1sN9z8L 8xx7P+6Pl2dGRb2RLrFcquIz1YjC3RFMu1QnMjnbbaH6T8DnADatC4kzpmR7+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P6qNB5P6zzlr1; Thu, 2 Feb 2023 06:57:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 3126vED8003689; Thu, 2 Feb 2023 06:57:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 3126vECA003688; Thu, 2 Feb 2023 06:57:14 GMT (envelope-from git) Date: Thu, 2 Feb 2023 06:57:14 GMT Message-Id: <202302020657.3126vECA003688@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Emmanuel Vadot Subject: git: a829b880ea23 - stable/13 - sdio: Always use increment address for read/write_4 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a829b880ea234aa84843a9f3922053b61b42c990 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=a829b880ea234aa84843a9f3922053b61b42c990 commit a829b880ea234aa84843a9f3922053b61b42c990 Author: Emmanuel Vadot AuthorDate: 2021-05-21 11:33:34 +0000 Commit: Emmanuel Vadot CommitDate: 2023-02-02 06:47:33 +0000 sdio: Always use increment address for read/write_4 SDIO CMD53 (RW Extented) can either write to the same address (useful for FIFO) or auto increment the destination address (to write to multiple registers). It is more logical to have read/write_4 to use incremental mode and make other helper function for writing to a FIFO destination especially since most FIFO write/read will be 8bits based and not 32bits based. (cherry picked from commit 1ee7a8049218e6dc0a520e6e298626d11d254a2b) --- sys/dev/sdio/sdio_subr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/sdio/sdio_subr.c b/sys/dev/sdio/sdio_subr.c index e2a6573abc6f..67703f88bf27 100644 --- a/sys/dev/sdio/sdio_subr.c +++ b/sys/dev/sdio/sdio_subr.c @@ -173,7 +173,7 @@ sdio_readl(struct sdio_func *f, uint32_t addr, int *err) uint32_t v; error = SDIO_READ_EXTENDED(device_get_parent(f->dev), f->fn, addr, - sizeof(v), (uint8_t *)&v, false); + sizeof(v), (uint8_t *)&v, true); if (error) { if (err != NULL) *err = error; @@ -191,7 +191,7 @@ sdio_writel(struct sdio_func *f, uint32_t val, uint32_t addr, int *err) int error; error = SDIO_WRITE_EXTENDED(device_get_parent(f->dev), f->fn, addr, - sizeof(val), (uint8_t *)&val, false); + sizeof(val), (uint8_t *)&val, true); if (err != NULL) *err = error; }