From nobody Wed Feb 01 22:30:07 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6c736f4jz3cCN4; Wed, 1 Feb 2023 22:30:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6c7369YZz4HFp; Wed, 1 Feb 2023 22:30:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675290607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Pdr5Ft3Nt0eR7uvqdWK0CjTYsWLPyzPWLkP+7CUpLUM=; b=C0v3nMPSIFfOblMLZ9UC+C7of77vrW0OtbtBzk0ELQkkhuAvWTLnemZzOgyLgWJHNFEV1P 9YioTBPLTl6eh1VUWCrVA8iY58TP7pN2W06rZzO/9SSHW9RsIN01EvWGZrKa0t4Rh5M9o5 YrKMuwrKfpF09Lz4e7pjKo4ZbXl+e1TA+Lqs0CM2af7VIyC1OXRQr7LBoZG172rfQgiEZY W5E9sC0V98T7LVgHKsG0sRneGVbRtGnQ1BEL1O4xzjmd0xz9d4Bk4kyosC++/DYl4/dc/+ I+/iCd5nqABokFZCiiKtvQGXXxqKf9ToOURCc00fS4L15YzsIO8j9wF74l2cKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675290607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Pdr5Ft3Nt0eR7uvqdWK0CjTYsWLPyzPWLkP+7CUpLUM=; b=eg7pISA7PANPcHwUt8eBeWqMHxWYvfkC8K/tlYI27r19aM4AdYDlLP/Kwa6xDvVbgWF93Y lwXuMQ6+2wL0LieWqT5tlSwbcRVADDskXvCwLw7N9YPGTMPs4wH0J0hdNnikH+9sOeHhoq Jgz46opdftQmsx9VEPXIT/0GUbTxuo2F+zfYKu3O9Zv6lE4rQIQ2nZe+eBPEYzJppTxPpm WklsRoguHZJ6mMqYbxmjMf/hMLfJyTqAWJq9w+ykfLV4r/vqtEvebXSJrs6Ox8Ee4oSHUG 4VmcvhiyUpYTme0sbZx3IpV4B7NFdzXiX4nITpGVC6Pvn/T3Gc3c4+iY0hiUsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675290607; a=rsa-sha256; cv=none; b=FXLVOYV1YQoID+/5Lvte1TfpSU8NQPRub5/yaVOYMm5gp6bm+Xdr4BQczwHCmU8odIBv3e yldsw3VTpJRNpFH5rYv9Ry9/Te/wM350cFSABDFUlzZPv3R9nIhTaP5e3UxmjP6oluXEfi 4dnWyg4gKzrG7sTFXax6R/U0qhciO1+i36Ss8QJy5IYfpD3zTA73OG3b01fzfxv32Sxp7x AFLFEjX07RwXyN0hSCFnwAsyKM7kPE3WPMogRxnAVgY2Z9s3Nk5B3QV8MmIj3qSdZgUQ0N eJyGnbYlg5jsju3uLrYR7AfKEtrdqbv//kh2M+Fe5fmCDEI0Cy28z8USSegNTw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P6c735DLpzWFC; Wed, 1 Feb 2023 22:30:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 311MU7ND075889; Wed, 1 Feb 2023 22:30:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 311MU7bO075884; Wed, 1 Feb 2023 22:30:07 GMT (envelope-from git) Date: Wed, 1 Feb 2023 22:30:07 GMT Message-Id: <202302012230.311MU7bO075884@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 249626cfd805 - stable/13 - sctp: remove a test, which isn't safe List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 249626cfd805e42eacd7c892d50b2bf88fc1c4b6 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=249626cfd805e42eacd7c892d50b2bf88fc1c4b6 commit 249626cfd805e42eacd7c892d50b2bf88fc1c4b6 Author: Michael Tuexen AuthorDate: 2022-04-02 13:09:50 +0000 Commit: Michael Tuexen CommitDate: 2023-02-01 22:29:43 +0000 sctp: remove a test, which isn't safe We can't ensure the stcb is still around. This issue was found by syzkaller. (cherry picked from commit 0f316316200386986de7ac72cf717c13b28f387e) --- sys/netinet/sctp_output.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/netinet/sctp_output.c b/sys/netinet/sctp_output.c index 39a6140fd36c..d0cebba4335b 100644 --- a/sys/netinet/sctp_output.c +++ b/sys/netinet/sctp_output.c @@ -13655,11 +13655,6 @@ out_unlocked: if (free_cnt_applied) { atomic_subtract_int(&asoc->refcnt, 1); } -#ifdef INVARIANTS - if (mtx_owned(&stcb->tcb_mtx)) { - panic("Leaving with tcb mtx owned?"); - } -#endif } if (top != NULL) { sctp_m_freem(top);