From nobody Tue Dec 19 17:40:26 2023
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SvkVp21MGz54ccK;
	Tue, 19 Dec 2023 17:40:34 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Received: from glebi.us (glebi.us [162.251.186.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 4SvkVn3fwgz4NGd;
	Tue, 19 Dec 2023 17:40:33 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Authentication-Results: mx1.freebsd.org;
	none
Received: by glebi.us (Postfix, from userid 1000)
	id 1EA75552FA; Tue, 19 Dec 2023 09:40:26 -0800 (PST)
Date: Tue, 19 Dec 2023 09:40:26 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: Kristof Provost <kp@freebsd.org>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
	dev-commits-src-main@freebsd.org
Subject: Re: git: ec6682ed6c1d - main - atf.test: fix installation of python
 test scripts
Message-ID: <ZYHViuhqAe3IRxoQ@FreeBSD.org>
References: <202312191624.3BJGO8wt015058@gitrepo.freebsd.org>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202312191624.3BJGO8wt015058@gitrepo.freebsd.org>
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]
X-Spamd-Bar: ----
X-Rspamd-Queue-Id: 4SvkVn3fwgz4NGd

  Kristof,

On Tue, Dec 19, 2023 at 04:24:08PM +0000, Kristof Provost wrote:
K> commit ec6682ed6c1d7304521bad39a1ad7ceae76aaca3
K> Author:     Kristof Provost <kp@FreeBSD.org>
K> AuthorDate: 2023-12-19 13:15:48 +0000
K> Commit:     Kristof Provost <kp@FreeBSD.org>
K> CommitDate: 2023-12-19 16:23:54 +0000
K> 
K>     atf.test: fix installation of python test scripts
K>     
K>     Python test scripts get processed (to add the `#! /usr/libexec/
K>     atf_pytest_wrapper` shebang line), into a .xtmp file, and installed from
K>     there. However, as there was no dependency of this .xtmp file on the
K>     original file we kept reinstalling the .xtmp file, even if the original
K>     had been edited already.
K>     
K>     This could cause great confusion when debugging python test scripts.

Oh, that gave me a lot confusion and several times. I even attempted to fix it,
but messed up due to bad make(1) skills. Thanks for fixing!

--
Gleb Smirnoff