From nobody Tue Aug 22 21:07:32 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVhkd1Dqnz4qSTL; Tue, 22 Aug 2023 21:07:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVhkd0kSnz4KHy; Tue, 22 Aug 2023 21:07:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692738457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lU+/b7GGav8FZteBVWLqA4YvEvsT0GToUysoQVFsq7E=; b=Mv3cPg0qfojs8vxI2GuGyJUFebSEf30v0O5As5Oc0ioIYMyy2fWQF/wXLQ4Z0xhPE1AqW7 btnZVOUIbcAZ60qQbg9sTB/QeF5y4jSafBlg+qjcdqoiTUjLaNzH5L+D5ZVUWaSHsfCqE3 1kR+qetUUjPFCknZ9bde4zz2L1yijcaPw9jlc1vV6x2774WS4pcVzYBQJpvBhWbBhCp8No zP9KESoIEAV/yKBV/xKwEp/+nRNGhm2zajowvN2UJ5UB66/zPzSVIitvKvHcC08A+xKazX hZ1Lyrn8yugDH4lLbUNfEXrSnAFIdGwDZ4FD98CFMxlRU4Cxn1ohboIY07TQ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692738457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lU+/b7GGav8FZteBVWLqA4YvEvsT0GToUysoQVFsq7E=; b=SLY4YaCOIkTCK2ycS1zXbqT+nY9hdrRuiPGz8futL63O8Ci9ptMiFMHCv+DLG1ytcgSvQg TXSu0RvrS5/pvIv2xnBBNhjSWmD2Q2Ri+lzE2T5WAAcbwSulaXO6bN3Geud5ZII7AeQvYC jT/LmiXR6QGE2UGVxRPksbVy4NjO0a0UMgAD/+eaKIhwdRSgsLofBDc/ljkKYjPOSh5iqe OjxaqAlOrnAysrYjb0wfjkheXg02JmXCWGe7Ph9wFQPj+d3G5FC+TNgGrHj+SSegCThrFA ZUnDaZAY5X7MWWCspuNAERdv+loFihGliiXZIek921YnAIxEU/vmFCZgMG2cOw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692738457; a=rsa-sha256; cv=none; b=FJIId9RvEbdJdtZHUyd8B1/u06Nyjb3k/TDKrnD9d7J3QyMTarUZsy0Fprun9s7Om78xsn 12ZPoU/e9l2/J1eJ11Iw96vHamhh8m8JUzMdKqNIrtPh9jhOBuXh62xvoSxUn/jAWL+fRa IFIqVXYe4BzfKmN8cyNAz8y8jXJoZwWbYlpyI0nRMZ9MDn/GF7rzNIG++uUvrwbuOV2YPF hXZozcIp6wna5td9cqUAQ93qLMesgXU+2wSJM3KiONmNaDwEydHj27B8BANZ+YhT8E/Ydl +TjwwDLVJ3KknhmL9G3+bhwiqx5tKoTzHC+JDXjxwbmnqkACf4QvC5NrD61Khg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RVhkc5Zn0z19rX; Tue, 22 Aug 2023 21:07:36 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id BEBEF4D40D; Tue, 22 Aug 2023 23:07:33 +0200 (CEST) From: Kristof Provost To: Warner Losh , Sumit Saxena Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Date: Tue, 22 Aug 2023 23:07:32 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> In-Reply-To: <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_FC533F11-A875-4AC6-843D-E98CF46C9FF7_=" --=_MailMate_FC533F11-A875-4AC6-843D-E98CF46C9FF7_= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 27 Jun 2023, at 11:17, Kristof Provost wrote: > On 4 Nov 2022, at 23:55, Warner Losh wrote: >> The branch main has been updated by imp: >> >> URL: = >> https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc786102= 0dc3a2a2d717 >> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >> Author: Sumit Saxena >> AuthorDate: 2022-11-04 22:24:32 +0000 >> Commit: Warner Losh >> CommitDate: 2022-11-04 22:24:32 +0000 >> >> if_bnxt: Add support for VLAN on Thor >> >> Reviewed by: imp >> Differential Revision: https://reviews.freebsd.org/D36443 >> --- >> sys/dev/bnxt/bnxt.h | 3 +- >> sys/dev/bnxt/bnxt_hwrm.c | 110 = >> ++++++++++++++++++++++++++++------------------- >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >> sys/dev/bnxt/if_bnxt.c | 7 ++- >> 4 files changed, 74 insertions(+), 53 deletions(-) >> > > This commit appears to have broken vlan on these interfaces. > My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in = > a Dell T640, if that helps). > > A simple vlan creation on top of one: > ifconfig vlan create > ifconfig vlan0 vlan 201 vlandev bnxt0 > > Results in a loss of connectivity. The kernel logs this, which I = > assume is related: > > `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS = > error.` > > > After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I = > can create vlan interfaces on top of bnxt0 without losing = > connectivity. > Should we revert this before 14.0? There=E2=80=99s also a report of what I think is the same issue in = [https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133](https://bugs= =2Efreebsd.org/bugzilla/show_bug.cgi?id=3D269133) There=E2=80=99s a proposed patch there, but it did not work for me. Best regards, Kristof --=_MailMate_FC533F11-A875-4AC6-843D-E98CF46C9FF7_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 27 Jun 2023, at 11:17, Kristof Provost wrote:

On 4 Nov 2022, at 23:55, Warner Los= h wrote:

The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D91fcacc355971f74aa26fc7861020dc3a2a2d717

commit 91fcacc355971f74aa26fc7861020dc3a2a2d717
Author: Sumit Saxena <sumit.saxena@broadcom.com>
AuthorDate: 2022-11-04 22:24:32 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-11-04 22:24:32 +0000

if_bnxt: Add support for VLAN on Thor

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36443
---
sys/dev/bnxt/bnxt.h | 3 +-
sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------------= ------
sys/dev/bnxt/bnxt_hwrm.h | 7 ++-
sys/dev/bnxt/if_bnxt.c | 7 ++-
4 files changed, 74 insertions(+), 53 deletions(-)

This commit appears to have broken vlan on t= hese interfaces.
My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a = Dell T640, if that helps).

A simple vlan creation on top of one:
ifconfig vlan create
ifconfig vlan0 vlan 201 vlandev bnxt0

Results in a loss of connectivity. The kernel logs this, = which I assume is related:

`bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID= _PARAMS error.`

After reverting this (and 72e9dbb58cad5262190cf2eae47f764= 021072128) I can create vlan interfaces on top of bnxt0 without losing co= nnectivity.


Should we revert this before 14.0?

There=E2=80=99s also a report of what I think is the same= issue in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133

There=E2=80=99s a proposed patch there, but it did not wo= rk for me.

Best regards,
Kristof

--=_MailMate_FC533F11-A875-4AC6-843D-E98CF46C9FF7_=--