From nobody Fri Aug 18 15:47:05 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RS5pq2JlWz4qhjj; Fri, 18 Aug 2023 15:47:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RS5pq0SjLz3HZ3; Fri, 18 Aug 2023 15:47:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 37IFl52o085299 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 18 Aug 2023 18:47:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 37IFl52o085299 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 37IFl5iM085298; Fri, 18 Aug 2023 18:47:05 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 18 Aug 2023 18:47:05 +0300 From: Konstantin Belousov To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1384a0b940e8 - main - kern/subr_unit.c: fix non-debug build Message-ID: References: <202308181337.37IDbMwl051912@gitrepo.freebsd.org> <20230818144345.9998F2EF@slippy.cwsent.com> <20230818153955.143512F3@slippy.cwsent.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818153955.143512F3@slippy.cwsent.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4RS5pq0SjLz3HZ3 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] On Fri, Aug 18, 2023 at 08:39:54AM -0700, Cy Schubert wrote: > In message , Konstantin Belousov writes: > > On Fri, Aug 18, 2023 at 07:43:45AM -0700, Cy Schubert wrote: > > > In message <202308181337.37IDbMwl051912@gitrepo.freebsd.org>, Konstantin > > > Belous > > > ov writes: > > > > The branch main has been updated by kib: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1384a0b940e87876d36d50ad5858 > > 1c24 > > > > dc642714 > > > > > > > > commit 1384a0b940e87876d36d50ad58581c24dc642714 > > > > Author: Konstantin Belousov > > > > AuthorDate: 2023-08-18 13:36:06 +0000 > > > > Commit: Konstantin Belousov > > > > CommitDate: 2023-08-18 13:37:16 +0000 > > > > > > > > kern/subr_unit.c: fix non-debug build > > > > > > > > Sponsored by: The FreeBSD Foundation > > > > MFC after: 1 week > > > > --- > > > > sys/kern/subr_unit.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/sys/kern/subr_unit.c b/sys/kern/subr_unit.c > > > > index 3d45a0c1c5cb..7a23f216d98e 100644 > > > > --- a/sys/kern/subr_unit.c > > > > +++ b/sys/kern/subr_unit.c > > > > @@ -353,7 +353,7 @@ check_unrhdr(struct unrhdr *uh, int line) > > > > struct unr *up; > > > > struct unrb *ub; > > > > int w; > > > > - u_int y, z; > > > > + u_int y __diagused, z __diagused; > > > > > > It still doesn't like it. > > How do you build it? > > Is it kernel? If yes, which kernel config? > > It's not in kernel. It's in tests. I see. Could you quickly check if this patch is enough? I just started buildworld. commit 5e2dee9953a68344bdf1090b672bd9b04ae8f09f Author: Konstantin Belousov Date: Fri Aug 18 18:42:59 2023 +0300 subr_unit.c: another attempt to fix the build Sponsored by: The FreeBSD Foundation MFC after: 1 week diff --git a/sys/kern/subr_unit.c b/sys/kern/subr_unit.c index 7a23f216d98e..6826678104d6 100644 --- a/sys/kern/subr_unit.c +++ b/sys/kern/subr_unit.c @@ -340,6 +340,10 @@ free_iter_unr(void *handle) } #if defined(DIAGNOSTIC) || !defined(_KERNEL) +#ifndef __diagused +#define __diagused +#endif + /* * Consistency check function. *