From nobody Tue Aug 08 17:49:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RL10y5bGgz4psyy; Tue, 8 Aug 2023 17:49:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RL10y5781z4SrS; Tue, 8 Aug 2023 17:49:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691516994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PELvneb5RXObUp7c/NMciF/1pSjVjSyIXpGj+oslSKs=; b=izFojJbtrTm4TpeRyqtBurxyUe4NUdS78yP7pDjF0MzCYru247JbVr1Fois+CCbbIUh5kg NanvhgvKe7otwkCv0AxuPL4u8MabqQTJdeWfr5mgVkCJHNBSnFkXB/pwIneYuqganiKfwp F19chAwo0ILpmWOPbN3s9JoYonZ8ow6dCp3Eox5qVBIUohGzgse/cRs91NEgtLZzOcT0kR fVubwHqK5idzKqngRpwM5uJsys1rd1DbE92RCoHYoBpmMYCgxM8OY9c16MNuGsJycui/Gj bNhQo8viu/j8T2jGRfb2mK6RMiCjCxRdMV0hPwS3PQUKbDLmlsunEvHXEiMbKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691516994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PELvneb5RXObUp7c/NMciF/1pSjVjSyIXpGj+oslSKs=; b=KjaP887pFxpRikp1FR7X+iF3kTvoA+0KtvVTl3KAU1uYy6ATRLHebo4de/jYPiDEFAecpf D+8TZjaLlWncnV2+knikdwRo6/EXbifjSECBmqOd4q0P3TEMlzjDJ7r2IQ1NLeWfi6NBh/ JgGAXd4zayLzPqaDE7U5GfFWlb1QjsITtKyjni015NVE9BqgLzcBtZn7QndDdz4hABGK3X D/iLgg4KfpLyPjWamBCKhNL8zb4t3az1ZPSMW4yZurgPCzo5ZhHg2EWl2YFJMo8JCxBEVQ OXVTpLlVuqa1mob6byuTPdyjCLp2UBHRmRbOdKdC13oEEaj3V5x0deURxz6Lgg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691516994; a=rsa-sha256; cv=none; b=E3zVlP7PWMJrX+nN/0jPilqzn8NjSZzP12Zz5NOYGV80y/mLeJc1QqCz7L3hptboFGh35P LVTX6aBaWzQqDU/Hj59AB6sfMaql/rbfvOtoKjaS8bx3QoHccke8FUN0Pf/ZJOolMDn9R6 eH8j8Dvox5seYY+z7en4uyH0BJJR8d4gwtxZLpryv5HKeuIoJ2MgmQ6rYS6iMSRaNMpCqN 2tj/GIal6pJRTsCRzZRJjpJvbx0S2wcBtiAEPp4cb+TYB7ZX0U/8psC5ko+FX/Ht6HgkQE hlonkKJTCpXOyFewmZ5MporAIIiVb9/iI1ibxVC4NpvdyjX91mLAZdSf1PmYvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RL10y3qFKzjB0; Tue, 8 Aug 2023 17:49:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 378HnsgC057069; Tue, 8 Aug 2023 17:49:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 378Hnspq057068; Tue, 8 Aug 2023 17:49:54 GMT (envelope-from git) Date: Tue, 8 Aug 2023 17:49:54 GMT Message-Id: <202308081749.378Hnspq057068@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 09c20a293280 - main - nvme: Move bools to fill hole List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 09c20a293280eaed9b4342e08112089f449fd605 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=09c20a293280eaed9b4342e08112089f449fd605 commit 09c20a293280eaed9b4342e08112089f449fd605 Author: Warner Losh AuthorDate: 2023-08-08 16:55:43 +0000 Commit: Warner Losh CommitDate: 2023-08-08 17:44:51 +0000 nvme: Move bools to fill hole The two bools in nvme_request create a 6 byte hole today. Move them to after retires to fill the 4 byte hole there and add a spare[2] to make nvme_request 8 bytes smaller. spare[2] isn't strictly necessary, but documents how many bytes we have left in that hole, as the number of booleans will increase shortly. Suggested by: chuck Sponsored by: Netflix --- sys/dev/nvme/nvme_private.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/nvme/nvme_private.h b/sys/dev/nvme/nvme_private.h index 9d82c8fba69c..b35e14cb8d0c 100644 --- a/sys/dev/nvme/nvme_private.h +++ b/sys/dev/nvme/nvme_private.h @@ -119,11 +119,12 @@ struct nvme_request { struct nvme_command cmd; struct nvme_qpair *qpair; struct memdesc payload; - bool payload_valid; - bool timeout; nvme_cb_fn_t cb_fn; void *cb_arg; int32_t retries; + bool payload_valid; + bool timeout; + bool spare[2]; /* Future use */ STAILQ_ENTRY(nvme_request) stailq; };