From nobody Sat Aug 05 11:38:57 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RJ0wh0Xq4z4gvf6; Sat, 5 Aug 2023 11:39:16 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RJ0wh00Lcz3KZG; Sat, 5 Aug 2023 11:39:16 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691235556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/GIphF9gCvoWjFeESWaRojmK02zK/iKxkeR4utTJeM=; b=Z3PS+h/ZMpql7QrtP19lcHsGXft73TAXkaN4FLFWtSHS18ibJBmF9YyXVGly13CiNCCm+d W+Njmabkb3F3XyIfFr7PR0Q+Z7qNYIyvZluCNSnmd9ZBrl+1L/AzfRtvQho/AdRvpIIhJ8 bE4izgWHBhG0IeEhjV76kXdWMNdGFZRvWMuGOCvp2z4yo0ymGmPUYcs3RQ1L874Vjk+51B QjDdGAn/QEuF9krIfcLX22yWGC0V7q25VAk+EWuQM6VqEPRqfJhpHtZbNkQZjOl5gt52i2 JksU10I3ldjSNdPMLhRfnsBAk7DVWmWgtcyAd6eTvsGqKLqA8vS3yz/J9bdKwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691235556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/GIphF9gCvoWjFeESWaRojmK02zK/iKxkeR4utTJeM=; b=tKIJdZhr2BoZwxjK65QTmj+M9HpZ8xibPqdsRZWRWa+kX5bud5P1o3jACMEXzSqiNIIkCD f7OJ29fT3q3VA4mIJvnVyh7C9N+fI//PBL1ZkPqRO8yQfAjdsZNGjtXibA8hsVIyVxuJHO 3e5hxmWVUrtvtD0j5fF7bbIULDf6/Z6B25fVVhFt293207TIwUW4pfWzLvbBi1xhzNyOCa SKG1K7a3O2IOtMDB75isijcoQWd11kY84TOg0dKIG3mSUkBfkndrU0fqlRyhv0fNehj9RB dZF4A2WFaRgiHXfW30FNPvvPeHdnXkjjYKNf2bl3CqFS2096tlwHUobAtkVpUA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691235556; a=rsa-sha256; cv=none; b=S870jAa9sv5BWtgUJQ29y/XZJiUPQRF/IggDo/nI3zZu/h2sQV2ySAzfoks+1W3r5hS6nd V9+4SswtwaHXS74yAcefYhTS1H+TEqOAvkaXG1naCll8sKb9u4fyvOcV6sddBkajWRcxVN bA9mDUt7Yw4CXpzAFXSjfdt8f5Z3Xt14DxZ99jHbSD+vBZL4hNF5OmeSRaMlKj0V++CZYA LVNcvxws9+pQIjpQBdm2waYKPdly3peHyCotbdiHssWOTsxqI9RGd2RTGhSA/kqeKLxFzv hHqr6jUu/ZtW//phTs03H3gflwAdF0cGv6R8jV7PPJomVlQsy/TMSks5T/vugw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RJ0wg5Gbyz1Q56; Sat, 5 Aug 2023 11:39:15 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id DA354728CC; Sat, 5 Aug 2023 13:39:13 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_7F86D804-E676-4B7B-AD56-F2673A9670B9"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: git: dedc71fd3890 - main - libc: unsplit log message to to make it greppable in src From: Dimitry Andric In-Reply-To: Date: Sat, 5 Aug 2023 13:38:57 +0200 Cc: Ed Maste , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: References: <202308050100.37510VDJ085555@gitrepo.freebsd.org> To: Jessica Clarke X-Mailer: Apple Mail (2.3731.700.6) --Apple-Mail=_7F86D804-E676-4B7B-AD56-F2673A9670B9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 5 Aug 2023, at 04:11, Jessica Clarke wrote: >=20 > On 5 Aug 2023, at 02:00, Ed Maste wrote: >>=20 >> The branch main has been updated by emaste: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Ddedc71fd3890803a81047a0c480b95a3= 27bd7214 >>=20 >> commit dedc71fd3890803a81047a0c480b95a327bd7214 >> Author: Ed Maste >> AuthorDate: 2023-04-17 15:58:59 +0000 >> Commit: Ed Maste >> CommitDate: 2023-08-05 00:59:30 +0000 >>=20 >> libc: unsplit log message to to make it greppable in src >>=20 >> Also use __func__ rather than hardcoding the function name. This = code >> now fits in 80 columns without splitting the log message. >=20 > This doesn=E2=80=99t match the commit? Indeed, during the review I noted that __func__ would not expand to the expected value ("__cxa_thread_call_dtors"), so that part was actually removed. Now the effective result only unsplits the message line. I guess this is a case of Phabricator or arc making it difficult to adjust the commit message before 'landing'. -Dimitry --Apple-Mail=_7F86D804-E676-4B7B-AD56-F2673A9670B9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZM400QAKCRCwXqMKLiCW o39JAJ9EbyMcsluqu4nIMybrzAHxfyCBDwCeKM0EwjhFmX3sIgmr1+fLVKNgGwg= =Q+rD -----END PGP SIGNATURE----- --Apple-Mail=_7F86D804-E676-4B7B-AD56-F2673A9670B9--