From nobody Fri Aug 04 13:03:50 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RHQrn3psfz4kQrT; Fri, 4 Aug 2023 13:03:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RHQrn3KYxz4bp4; Fri, 4 Aug 2023 13:03:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691154233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ldphx5e8uJ/6Tz6B4ioXFO/bISRF1SG4Fy6JjbNdhkY=; b=snqbhsezH3RzaP/+jF483XhrysnQM7nkuIm+uOeR9D0DUd8iUrZUCjvrQOFdh6b/nO/7F7 8bqWBoGNtvDvNNn5jyo9TNO0SEUNFsag5LYuCaTvftT+NbIk8vOpMnPjzxfBk6CUnESwqm mN/48YzW60LnOKP3fV0mNXZz0RrcxXHhwhTcqKvlj1L5H6mzF5P3oWn0BfOhzRoN2qJ0ei Gt6/jGxb/tuqTQrIMwv43cybebjzB3MdbU+a/DDRoh2xEXspnSUnTlrtavp5PVplRDoi8j MqBDM2IouaCFIzlHT6kIO2ilr8tHe965fO385R0lPDXhaJoib0u/96PnJb9kjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691154233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ldphx5e8uJ/6Tz6B4ioXFO/bISRF1SG4Fy6JjbNdhkY=; b=pOIEZ92X96UmS2FxMNc6hZDoqfRXeoHFnBtJu/cO+PgwEgx4/+/0sHwcr07WdNioQi6h+y LdE8hT6udVgfK9JDDYebNAGwn6281RrDvLDSCE6+nlHKj9igg+Ea9OtyikHUA9RX6Ybd0z fBjcHg9IMJ98OLFq2rOfWQ14tzVScRROkr0TW1Qy+6bytluyUe3ugNUSbBF+RYBdAl3lH2 ZL0QMKUWDeKEZg/wmA8uSKOqnKhcLg6vcJMrj9ylYeZMJbz76urJgP+FGK65WMfrT9dWde w4/enFkUlth53ffrlSnrUW5FjpQEwRMp80ffG6wJtsqtNPNsnkuoj1uYXUfCOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691154233; a=rsa-sha256; cv=none; b=nj3LdwsZnUqHetuN2FZbwtDokfT70+jvwxVim1DZSOIWMBlcwqNjtnd3gjqbDKyLU1rmAS tmstI2onv6v9fmf6CvURfYqbFGefwHojJG3LF/s/FywXZvwM3QEchPH41JSOm7Um9T8KKu H5ypIw4VEZQbFYD6xsO8QY3j5WhDde/bm0CG+HB5RLQostd6c6waFhefbU+axQX1+KdMW4 HQ7g69wtxZH3w60MMLYD67kiqfc8/gaWUEmSUFLa+MLrUFxumN+LjS3lnvetK7VaWJzEVh o8IDmz9UBiM514xg6lBO+k4evB7ZfMPSBhOtd2NkC2IVckuXuKVLibDpf5t9fQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RHQrn0qDkz11Kp; Fri, 4 Aug 2023 13:03:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 6D4AC50BDB; Fri, 4 Aug 2023 15:03:51 +0200 (CEST) From: Kristof Provost To: Michael Tuexen Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: b279e84a47dd - main - sctp: improve consistency Date: Fri, 04 Aug 2023 15:03:50 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <202307282203.36SM3C98056354@gitrepo.freebsd.org> References: <202307282203.36SM3C98056354@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_77BDF089-8206-4FA3-8412-9857890C3CAE_=" --=_MailMate_77BDF089-8206-4FA3-8412-9857890C3CAE_= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 29 Jul 2023, at 0:03, Michael Tuexen wrote: > The branch main has been updated by tuexen: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3Db279e84a47ddb59e55b5a3cec31c5= 1cd41bf0dc3 > > commit b279e84a47ddb59e55b5a3cec31c51cd41bf0dc3 > Author: Michael Tuexen > AuthorDate: 2023-07-28 12:36:11 +0000 > Commit: Michael Tuexen > CommitDate: 2023-07-28 12:36:11 +0000 > > sctp: improve consistency > > This is simplifying a patch to address PR 260116. > > PR: 260116 > MFC after: 1 week It looks like this commit (or maybe the next one, = c620788150d274c09a070ab486602c98407d73b0) causes a panic in the SCTP = code during the `sys/netpfil/pf/sctp:basic_v4` test: panic: Counter goes negative cpuid =3D 7 time =3D 1691145655 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame = 0xfffffe026ea9a3a0 vpanic() at vpanic+0x132/frame 0xfffffe026ea9a4d0 panic() at panic+0x43/frame 0xfffffe026ea9a530 sctp_abort_notification() at sctp_abort_notification/frame = 0xfffffe026ea9a540 sctp_express_handle_sack() at sctp_express_handle_sack+0x647/frame = 0xfffffe026ea9a640 sctp_process_control() at sctp_process_control+0xf62/frame = 0xfffffe026ea9a990 sctp_common_input_processing() at = sctp_common_input_processing+0x561/frame 0xfffffe026ea9ab10 sctp_input_with_port() at sctp_input_with_port+0x1fa/frame = 0xfffffe026ea9abe0 sctp_input() at sctp_input+0x10/frame 0xfffffe026ea9abf0 ip_input() at ip_input+0x2ab/frame 0xfffffe026ea9ac50 netisr_dispatch_src() at netisr_dispatch_src+0xad/frame = 0xfffffe026ea9acb0 ether_demux() at ether_demux+0x17a/frame 0xfffffe026ea9ace0 ether_nh_input() at ether_nh_input+0x39f/frame 0xfffffe026ea9ad30 netisr_dispatch_src() at netisr_dispatch_src+0xad/frame = 0xfffffe026ea9ad90 ether_input() at ether_input+0xd9/frame 0xfffffe026ea9adf0 epair_tx_start_deferred() at epair_tx_start_deferred+0xd7/frame = 0xfffffe026ea9ae40 taskqueue_run_locked() at taskqueue_run_locked+0xab/frame = 0xfffffe026ea9aec0 taskqueue_thread_loop() at taskqueue_thread_loop+0xd3/frame = 0xfffffe026ea9aef0 fork_exit() at fork_exit+0x82/frame 0xfffffe026ea9af30 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe026ea9af30 --- trap 0, rip =3D 0x35c39ec8bda0, rsp =3D 0, rbp =3D 0x35c39ec8ec90 --= - KDB: enter: panic That seems to be panicking during SCTP packet handling, so I do not = believe this to be a pf bug. Reverting both commits avoids the problem. It=E2=80=99s also failing during the CI tests: = https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/23957/consol= e (To reproduce, kldload pf sctp ; cd /usr/tests/sys/netpfil/pf ; sudo = kyua test sctp:basic_v4). Best regards, Kristof --=_MailMate_77BDF089-8206-4FA3-8412-9857890C3CAE_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 29 Jul 2023, at 0:03, Michael Tuexen wrote:

The branch main has been updated by= tuexen:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3Db279e84a47ddb59e55b5a3cec31c51cd41bf0dc3

commit b279e84a47ddb59e55b5a3cec31c51cd41bf0dc3
Author: Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2023-07-28 12:36:11 +0000
Commit: Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2023-07-28 12:36:11 +0000

sctp: improve consistency

This is simplifying a patch to address PR 260116.

=

PR: 260116
MFC after: 1 week

It looks like this commit (or maybe the next one, c620788= 150d274c09a070ab486602c98407d73b0) causes a panic in the SCTP code during= the sys/ne= tpfil/pf/sctp:basic_v4 test:

pa=
nic: Counter goes negative
cpuid =3D 7
time =3D 1691145655
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe026ea=
9a3a0
vpanic() at vpanic+0x132/frame 0xfffffe026ea9a4d0
panic() at panic+0x43/frame 0xfffffe026ea9a530
sctp_abort_notification() at sctp_abort_notification/frame 0xfffffe026ea9=
a540
sctp_express_handle_sack() at sctp_express_handle_sack+0x647/frame 0xffff=
fe026ea9a640
sctp_process_control() at sctp_process_control+0xf62/frame 0xfffffe026ea9=
a990
sctp_common_input_processing() at sctp_common_input_processing+0x561/fram=
e 0xfffffe026ea9ab10
sctp_input_with_port() at sctp_input_with_port+0x1fa/frame 0xfffffe026ea9=
abe0
sctp_input() at sctp_input+0x10/frame 0xfffffe026ea9abf0
ip_input() at ip_input+0x2ab/frame 0xfffffe026ea9ac50
netisr_dispatch_src() at netisr_dispatch_src+0xad/frame 0xfffffe026ea9acb=
0
ether_demux() at ether_demux+0x17a/frame 0xfffffe026ea9ace0
ether_nh_input() at ether_nh_input+0x39f/frame 0xfffffe026ea9ad30
netisr_dispatch_src() at netisr_dispatch_src+0xad/frame 0xfffffe026ea9ad9=
0
ether_input() at ether_input+0xd9/frame 0xfffffe026ea9adf0
epair_tx_start_deferred() at epair_tx_start_deferred+0xd7/frame 0xfffffe0=
26ea9ae40
taskqueue_run_locked() at taskqueue_run_locked+0xab/frame 0xfffffe026ea9a=
ec0
taskqueue_thread_loop() at taskqueue_thread_loop+0xd3/frame 0xfffffe026ea=
9aef0
fork_exit() at fork_exit+0x82/frame 0xfffffe026ea9af30
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe026ea9af30
--- trap 0, rip =3D 0x35c39ec8bda0, rsp =3D 0, rbp =3D 0x35c39ec8ec90 ---=

KDB: enter: panic

That seems to be panicking during SCTP packet handling, s= o I do not believe this to be a pf bug.

Reverting both commits avoids the problem.

It=E2=80=99s also failing during the CI tests: https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/23957/co= nsole

(To reproduce, kldload pf sctp ; cd /usr/tests/sys/netpfi= l/pf ; sudo kyua test sctp:basic_v4).

Best regards,
Kristof

--=_MailMate_77BDF089-8206-4FA3-8412-9857890C3CAE_=--