From nobody Thu Aug 03 11:50:57 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RGnH93CXMz2thfJ; Thu, 3 Aug 2023 11:51:01 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RGnH84f96z3WGm; Thu, 3 Aug 2023 11:51:00 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.2/8.16.1) with ESMTP id 373BoviM000874; Thu, 3 Aug 2023 14:50:57 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.2/8.16.1/Submit) id 373BovQb000873; Thu, 3 Aug 2023 14:50:57 +0300 (MSK) (envelope-from dchagin) Date: Thu, 3 Aug 2023 14:50:57 +0300 From: Dmitry Chagin To: Konstantin Belousov Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 5a7e48dddfb5 - main - tests: Add MAP_32BIT flag test Message-ID: References: <202308012024.371KOAHb046216@gitrepo.freebsd.org> <7A066A1D-9AFA-485F-AEAE-DD88C9537A44@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4RGnH84f96z3WGm X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU] On Wed, Aug 02, 2023 at 12:57:36AM +0300, Konstantin Belousov wrote: > On Tue, Aug 01, 2023 at 09:29:32PM +0100, Jessica Clarke wrote: > > On 1 Aug 2023, at 21:24, Dmitry Chagin wrote: > > > > > > The branch main has been updated by dchagin: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=5a7e48dddfb5a668ded4742b79e6f6f88b647e6a > > > > > > commit 5a7e48dddfb5a668ded4742b79e6f6f88b647e6a > > > Author: Dmitry Chagin > > > AuthorDate: 2023-08-01 20:23:15 +0000 > > > Commit: Dmitry Chagin > > > CommitDate: 2023-08-01 20:23:15 +0000 > > > > > > tests: Add MAP_32BIT flag test > > > > > > Reviewed by: kib, markj > > > Differential Revision: https://reviews.freebsd.org/D41236 > > > MFC after: 1 month > > > --- > > > tests/sys/vm/Makefile | 8 ++++++ > > > tests/sys/vm/mmap_map_32bit_helper.c | 51 ++++++++++++++++++++++++++++++++++++ > > > tests/sys/vm/mmap_map_32bit_test.sh | 37 ++++++++++++++++++++++++++ > > > 3 files changed, 96 insertions(+) > > > > > > diff --git a/tests/sys/vm/Makefile b/tests/sys/vm/Makefile > > > index 8ef8a45e5f39..9aac49bc5320 100644 > > > --- a/tests/sys/vm/Makefile > > > +++ b/tests/sys/vm/Makefile > > > @@ -9,4 +9,12 @@ ATF_TESTS_C+= mlock_test \ > > > page_fault_signal \ > > > shared_shadow_inval_test > > > > > > +.if ${MACHINE_ARCH} != "i386" && ${MACHINE} != "arm" && \ > > > + (${MACHINE} != "powerpc" || ${MACHINE_ARCH} != "powerpc") > > > + # MAP_32BIT is only available on 64-bit platforms > > > > So use ${MACHINE_ABI:Mlong64} after including src.opts.mk? > > May be we should enable the MAP_32BIT flag on 32bit arches, instead? > It requests allocation below 2G, which is half of VA on i386, or 2/3 > on arm. Interestingly, it should work already from compat32. It's disturbing that no none has requested this, I can do that