From nobody Wed Apr 26 05:36:52 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q5ng85P0yz47FVS; Wed, 26 Apr 2023 05:36:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q5ng84LZQz4MlG; Wed, 26 Apr 2023 05:36:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682487412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TXeHU67WFmSucTrHe/s/noZCoPhr1qITwC9Rniw4eo8=; b=nn3/tE+edjyqeq7qyn3kc55QcEG75nDsi60P5Xvsuo3lvXtYyqayAjcXnE4gP2MgezVLCI Ctt3t96/zF2oHkYIr2s1N9MNfx/nGt1eaeuL6GeR73QfkPqFyCw757ffK57cif30gs/pPy R4Z4tCqre6W1aymMZ0XEEN+/kkpLA8mI6pEzJoruchN7mVOfUErDp5g1l+BHloTSWLOM8N b6AnUJ94Y99Jfvt0+pUOtoiNP4iJbbr0x56oHZFTwWlat/d+IfEtyadyFYyfwxfr0r81VO GZTiV0IVwxVUxonTKxkwOgpL6UDVPdCIuG0ksnPEHt5Mlq9p4ZOVQfmM1PrmQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682487412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TXeHU67WFmSucTrHe/s/noZCoPhr1qITwC9Rniw4eo8=; b=OX8Pyocvp2lV7zeuiWBUAo5wmneHoPhg4uMEvD/Cso6Z65Gc5COcaVEOyc8mlAX7FWBCT9 RulPRuYr2B8PzIdL1RJjty7IU9aCvQ8KLIuNEyB7ickfo/11o01bwUptgGObZuxTVDTngx TegDHIjGycGvDlkCxMwUDbPdGEH2WpMFbNyt2GzYjgHHdYFgSDmDCLM6YUGIJGL6T/bGEz bsJwvH8tF6bScEI2hspiH9vpDcbfdQlZyXvyHbD327gyQhBpX3NtALI3/EidRvGwd3bbik 7tmcvB2uDlzU1cwz8cIxc6R2Y9vFgOgdB0UzKbm7jxw88kbTW84fSFe+i5Yp4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682487412; a=rsa-sha256; cv=none; b=JiB06/PlnxOwLJ4xdxwnIK1318kkOFUQF/2DLyYR8M+k+rotJYFcNG8ltW/bpk1dpbB6mv 3/lOucWbbQC9GnUA4jkWR0LbEe17wqTk9XIUBDvftv6rLHBQfjgoh1q7xb9QuLKxs/Jt8u f8VuLQYvTuXT7cyBhdmnZqlhDwWULYYpXUo7YKGYzQr6RimwC+WH/rkuq5+gsGPtq8talf fh0wqQMYDxLWu2WMVQ+93FnIr/F1KEayHu3vVa9uvPliInAdSUeu9i3Cci9NBJ3bgSwlNM wZOpMN2VdjFOwsUtjl1x13WX0MB6W/ofzCdYgW4qnM7o7T02WzLtoVqLMfO02g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q5ng83CQQzMwP; Wed, 26 Apr 2023 05:36:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33Q5aqq5029815; Wed, 26 Apr 2023 05:36:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33Q5aqPA029814; Wed, 26 Apr 2023 05:36:52 GMT (envelope-from git) Date: Wed, 26 Apr 2023 05:36:52 GMT Message-Id: <202304260536.33Q5aqPA029814@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 3a5855dd220b - main - gbde: stop rebuilding sha512 bits List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3a5855dd220b00ab8b1c94a95e2e44cdddb8417e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=3a5855dd220b00ab8b1c94a95e2e44cdddb8417e commit 3a5855dd220b00ab8b1c94a95e2e44cdddb8417e Author: Kyle Evans AuthorDate: 2023-04-26 05:36:33 +0000 Commit: Kyle Evans CommitDate: 2023-04-26 05:36:33 +0000 gbde: stop rebuilding sha512 bits In the early days of gbde, it linked against libmd. Shortly after conception, phk replaced ARC4 with SHA-512, but libmd did not have SHA2 at the time thus he built a copy of sha2.c for gbde. Fast forward 3 years, cperciva adds SHA2 to libmd -- this makes gbde's build of sha2.c redundant, but it's (understandably) overlooked. Let's simplify the gbde build now and just assume that libmd includes the most optimal implementation. Reported by: koobs (weird lto errors?) Differential Revision: https://reviews.freebsd.org/D34668 --- sbin/gbde/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/sbin/gbde/Makefile b/sbin/gbde/Makefile index 867a7f8e9b55..b1ee8edb9d80 100644 --- a/sbin/gbde/Makefile +++ b/sbin/gbde/Makefile @@ -5,7 +5,6 @@ PROG= gbde SRCS= gbde.c template.c SRCS+= rijndael-alg-fst.c SRCS+= rijndael-api-fst.c -SRCS+= sha512c.c SRCS+= g_bde_lock.c # rijndael-fst.c does evil casting things which can results in warnings,