From nobody Thu Apr 20 17:18:53 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q2PX10JBPz46LQK for ; Thu, 20 Apr 2023 17:18:57 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q2PX05f07z448D for ; Thu, 20 Apr 2023 17:18:56 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-2f7c281a015so508982f8f.1 for ; Thu, 20 Apr 2023 10:18:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682011134; x=1684603134; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aLDH43atIn1gj7+mbkWVgV88FnAOgnaAbZ4u0YODz/Q=; b=AAja6DKTmSRZzjxFPwR45qu52rH91kzofcfCw5QU6cgwYfEe06PjH4zx46VLaH0EAa +uVzZKcAljzGHcShwsRY4BGQPw8wT8/DTKNUX6btjveYIRKHJsa+IdoWC0ht6WsToVVN kK+KHcRLpDguv38PEqN6uOLSW2IyM21ZEIln5/V/GUEMjnhK4Vac7LO482MadjXokgq6 eOtQO6r8GkRkgYQxoUaChwoBm7yIBi50v8kTFEQ1Pl7ieFk/RhCrK01wUHATCLD8zo0t qyhdTUF9Aky0WKJh6YoY9MIC7IRolrMXl6tvP9JfQA2w+53w42x29SvLx7NnYgcYtxML 15Jw== X-Gm-Message-State: AAQBX9e4v1HyIX/o0V+ZOzJtYLpIpz3iqufQXJ2EB9phwqugWWRymyia bk62YEEaOE+pV0XUFJgtmxJItw== X-Google-Smtp-Source: AKy350aFQkQNsvrnYwrTj4BbbRY8/p43lbhVn8G0qvMiN6cCf87xMNYGI3QHins0dMGceI/DsHfB9w== X-Received: by 2002:a05:6000:136a:b0:2ef:9837:6b2b with SMTP id q10-20020a056000136a00b002ef98376b2bmr2145075wrz.21.1682011134529; Thu, 20 Apr 2023 10:18:54 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id f17-20020a5d58f1000000b002cea8e3bd54sm2430860wrd.53.2023.04.20.10.18.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Apr 2023 10:18:53 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: bb8e8e230d94 - main - Revert "libc: Implement bsort(3) a bitonic type of sorting algorithm." From: Jessica Clarke In-Reply-To: <202304201717.33KHHJsQ044448@gitrepo.freebsd.org> Date: Thu, 20 Apr 2023 18:18:53 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <145FD575-5987-4BD8-805D-26DB13EBF06A@freebsd.org> References: <202304201717.33KHHJsQ044448@gitrepo.freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4Q2PX05f07z448D X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 20 Apr 2023, at 18:17, Hans Petter Selasky = wrote: >=20 > The branch main has been updated by hselasky: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbb8e8e230d94c9522bd9ff95c13dc9f5= b1592929 >=20 > commit bb8e8e230d94c9522bd9ff95c13dc9f5b1592929 > Author: Hans Petter Selasky > AuthorDate: 2023-04-20 16:50:32 +0000 > Commit: Hans Petter Selasky > CommitDate: 2023-04-20 17:16:14 +0000 >=20 > Revert "libc: Implement bsort(3) a bitonic type of sorting = algorithm." >=20 > Some points for the future: > - libc is not the right place for sorting algorithms. > Probably libutil is better suited for this purpose or > a dedicated libsort. Should move all sorting algorithms > away from libc eventually. qsort is part of ISO C, so no. > - CheriBSD uses capabilities for memory access, and could > benefit from a standard memswap() function. > - Do something about qsort() in FreeBSD's libc like: > - Mark it deprecated on FreeBSD, as a first step, > due to missing limits on CPU time. Nobody=E2=80=99s saying that, quite the opposite. It=E2=80=99s in ISO C. > - Audit the use of qsort() in the FreeBSD base system > and consider swapping to other existing sorting > algorithms. No. We=E2=80=99re saying to make the implementation better. Jess > Discussed with: brooks@ >=20 > Differential Revision: https://reviews.freebsd.org/D36493 >=20 > This reverts commit a7469c9c0a504a5e6e9b89e148cd78df5e67ff7f. > This reverts commit 7d65a450cdcc7cc743f2ecd114ba3428a21c0033. > This reverts commit 8dcf3a82c54cb216df3213a013047907636a01da.