From nobody Tue Apr 18 17:56:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q1BSg59K1z45QVw; Tue, 18 Apr 2023 17:56:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q1BSf6gsjz3wcZ; Tue, 18 Apr 2023 17:56:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681840610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0dxTkv0+2mTvKzY3czO1GCp3Q736H5qWDNxRkJSBRA=; b=k6eJes+IGRlqNmQ4WlIXaQrQw/7qEWzh0ntWu3nkjypKVu4copyixhCT7q4kmTLM4g01mB PBXIgjPa5J/2x8ynY3RrvPuRqFR7O/zCKmwGcr6iWaCugM36KM1RsrwRkzs2ehnZXLbIWt AripwXHdW6SUrb9HFQ2pB6Z+mPOY5cPQ0r1y3/zTuGnLsxBqYnavY2q82ubMWo6yMx93Iq f48IpedL69tgPkPsYLD6dzWp46E5b8ErJL6ilmVsewDXfAwpwNZtaG8haFwVOXkl+eCgts DI88x+gZDd5/gfaveAxX00aHBS4+JLcl27Eo0UaIrxuA+YBLCDlx3O/a6oP2Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681840610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0dxTkv0+2mTvKzY3czO1GCp3Q736H5qWDNxRkJSBRA=; b=BCMtAQ086QO3A4Nr/sxFJFVkcPi6m/UJffSVbTWYxAaPhgknvpr65XshTrgpFxxqNcMgdw GymS1Vk/CN8pzxlIHNf2GJGemu0NnpWvWahnxvOdDEyoqQY7S5IpgazPjdg1PUsbn94Iez ddWsT/iD7yfrB/VqBDfIm9QszX17u1vLdfVapH1/Jg9DOxK87V2a5XzVSW1o2dMf6rNrTp WsOXrJbNmpsRjZwfr7eLl/cMPxBXjG9s02nEyXMREXNsq3hIylei9DmocXJqrhX2ts5VT6 pe9Qao1jlO53CxxLaDq4dvmBSSlmy2aYLnP5rTLZaxg1KNBR5hF7zgPfMdZESg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681840610; a=rsa-sha256; cv=none; b=B8llbGHfvGNSQBqT0xqW/cb65Bjpk157M+HP3f9bMpB5UVoPFioGExO4unidzEq03HLslW MMvhNm+EH2VdQnmn7WaT3B6d2+GPY27GJ/hplJZVnKjlxjH7fklKgiNwnayVAYYAlNANlF yQkVBE54EH2CpPHGky14W0H/Wksh665XS3derr+2H54PMClBTty9JMTDpA0FaqLSQOHEzP N3PgVpwoF8LywR33eoladxDouVWMYwQrp5YVpGwv5+EpkRFPKnszdpam541TuAuKMWcYvc zk181kaJIuK0oJ8dTP3S/IunnJHCrheoaY326uh6hFzGplhUmbTJ4JHONBY1yw== Received: from [IPV6:2601:648:8680:16b0:f507:782d:159f:3068] (unknown [IPv6:2601:648:8680:16b0:f507:782d:159f:3068]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q1BSf1QJvz19C2; Tue, 18 Apr 2023 17:56:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 18 Apr 2023 10:56:49 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: git: b12ccd0bb1b3 - main - stand: Remove double words in source code comments Content-Language: en-US To: Alexey Dokuchaev , Gordon Bergling Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202304180515.33I5FKdK006761@gitrepo.freebsd.org> <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 4/17/23 11:59 PM, Alexey Dokuchaev wrote: > On Tue, Apr 18, 2023 at 08:12:51AM +0200, Gordon Bergling wrote: >> On Tue, Apr 18, 2023 at 06:31:28AM +0100, Jessica Clarke wrote: >>> On 18 Apr 2023, at 06:15, Gordon Bergling wrote: >> [...] >>>> --- a/stand/i386/boot0/Makefile >>>> +++ b/stand/i386/boot0/Makefile >>>> @@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f >>>> # 0xb6 (182d) corresponds to 10 seconds. >>>> BOOT_BOOT0_TICKS?= 0xb6 >>>> >>>> -# The base address that we the boot0 code to to run it. Don't change this >>>> +# The base address that we the boot0 code to run it. Don't change this >>> >>> This was correct and is now incorrect; read as "that we [load] the >>> boot0 code to in order to run it". >> >> I just reverted the change. Sorry, not a native speaker on this side >> and the sentence was a little hard to understand. > > This reminds me of the situation with commit 8ca67bf1273 which jrtc27@ > pointed out was wrong, so I'd say again that comments like this should > be rephrased: these consequent double words make it hard to understand > and just begging for someone to try to "fix" it again in the future. Yes, I'll try to reword it. Gordon, your second change here was correct (the double "value") and you should go ahead and re-do that one. -- John Baldwin