From nobody Tue Apr 18 13:02:10 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q13wg1MgHz454xd; Tue, 18 Apr 2023 13:02:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q13wf3fSSz4KtW; Tue, 18 Apr 2023 13:02:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681822930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GL8gaRatZTPo0FMfKLs+R3Tn70o961ZSREPOUngidpM=; b=hddjk3GaODOXr/7RWH2vUlqBsx5eA8rYIIMgrs1MkwoNwAh5J1t37C1u6GTw7L9xdqwjJp 8w+E7DJM6l8pxMdVrimaHTapoNCj82D9Zp8xlYIarktPUHSfulsBgHYaXfuw/AgTIq/Bjd bat7HNbeL3CYxZaXhIJ/SODbNzBt8mJ73fc4e4JoGsznYQGc/hVJw9LsWfSHsrtWsHOsq6 IJsvvU/EpWQMSIG6W2VFGrDoSm7oCIjOlEhoIpXAX/NMCgJRyMa6jKVfJCBi8lLbOuCiiK Yjjoo7hjRLxXi6c0G2qEquG+ZH6J5hKVAK0mqlfVZNQVJL2uTKf3WOWHd/xG4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681822930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GL8gaRatZTPo0FMfKLs+R3Tn70o961ZSREPOUngidpM=; b=Hekvo2AF4pabI7DjIAj5j/bCLycZl1GJlFa1FZnW88EIwsHKDdP8OPh0PwRfdJqblp9tnJ Nl3VyCQph4W8MHENRCxm4aE8uBIFFXcjDGIcIdHy6tNCI5XBg5r9cezmpbWYhess5224DO 6UJYmBU5kXVMfag4nmurI6jOj5JQpMv7DLA9vnoJzP7ib7F9a4+ADskgWRzngJWd2enfzB gLkMzwsB9sEplzD3U+lR/BW243i+CatWtMVrS0m58wmCcOCFiW7X6cwKjbzGNRQTliJmeb k+f7/ANhqKIPOM/mWnPA8P3pJEB4jSM1HB3eI9KuNamzVFVTtj/Ac58r8iqOFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681822930; a=rsa-sha256; cv=none; b=YSnXBIoNXsbYbBxOdS+b9eGTJlHXtgJjrbKWlBGT9Cd87O8MxApSzUOOq3vpPS2PTTWgVV jpHexBIQ7G4uRHyMkTsc9TxVO92OO8WNfku10ol4G6ZfgcAZYRnHKSNgM4fd6mqPbXsJMM JXvEfn3sSCK7VhsT08X9JiG1e9AgZOKHQnuYdUwYZgFFDHNQwdF5K+YNMSv4qmPx9GQ6Ut vvBKI3wtDEQYyoMDkGDh8JUnoj9zsvfz2sP2asG0gHTjKrlrWd5x1X2yPN7hct1gWwRzvX hZMOMAv59Dd9inoT72cyIs3U8QuPvWlPsPGw44scIM8GQ3SlpLAn/o3VVnD4KA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q13wf1xTxz1C3h; Tue, 18 Apr 2023 13:02:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33ID2Amu079123; Tue, 18 Apr 2023 13:02:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33ID2Awl079122; Tue, 18 Apr 2023 13:02:10 GMT (envelope-from git) Date: Tue, 18 Apr 2023 13:02:10 GMT Message-Id: <202304181302.33ID2Awl079122@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Hans Petter Selasky Subject: git: 6bd4bb9bdbad - main - mlx5en(4): Explain why CQE zipping is off. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6bd4bb9bdbadb76c5502c7972df9f525b909e2f5 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=6bd4bb9bdbadb76c5502c7972df9f525b909e2f5 commit 6bd4bb9bdbadb76c5502c7972df9f525b909e2f5 Author: Hans Petter Selasky AuthorDate: 2023-04-18 11:12:32 +0000 Commit: Hans Petter Selasky CommitDate: 2023-04-18 13:01:07 +0000 mlx5en(4): Explain why CQE zipping is off. MFC after: 1 week Sponsored by: NVIDIA Networking --- sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c index ab0cf49c2e8a..7a11bedffb10 100644 --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c @@ -3873,9 +3873,10 @@ mlx5e_build_ifp_priv(struct mlx5_core_dev *mdev, priv->params.lro_wqe_sz = MLX5E_PARAMS_DEFAULT_LRO_WQE_SZ; /* - * CQE zipping is currently defaulted to off. when it won't - * anymore we will consider the HW capability: - * "!!MLX5_CAP_GEN(mdev, cqe_compression)" + * CQE zipping is off, because the per-packet 32-bit Toeplitz hash + * is then not supported. The 32-bit Toeplitz hash is needed to + * correctly demultiplex incoming traffic into the expected + * network queues. */ priv->params.cqe_zipping_en = false;