From nobody Tue Apr 18 06:59:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0vtZ23K0z45rfB; Tue, 18 Apr 2023 06:59:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0vtZ1GfBz4K3K; Tue, 18 Apr 2023 06:59:50 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681801190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3rsyi8VqqWV4A+QNUxL4iwEEmAYFPtrU+QoF3TWl8U=; b=lHKAfStzvGYxq6pdOjezUq9IaY7oq6OH/J3pdYPpMESwJEvBEvnmTU92KodadnVjG8nzJt Pud/XTB/aFAks4B6hXZj0MhfwpuLgv/lDjXMnSLaexeZA3eruM73gDsv61WK1dP4zYXYn9 VS9byV3aKBolQpwIvYGUPHBA208dF3zBKLfKjLKqRrpdSjyCl4k/g8NlEcaSoepwP6/UYj OohsRKAXxvUxMY/sQ89vckj/usQKhwkKkAJZgpB4drzJe8COOXB0BtLHeoRLIiNnvpVovs FhX2zIKPSB63ADJw4bz51B7Tm/qk4jESxsWu//aS1Yx3sx32EMLesn7q+yYbCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681801190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3rsyi8VqqWV4A+QNUxL4iwEEmAYFPtrU+QoF3TWl8U=; b=rEjUkaeIL5zO0hdKv4hNZxkHQsAvRCGV1CfWvwLhSheqKU7nxxfSrn8ZFy9TUi63aQ4h18 24T+Ncx9yLYa0DWcK81/YutBXVQdPUSCOa5ygnjvWA+NDwy9Sbh6J2JvZcYF1paDszq7mv ZqTyMcmMtjnFukE3Nnd+ejQzeJU6NhPIA2MahFnKf4/iO26JRHFUqhqDWY2DYiIqd3S8Sx OyNI9gfivYLz1fXulrAArA58ITvMxZW3MSFUuB5kwp/XciU1eyZ5mxRf52yfz26csJTo8w qJIT1+P/Bnfugew9OjdiApt5MLnRFvJh3Hi7m4t/soibVPVF/uy1YM5c14LrVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681801190; a=rsa-sha256; cv=none; b=v28VLbNvtLDGC/2TxIBo11acbGdpw+8PrTa36hI+JzFLGAE4xZ4+DXyzO3Cv5nG2tV2TXa s3dqwY3PY77l2WCO0N81lG2wuEGczoDr/PS/x/yQigO2CdK3aQZZ0Lwh/dTFGWIrMy8HFL ImtQ86XvMgc8dq0Q382ouHEB7seQjyOi6owMGo7Vr9FEDB+Z2yJLK31uIF6VHFyTo3jBuC Rfknz9nOnOIlmEohToF9jV1g242vyXhxQBbGh+Tuy1HQLMZlwH/9rXumjidm8NSKPEhP1r wkaiOOFS+rSXzF7TIfrD7auUND/eTsrykm4XweKJi9NdIdbCY1jWHYslBTNLjA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 125EF17570; Tue, 18 Apr 2023 06:59:49 +0000 (UTC) Date: Tue, 18 Apr 2023 06:59:49 +0000 From: Alexey Dokuchaev To: Gordon Bergling Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: b12ccd0bb1b3 - main - stand: Remove double words in source code comments Message-ID: References: <202304180515.33I5FKdK006761@gitrepo.freebsd.org> <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Tue, Apr 18, 2023 at 08:12:51AM +0200, Gordon Bergling wrote: > On Tue, Apr 18, 2023 at 06:31:28AM +0100, Jessica Clarke wrote: > > On 18 Apr 2023, at 06:15, Gordon Bergling wrote: > [...] > > > --- a/stand/i386/boot0/Makefile > > > +++ b/stand/i386/boot0/Makefile > > > @@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f > > > # 0xb6 (182d) corresponds to 10 seconds. > > > BOOT_BOOT0_TICKS?= 0xb6 > > > > > > -# The base address that we the boot0 code to to run it. Don't change this > > > +# The base address that we the boot0 code to run it. Don't change this > > > > This was correct and is now incorrect; read as "that we [load] the > > boot0 code to in order to run it". > > I just reverted the change. Sorry, not a native speaker on this side > and the sentence was a little hard to understand. This reminds me of the situation with commit 8ca67bf1273 which jrtc27@ pointed out was wrong, so I'd say again that comments like this should be rephrased: these consequent double words make it hard to understand and just begging for someone to try to "fix" it again in the future. ./danfe